Copy latest sql dll to extension bundle in pipeline #395
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lucyzhang929
requested review from
Charles-Gagnon,
MaddyDev and
chlafreniere
as code owners
lucyzhang929
commented
Oct 13, 2022
lucyzhang929
commented
Oct 13, 2022
|
|
||
| // Change database collation to case sensitive | ||
| this.ExecuteNonQuery($"ALTER DATABASE {this.DatabaseName} COLLATE Latin1_General_CS_AS"); | ||
| this.ExecuteNonQuery($"ALTER DATABASE {this.DatabaseName} SET Single_User WITH ROLLBACK IMMEDIATE; ALTER DATABASE {this.DatabaseName} COLLATE Latin1_General_CS_AS; ALTER DATABASE {this.DatabaseName} SET Multi_User;"); |
Contributor
Author
There was a problem hiding this comment.
Modified this because I was getting the following error when running this test locally:
The database could not be exclusively locked to perform the operation
Charles-Gagnon
approved these changes
Oct 13, 2022
PBBlox
pushed a commit
to PBBlox/azure-functions-sql-extension
that referenced
this pull request
Apr 6, 2025
* cp sql dll to extension bundle * remove quotes + add windows condition * fix path * add bin to path + add linux * use source folder * use preview path * add overwrite and ignore mkdir errors * fix target folder path * remove ignoreMakeDirErrors * add wait for case sensitivity test * use one task * set cache timeout to 0 * fix target path * pr comments + add timeout var linux * set cache to 0 for one test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a task in the build pipeline to copy the latest sql dll to the extension bundle so that the latest changes can be used for non-CSharp tests. Passing ad hoc build https://mssqltools.visualstudio.com/CrossPlatBuildScripts/_build/results?buildId=174829&view=results
I also realized that the case sensitive test was failing after this PR: #388 (my bad for not noticing that the PR validation was not running when I merged in the PR). The test failed because we cache the table info for 10 minutes so when we change the table collation back to case insensitive, SqlAsyncCollector still thinks the collation is case sensitive.
I couldn't figure out why the cache was being missed previously (the cache was empty during the second upsert) and I didn't change the caching logic is this PR #388 so not sure what exact change caused the table caching to work.