-
Notifications
You must be signed in to change notification settings - Fork 63
Copy latest sql dll to extension bundle in pipeline #395
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
15 commits
Select commit
Hold shift + click to select a range
3a9ef28
cp sql dll to extension bundle
lucyzhang929 e303bc1
remove quotes + add windows condition
lucyzhang929 19ae5ec
fix path
lucyzhang929 242b594
add bin to path + add linux
lucyzhang929 f644f5a
use source folder
lucyzhang929 471e976
use preview path
lucyzhang929 dc9525b
add overwrite and ignore mkdir errors
lucyzhang929 46a5c38
fix target folder path
lucyzhang929 27705b9
remove ignoreMakeDirErrors
lucyzhang929 4b2f0d2
add wait for case sensitivity test
lucyzhang929 3a31f31
use one task
lucyzhang929 67adc3e
set cache timeout to 0
lucyzhang929 1e63322
fix target path
lucyzhang929 307dfd1
pr comments + add timeout var linux
lucyzhang929 0b78726
set cache to 0 for one test
lucyzhang929 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -352,10 +352,15 @@ public void AddProductWithIdentity_MissingPrimaryColumn(SupportedLanguages lang) | |
| [SqlInlineData()] | ||
| public void AddProductCaseSensitiveTest(SupportedLanguages lang) | ||
| { | ||
| this.StartFunctionHost(nameof(AddProductParams), lang); | ||
| // Set table info cache timeout to 0 minutes so that new collation gets picked up | ||
| var environmentVariables = new Dictionary<string, string>() | ||
| { | ||
| { "AZ_FUNC_TABLE_INFO_CACHE_TIMEOUT_MINUTES", "0" } | ||
| }; | ||
| this.StartFunctionHost(nameof(AddProductParams), lang, false, null, environmentVariables); | ||
|
|
||
| // Change database collation to case sensitive | ||
| this.ExecuteNonQuery($"ALTER DATABASE {this.DatabaseName} COLLATE Latin1_General_CS_AS"); | ||
| this.ExecuteNonQuery($"ALTER DATABASE {this.DatabaseName} SET Single_User WITH ROLLBACK IMMEDIATE; ALTER DATABASE {this.DatabaseName} COLLATE Latin1_General_CS_AS; ALTER DATABASE {this.DatabaseName} SET Multi_User;"); | ||
|
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Modified this because I was getting the following error when running this test locally: |
||
|
|
||
| var query = new Dictionary<string, string>() | ||
| { | ||
|
|
@@ -369,7 +374,7 @@ public void AddProductCaseSensitiveTest(SupportedLanguages lang) | |
| Assert.Throws<AggregateException>(() => this.SendOutputGetRequest("addproduct-params", query).Wait()); | ||
|
|
||
| // Change database collation back to case insensitive | ||
| this.ExecuteNonQuery($"ALTER DATABASE {this.DatabaseName} COLLATE Latin1_General_CI_AS"); | ||
| this.ExecuteNonQuery($"ALTER DATABASE {this.DatabaseName} SET Single_User WITH ROLLBACK IMMEDIATE; ALTER DATABASE {this.DatabaseName} COLLATE Latin1_General_CI_AS; ALTER DATABASE {this.DatabaseName} SET Multi_User;"); | ||
|
|
||
| this.SendOutputGetRequest("addproduct-params", query).Wait(); | ||
|
|
||
|
|
||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.