Trigger bindings -> main

.editorconfig

@@ -10,6 +10,9 @@ dotnet_analyzer_diagnostic.severity = error
 # Namespace does not match folder structure - Ideally this should be enabled but it seems to have issues with root level files so disabling for now
 dotnet_diagnostic.IDE0130.severity = none
 
+# CA1805: Do not initialize unnecessarily - It's better to be explicit when initializing vars to ensure correct value is used
+dotnet_diagnostic.CA1805.severity = none
+
 # Documentation related errors, remove once they are fixed
 dotnet_diagnostic.CS1591.severity = none
 dotnet_diagnostic.CS1573.severity = none

performance/.editorconfig

@@ -0,0 +1,10 @@
+# See https://github.com/dotnet/roslyn-analyzers/blob/main/.editorconfig for an example on different settings and how they're used
+
+[*.cs]
+
+# Disabled
+dotnet_diagnostic.CA1309.severity = silent # Use ordinal StringComparison - this isn't important for tests and just adds clutter
+dotnet_diagnostic.CA1305.severity = silent # Specify IFormatProvider - this isn't important for tests and just adds clutter
+dotnet_diagnostic.CA1707.severity = silent # Identifiers should not contain underscores - this helps make test names more readable
+dotnet_diagnostic.CA2201.severity = silent # Do not raise reserved exception types - tests can throw whatever they want
+dotnet_diagnostic.CA1051.severity = silent # Do not declare visible instance fields - doesn't matter for tests

performance/SqlBindingBenchmarks.cs

@@ -11,6 +11,11 @@ public static void Main()
         {
             BenchmarkRunner.Run<SqlInputBindingPerformance>();
             BenchmarkRunner.Run<SqlOutputBindingPerformance>();
+            BenchmarkRunner.Run<SqlTriggerBindingPerformance>();
+            BenchmarkRunner.Run<SqlTriggerBindingPerformance_BatchOverride>();
+            BenchmarkRunner.Run<SqlTriggerBindingPerformance_PollingIntervalOverride>();
+            BenchmarkRunner.Run<SqlTriggerPerformance_Overrides>();
+            BenchmarkRunner.Run<SqlTriggerBindingPerformance_Parallelization>();
         }
     }
 }

performance/SqlTriggerBindingPerformance.cs

@@ -0,0 +1,38 @@
+// Copyright (c) Microsoft Corporation. All rights reserved.
+// Licensed under the MIT License. See License.txt in the project root for license information.
+
+using System.Threading.Tasks;
+using Microsoft.Azure.WebJobs.Extensions.Sql.Samples.TriggerBindingSamples;
+using Microsoft.Azure.WebJobs.Extensions.Sql.Tests.Common;
+using BenchmarkDotNet.Attributes;
+
+namespace Microsoft.Azure.WebJobs.Extensions.Sql.Performance
+{
+    [MemoryDiagnoser]
+    public class SqlTriggerBindingPerformance : SqlTriggerBindingPerformanceTestBase
+    {
+        [GlobalSetup]
+        public void GlobalSetup()
+        {
+            this.SetChangeTrackingForTable("Products", true);
+            this.StartFunctionHost(nameof(ProductsTrigger), SupportedLanguages.CSharp);
+        }
+
+        [Benchmark]
+        [Arguments(1)]
+        [Arguments(10)]
+        [Arguments(100)]
+        [Arguments(1000)]
+        public async Task ProductsTriggerTest(int count)
+        {
+            await this.WaitForProductChanges(
+                1,
+                count,
+                SqlChangeOperation.Insert,
+                () => { this.InsertProducts(1, count); return Task.CompletedTask; },
+                id => $"Product {id}",
+                id => id * 100,
+                this.GetBatchProcessingTimeout(1, count));
+        }
+    }
+}

performance/SqlTriggerBindingPerformanceTestBase.cs

@@ -0,0 +1,40 @@
+// Copyright (c) Microsoft Corporation. All rights reserved.
+// Licensed under the MIT License. See License.txt in the project root for license information.
+
+using Microsoft.Azure.WebJobs.Extensions.Sql.Tests.Integration;
+using BenchmarkDotNet.Attributes;
+
+namespace Microsoft.Azure.WebJobs.Extensions.Sql.Performance
+{
+    public class SqlTriggerBindingPerformanceTestBase : SqlTriggerBindingIntegrationTests
+    {
+        [IterationCleanup]
+        public void IterationCleanup()
+        {
+            // Delete all rows in Products table after each iteration so we start fresh each time
+            this.ExecuteNonQuery("TRUNCATE TABLE Products");
+            // Clear the leases table, otherwise we may end up getting blocked by leases from a previous run
+            this.ExecuteNonQuery(@"DECLARE @cmd varchar(100)
+            DECLARE cmds CURSOR FOR
+            SELECT 'TRUNCATE TABLE az_func.' + Name + ''
+            FROM sys.tables
+            WHERE Name LIKE 'Leases_%'
+
+            OPEN cmds
+            WHILE 1 = 1
+            BEGIN
+                FETCH cmds INTO @cmd
+                IF @@fetch_status != 0 BREAK
+                EXEC(@cmd)
+            END
+            CLOSE cmds;
+            DEALLOCATE cmds");
+        }
+
+        [GlobalCleanup]
+        public void GlobalCleanup()
+        {
+            this.Dispose();
+        }
+    }
+}

performance/SqlTriggerBindingPerformance_Parallelization.cs

@@ -0,0 +1,67 @@
+// Copyright (c) Microsoft Corporation. All rights reserved.
+// Licensed under the MIT License. See License.txt in the project root for license information.
+
+using System.Threading.Tasks;
+using Microsoft.Azure.WebJobs.Extensions.Sql.Samples.TriggerBindingSamples;
+using Microsoft.Azure.WebJobs.Extensions.Sql.Tests.Common;
+using BenchmarkDotNet.Attributes;
+
+namespace Microsoft.Azure.WebJobs.Extensions.Sql.Performance
+{
+    [MemoryDiagnoser]
+    public class SqlTriggerBindingPerformance_Parallelization : SqlTriggerBindingPerformanceTestBase
+    {
+        [Params(2, 5)]
+        public int HostCount;
+
+        [GlobalSetup]
+        public void GlobalSetup()
+        {
+            this.SetChangeTrackingForTable("Products", true);
+            for (int i = 0; i < this.HostCount; ++i)
+            {
+                this.StartFunctionHost(nameof(ProductsTrigger), SupportedLanguages.CSharp);
+            }
+        }
+
+        [Benchmark]
+        public async Task MultiHost()
+        {
+            int firstId = 1;
+            int lastId = 90;
+            await this.WaitForProductChanges(
+                firstId,
+                lastId,
+                SqlChangeOperation.Insert,
+                () => { this.InsertProducts(firstId, lastId); return Task.CompletedTask; },
+                id => $"Product {id}",
+                id => id * 100,
+                this.GetBatchProcessingTimeout(firstId, lastId));
+
+            firstId = 1;
+            lastId = 60;
+            // All table columns (not just the columns that were updated) would be returned for update operation.
+            await this.WaitForProductChanges(
+                firstId,
+                lastId,
+                SqlChangeOperation.Update,
+                () => { this.UpdateProducts(firstId, lastId); return Task.CompletedTask; },
+                id => $"Updated Product {id}",
+                id => id * 100,
+                this.GetBatchProcessingTimeout(firstId, lastId));
+
+            firstId = 31;
+            lastId = 90;
+            // The properties corresponding to non-primary key columns would be set to the C# type's default values
+            // (null and 0) for delete operation.
+            await this.WaitForProductChanges(
+                firstId,
+                lastId,
+                SqlChangeOperation.Delete,
+                () => { this.DeleteProducts(firstId, lastId); return Task.CompletedTask; },
+                _ => null,
+                _ => 0,
+                this.GetBatchProcessingTimeout(firstId, lastId));
+        }
+    }
+}

performance/SqlTriggerPerformance_BatchOverride.cs

@@ -0,0 +1,49 @@
+// Copyright (c) Microsoft Corporation. All rights reserved.
+// Licensed under the MIT License. See License.txt in the project root for license information.
+
+using System.Threading.Tasks;
+using Microsoft.Azure.WebJobs.Extensions.Sql.Samples.TriggerBindingSamples;
+using Microsoft.Azure.WebJobs.Extensions.Sql.Tests.Common;
+using BenchmarkDotNet.Attributes;
+using System.Collections.Generic;
+
+namespace Microsoft.Azure.WebJobs.Extensions.Sql.Performance
+{
+    [MemoryDiagnoser]
+    public class SqlTriggerBindingPerformance_BatchOverride : SqlTriggerBindingPerformanceTestBase
+    {
+
+        [Params(100, 1000)]
+        public int BatchSize;
+
+        [GlobalSetup]
+        public void GlobalSetup()
+        {
+            this.SetChangeTrackingForTable("Products", true);
+            this.StartFunctionHost(
+                nameof(ProductsTrigger),
+                SupportedLanguages.CSharp,
+                environmentVariables: new Dictionary<string, string>() {
+                    { "Sql_Trigger_BatchSize", this.BatchSize.ToString() }
+                });
+        }
+
+        [Benchmark]
+        [Arguments(0.1)]
+        [Arguments(0.5)]
+        [Arguments(1)]
+        [Arguments(5)]
+        public async Task Run(double numBatches)
+        {
+            int count = (int)(numBatches * this.BatchSize);
+            await this.WaitForProductChanges(
+                1,
+                count,
+                SqlChangeOperation.Insert,
+                () => { this.InsertProducts(1, count); return Task.CompletedTask; },
+                id => $"Product {id}",
+                id => id * 100,
+                this.GetBatchProcessingTimeout(1, count, batchSize: this.BatchSize));
+        }
+    }
+}

performance/SqlTriggerPerformance_Overrides.cs

@@ -0,0 +1,53 @@
+// Copyright (c) Microsoft Corporation. All rights reserved.
+// Licensed under the MIT License. See License.txt in the project root for license information.
+
+using System.Threading.Tasks;
+using Microsoft.Azure.WebJobs.Extensions.Sql.Samples.TriggerBindingSamples;
+using Microsoft.Azure.WebJobs.Extensions.Sql.Tests.Common;
+using BenchmarkDotNet.Attributes;
+using System.Collections.Generic;
+
+namespace Microsoft.Azure.WebJobs.Extensions.Sql.Performance
+{
+    [MemoryDiagnoser]
+    public class SqlTriggerPerformance_Overrides : SqlTriggerBindingPerformanceTestBase
+    {
+        [Params(1, 10, 100, 500)]
+        public int PollingIntervalMs;
+
+        [Params(500, 1000, 2000)]
+        public int BatchSize;
+
+        [GlobalSetup]
+        public void GlobalSetup()
+        {
+            this.SetChangeTrackingForTable("Products", true);
+            this.StartFunctionHost(
+                nameof(ProductsTrigger),
+                SupportedLanguages.CSharp,
+                environmentVariables: new Dictionary<string, string>() {
+                    { "Sql_Trigger_BatchSize", this.BatchSize.ToString() },
+                    { "Sql_Trigger_PollingIntervalMs", this.PollingIntervalMs.ToString() }
+                });
+        }
+
+        [Benchmark]
+        [Arguments(0.1)]
+        [Arguments(0.5)]
+        [Arguments(1)]
+        [Arguments(5)]
+        [Arguments(10)]
+        public async Task Run(double numBatches)
+        {
+            int count = (int)(numBatches * this.BatchSize);
+            await this.WaitForProductChanges(
+                1,
+                count,
+                SqlChangeOperation.Insert,
+                () => { this.InsertProducts(1, count); return Task.CompletedTask; },
+                id => $"Product {id}",
+                id => id * 100,
+                this.GetBatchProcessingTimeout(1, count, batchSize: this.BatchSize));
+        }
+    }
+}

performance/SqlTriggerPerformance_PollingIntervalOverride.cs

@@ -0,0 +1,44 @@
+// Copyright (c) Microsoft Corporation. All rights reserved.
+// Licensed under the MIT License. See License.txt in the project root for license information.
+
+using System.Threading.Tasks;
+using Microsoft.Azure.WebJobs.Extensions.Sql.Samples.TriggerBindingSamples;
+using Microsoft.Azure.WebJobs.Extensions.Sql.Tests.Common;
+using BenchmarkDotNet.Attributes;
+using System.Collections.Generic;
+
+namespace Microsoft.Azure.WebJobs.Extensions.Sql.Performance
+{
+    [MemoryDiagnoser]
+    public class SqlTriggerBindingPerformance_PollingIntervalOverride : SqlTriggerBindingPerformanceTestBase
+    {
+        [Params(1, 10, 100, 500, 2000)]
+        public int PollingIntervalMs;
+
+        [GlobalSetup]
+        public void GlobalSetup()
+        {
+            this.SetChangeTrackingForTable("Products", true);
+            this.StartFunctionHost(
+                nameof(ProductsTrigger),
+                SupportedLanguages.CSharp,
+                environmentVariables: new Dictionary<string, string>() {
+                    { "Sql_Trigger_PollingIntervalMs", this.PollingIntervalMs.ToString() }
+                });
+        }
+
+        [Benchmark]
+        public async Task Run()
+        {
+            int count = SqlTableChangeMonitor<object>.DefaultBatchSize * 2;
+            await this.WaitForProductChanges(
+                1,
+                count,
+                SqlChangeOperation.Insert,
+                () => { this.InsertProducts(1, count); return Task.CompletedTask; },
+                id => $"Product {id}",
+                id => id * 100,
+                this.GetBatchProcessingTimeout(1, count, pollingIntervalMs: this.PollingIntervalMs));
+        }
+    }
+}

samples/samples-csharp/TriggerBindingSamples/ProductsTrigger.cs

@@ -0,0 +1,23 @@
+// Copyright (c) Microsoft Corporation. All rights reserved.
+// Licensed under the MIT License. See License.txt in the project root for license information.
+
+using System.Collections.Generic;
+using Microsoft.Azure.WebJobs.Extensions.Sql.Samples.Common;
+using Microsoft.Extensions.Logging;
+using Newtonsoft.Json;
+
+namespace Microsoft.Azure.WebJobs.Extensions.Sql.Samples.TriggerBindingSamples
+{
+    public static class ProductsTrigger
+    {
+        [FunctionName(nameof(ProductsTrigger))]
+        public static void Run(
+            [SqlTrigger("[dbo].[Products]", ConnectionStringSetting = "SqlConnectionString")]
+            IReadOnlyList<SqlChange<Product>> changes,
+            ILogger logger)
+        {
+            // The output is used to inspect the trigger binding parameter in test methods.
+            logger.LogInformation("SQL Changes: " + JsonConvert.SerializeObject(changes));
+        }
+    }
+}

src/Microsoft.Azure.WebJobs.Extensions.Sql.csproj

@@ -37,6 +37,7 @@
     <PackageReference Include="Microsoft.AspNetCore.Http" />
     <InternalsVisibleTo Include="Microsoft.Azure.WebJobs.Extensions.Sql.Tests" Key="0024000004800000940000000602000000240000525341310004000001000100272736ad6e5f9586bac2d531eabc3acc666c2f8ec879fa94f8f7b0327d2ff2ed523448f83c3d5c5dd2dfc7bc99c5286b2c125117bf5cbe242b9d41750732b2bdffe649c6efb8e5526d526fdd130095ecdb7bf210809c6cdad8824faa9ac0310ac3cba2aa0523567b2dfa7fe250b30facbd62d4ec99b94ac47c7d3b28f1f6e4c8" />
     <InternalsVisibleTo Include="DynamicProxyGenAssembly2" Key="0024000004800000940000000602000000240000525341310004000001000100c547cac37abd99c8db225ef2f6c8a3602f3b3606cc9891605d02baa56104f4cfc0734aa39b93bf7852f7d9266654753cc297e7d2edfe0bac1cdcf9f717241550e0a7b191195b7667bb4f64bcb8e2121380fd1d9d46ad2d92d2d15605093924cceaf74c4861eff62abf69b9291ed0a340e113be11e6a7d3113e92484cf7045cc7" />
+    <InternalsVisibleTo Include="Microsoft.Azure.WebJobs.Extensions.Sql.Performance" Key="0024000004800000940000000602000000240000525341310004000001000100272736ad6e5f9586bac2d531eabc3acc666c2f8ec879fa94f8f7b0327d2ff2ed523448f83c3d5c5dd2dfc7bc99c5286b2c125117bf5cbe242b9d41750732b2bdffe649c6efb8e5526d526fdd130095ecdb7bf210809c6cdad8824faa9ac0310ac3cba2aa0523567b2dfa7fe250b30facbd62d4ec99b94ac47c7d3b28f1f6e4c8"/>
   </ItemGroup>
 
   <ItemGroup>