Trigger bindings -> main #469
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add telemetry for trigger binding * Remove table name from telemetry properties * Open SQL connection to fetch server version * Set connection props after connection is opened
* Add more debug logging * Move startlistener event * Move comment
* Add retry when attempting to release leases * Address comments * Address more comments * Change loop structure according to comment
…indings # Conflicts: # test/Unit/SqlInputBindingTests.cs
Static import SqlTriggerConstants
Add more perf benchmarks for Trigger
Use app locks for all transactions
* Throw exception for scaling configuration invalid value * Change Exception type
* Catch SqlException for existing object error * Update src/TriggerBinding/SqlTriggerListener.cs Co-authored-by: Charles Gagnon <chgagnon@microsoft.com> Co-authored-by: Charles Gagnon <chgagnon@microsoft.com>
Fix perf tests
…startup (#467) * Validate monitor config values and send max changes configuration on startup * Add enum values
Charles-Gagnon
requested review from
MaddyDev,
chlafreniere and
lucyzhang929
as code owners
# Conflicts: # README.md
Contributor
|
Should we merge-commit this branch into main? That will retain individual contributions, and will help with git-blame. |
Contributor
Author
|
Yeah that's a good suggestion. Wish we had been more diligent about squash-merging into triggerbindings but a little bit of a messy commit history is worth being able to easily track down the history of a change. |
PBBlox
pushed a commit
to PBBlox/azure-functions-sql-extension
that referenced
this pull request
Apr 6, 2025
Trigger bindings -> main
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(new branch because I made one small change to a pipeline and didn't want to send out a whole separate PR for just that)