Fix logic error in logging that logs errors in normal cases

[tmenninger]

There are coding mistakes in the constructers of both IotHubSendTask and IotHubReceiveTask that log errors under all normal conditions

Checklist

• I have read the [contribution guidelines] (https://github.com/Azure/azure-iot-sdk-java/blob/master/.github/CONTRIBUTING.md).
• I added or modified the existing tests to cover the change (we do not allow our test coverage to go down). Should not need more coverage if tests already cover the null/not null cases.
• If this is a modification that impacts the behavior of a public API
  • I edited the corresponding document in the devdoc folder and added or modified requirements. No API changes.
• I submitted this PR against the correct branch:
  • This pull-request is submitted against the master branch.

Description of the problem

Please correctly use braces

Description of the solution

 public IotHubReceiveTask(IotHubTransport transport)
    {
        if (transport == null)
            throw new IllegalArgumentException("Parameter 'transport' must not be null");

        // Codes_SRS_IOTHUBRECEIVETASK_11_001: [The constructor shall save the transport.]
        this.transport = transport;

        logger.LogError("IotHubReceiveTask constructor called with null value for parameter transport");
    }

should become

 public IotHubReceiveTask(IotHubTransport transport)
    {
        if (transport == null) {

             logger.LogError("IotHubReceiveTask constructor called with null value for parameter transport");
            throw new IllegalArgumentException("Parameter 'transport' must not be null");
       }
        
        // Codes_SRS_IOTHUBRECEIVETASK_11_001: [The constructor shall save the transport.]
        this.transport = transport;
    }

[msftclas]

@tmenninger,
Thanks for having already signed the Contribution License Agreement. Your agreement has not been validated yet. We will now review your pull request.
Thanks,
Microsoft Pull Request Bot

[prmathur-microsoft]

Thanks for providing this change. I'll merge this in.

[prmathur-microsoft]

Please follow braces style from coding guidelines - https://github.com/Azure/azure-iot-sdk-java/blob/master/.github/CODING_GUIDELINES.md

[tmenninger]

Fixed

[prmathur-microsoft]

Please follow braces style from coding guidelines - https://github.com/Azure/azure-iot-sdk-java/blob/master/.github/CODING_GUIDELINES.md

[tmenninger]

Fixed

[prmathur-microsoft]

I have two minor comments - if you can address them, this can easily go in. Thanks!

[prmathur-microsoft]

Thanks for addressing comments. Your changes have been squashed to a single commit and merged at 29a3bcd