Skip to content

Fix logic error in logging that logs errors in normal cases #97

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
tmenninger wants to merge 2 commits into from
Closed

Fix logic error in logging that logs errors in normal cases #97

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4bddd68
Fix logic error in logging that logs errors in normal cases
May 25, 2017
f311715
Code review fixes
May 26, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions ...-client/src/main/java/com/microsoft/azure/sdk/iot/device/transport/IotHubReceiveTask.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,14 +20,16 @@ public final class IotHubReceiveTask implements Runnable
public IotHubReceiveTask(IotHubTransport transport)
{


if (transport == null)
{

logger.LogError("IotHubReceiveTask constructor called with null value for parameter transport");
throw new IllegalArgumentException("Parameter 'transport' must not be null");
}

// Codes_SRS_IOTHUBRECEIVETASK_11_001: [The constructor shall save the transport.]
this.transport = transport;

logger.LogError("IotHubReceiveTask constructor called with null value for parameter transport");
}

public void run()
Expand Down
6 changes: 4 additions & 2 deletions ...ice-client/src/main/java/com/microsoft/azure/sdk/iot/device/transport/IotHubSendTask.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,12 +21,14 @@ public final class IotHubSendTask implements Runnable
public IotHubSendTask(IotHubTransport transport)
{
if (transport == null)
{

logger.LogError("IotHubSendTask constructor called with null value for parameter transport");
throw new IllegalArgumentException("Parameter 'transport' must not be null");
}

// Codes_SRS_IOTHUBSENDTASK_11_001: [The constructor shall save the transport.]
this.transport = transport;

logger.LogError("IotHubSendTask constructor called with null value for parameter transport");
}

public void run()
Expand Down