Skip to content

Fix for NullReference Bug during GetAzureRoleAssignmentsCommand #10976

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 6 commits into from
Closed

Fix for NullReference Bug during GetAzureRoleAssignmentsCommand #10976

wants to merge 6 commits into from

Conversation

@danybeam
Copy link
Contributor

@danybeam danybeam commented Jan 28, 2020 •
edited
Loading

Description

This PR will check if a RoleDefinitionName is null before comparing it.
This is done during the GetAzureRoleAssignmentsCommand

Checklist

  • I have read the Submitting Changes section of CONTRIBUTING.md
  • The title of the PR is clear and informative
  • The appropriate ChangeLog.md file(s) has been updated:
    • For any service, the ChangeLog.md file can be found at src/{{SERVICE}}/{{SERVICE}}/ChangeLog.md
    • A snippet outlining the change(s) made in the PR should be written under the ## Upcoming Release header -- no new version header should be added
  • The PR does not introduce breaking changes
  • If applicable, the changes made in the PR have proper test coverage
  • For public API changes to cmdlets:
    • a cmdlet design review was approved for the changes in this repository (Microsoft internal only)
    • the markdown help files have been regenerated using the commands listed here

@dagoroz
Check for null RoleDefinitionName in GetAzureRoleAssignmentCommand
cf2d10a 
Added tests for GetAzRoleAssingments using only the role name
Fix tests
Add region for parameter in GetAzureRoleAssignmentCommand
@dagoroz
Merge branch 'nullReferenceBug'
ecd097f
@dagoroz
Merge remote-tracking branch 'upstream/master'
b793536
@dagoroz
Add entry to changelog
0a3b54e
@danybeam danybeam requested a review from darshanhs90 January 28, 2020 00:23
markcowl
markcowl requested changes Jan 28, 2020
View reviewed changes
@danybeam
Copy link
Contributor Author

danybeam commented Feb 4, 2020

@markcowl bump

@danybeam danybeam closed this Feb 18, 2020
@danybeam danybeam mentioned this pull request Feb 19, 2020
Merged
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@markcowl markcowl Awaiting requested review from markcowl

1 more reviewer

@darshanhs90 darshanhs90 darshanhs90 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@danybeam danybeam

Labels

needs-revision

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@danybeam @markcowl @darshanhs90 @dagoroz