Skip to content

Null reference bug #11136

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Feb 19, 2020
Merged

Null reference bug #11136

merged 4 commits into from
Feb 19, 2020

Conversation

@danybeam
Copy link
Contributor

@danybeam danybeam commented Feb 19, 2020

Description

This PR will check if a RoleDefinitionName is null before comparing it.
This is done during the GetAzureRoleAssignmentsCommand

This is a remerging of an old PR that got abandoned (pre aproved by my team)
#10976

Checklist

  • I have read the Submitting Changes section of CONTRIBUTING.md
  • The title of the PR is clear and informative
  • The appropriate ChangeLog.md file(s) has been updated:
    • For any service, the ChangeLog.md file can be found at src/{{SERVICE}}/{{SERVICE}}/ChangeLog.md
    • A snippet outlining the change(s) made in the PR should be written under the ## Upcoming Release header -- no new version header should be added
  • The PR does not introduce breaking changes
  • If applicable, the changes made in the PR have proper test coverage
  • For public API changes to cmdlets:
    • a cmdlet design review was approved for the changes in this repository (Microsoft internal only)
    • the markdown help files have been regenerated using the commands listed here

dagoroz and others added 4 commits January 27, 2020 16:07
@dagoroz
Check for null RoleDefinitionName in GetAzureRoleAssignmentCommand
cf2d10a 
Added tests for GetAzRoleAssingments using only the role name
Fix tests
Add region for parameter in GetAzureRoleAssignmentCommand
@dagoroz
merge upstream master
98e7c2e
@dagoroz
fix readme merge
a2cd921
@danybeam
Merge branch 'master' into nullReferenceBug
24d762a
@danybeam danybeam requested a review from markcowl February 19, 2020 00:23
@wyunchi-ms wyunchi-ms merged commit 127d5c8 into Azure:master Feb 19, 2020
dingmeng-xue pushed a commit to dingmeng-xue/azure-powershell that referenced this pull request Mar 29, 2020
@wyunchi-ms
Merge pull request Azure#11136 from danybeam/nullReferenceBug
b8d050b 
Null reference bug
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@wyunchi-ms wyunchi-ms wyunchi-ms approved these changes

@markcowl markcowl Awaiting requested review from markcowl

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@danybeam @wyunchi-ms @dagoroz