[Network January] Disconnect VPN connections #11031
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ninweninwe
changed the title
Contributor
|
/azp run |
anton-evseev
suggested changes
Feb 10, 2020
VeryEarly
requested review from
wyunchi-ms
and removed request for
wyunchi-ms
VeryEarly
reviewed
Feb 12, 2020
|
|
||
| [Parameter( | ||
| ParameterSetName = CortexParameterSetNames.ByP2SVpnGatewayResourceId, | ||
| Mandatory = false, |
Collaborator
There was a problem hiding this comment.
this is true in the help file, why is false here
VeryEarly
reviewed
Feb 12, 2020
| [Alias("P2SVpnGateway")] | ||
| [Parameter( | ||
| ParameterSetName = CortexParameterSetNames.ByP2SVpnGatewayObject, | ||
| Mandatory = false, |
Collaborator
There was a problem hiding this comment.
this is true in the help file, why is false here
VeryEarly
reviewed
Feb 12, 2020
| ResourceManager.Common.AzureRMConstants.AzureRMPrefix + "P2SVpnGatewayVpnConnection", | ||
| DefaultParameterSetName = CortexParameterSetNames.ByP2SVpnGatewayName, | ||
| SupportsShouldProcess = true), | ||
| OutputType(typeof(PSP2SVpnGateway))] |
Collaborator
There was a problem hiding this comment.
this doesn't seem to match the help file
VeryEarly
reviewed
Feb 12, 2020
| namespace Microsoft.Azure.Commands.Network.VirtualNetworkGateway | ||
| { | ||
| [Cmdlet("Disconnect", ResourceManager.Common.AzureRMConstants.AzureRMPrefix + "VirtualNetworkGatewayVpnConnection", DefaultParameterSetName = "ByFactoryName", SupportsShouldProcess = true), OutputType(typeof(PSVirtualNetworkGateway))] | ||
| public class DisconnectVirtualNetworkGatewayVpnConnectionCommand : VirtualNetworkGatewayBaseCmdlet |
Collaborator
There was a problem hiding this comment.
This doesn't seem to match the help file
VeryEarly
reviewed
Feb 12, 2020
|
|
||
| [Alias("VirtualNetworkGatewayId")] | ||
| [Parameter( | ||
| Mandatory = false, |
Collaborator
There was a problem hiding this comment.
this is true in the help file, why is false here
VeryEarly
reviewed
Feb 12, 2020
|
|
||
| [Alias("VirtualNetworkGateway")] | ||
| [Parameter( | ||
| Mandatory = false, |
Collaborator
There was a problem hiding this comment.
this is true in the help file, why is false here
Collaborator
|
[Parameter(Mandatory = false)] are missing for both cmdlets |
8 tasks
dingmeng-xue
pushed a commit
to dingmeng-xue/azure-powershell
that referenced
this pull request
Mar 29, 2020
[Network January] Disconnect VPN connections
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Disconnect vpn connection for Virtual network gateway and P2S Vpn gateway.
Azure/azure-powershell-cmdlet-review-pr#414
Checklist
CONTRIBUTING.mdChangeLog.mdfile(s) has been updated:ChangeLog.mdfile can be found atsrc/{{SERVICE}}/{{SERVICE}}/ChangeLog.md## Upcoming Releaseheader -- no new version header should be added