Skip to content

Conversation

@ninweninwe
Copy link
Contributor

Description

Disconnect vpn connection for Virtual network gateway and P2S Vpn gateway. This is a follow up PR for #11031.

Azure/azure-powershell-cmdlet-review-pr#414

Checklist

  • I have read the Submitting Changes section of CONTRIBUTING.md
  • The title of the PR is clear and informative
  • The appropriate ChangeLog.md file(s) has been updated:
    • For any service, the ChangeLog.md file can be found at src/{{SERVICE}}/{{SERVICE}}/ChangeLog.md
    • A snippet outlining the change(s) made in the PR should be written under the ## Upcoming Release header -- no new version header should be added
  • The PR does not introduce breaking changes
  • If applicable, the changes made in the PR have proper test coverage
  • For public API changes to cmdlets:
    • a cmdlet design review was approved for the changes in this repository (Microsoft internal only)
    • the markdown help files have been regenerated using the commands listed here

Copy link
Collaborator

@VeryEarly VeryEarly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the output type in cmdlet code are the correct one.
How come the generated help file doesn't match the code?

Copy link
Collaborator

@VeryEarly VeryEarly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

output types seems not match the help files

@ninweninwe ninweninwe requested a review from VeryEarly February 13, 2020 21:51
@VeryEarly VeryEarly merged commit f913ab5 into Azure:network-january Feb 14, 2020
dingmeng-xue pushed a commit to dingmeng-xue/azure-powershell that referenced this pull request Mar 29, 2020
update disconnect vpn/p2svpn gateway vpn connections
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants