Making change in SQL MI tests to delegate subnet to SQL MI service

[stefbomdcs]

Description

Making change in SQL MI create related tests to have subnet delegated to SQL MI service as this will be forced by SQL MI and all create requests for non-delegated subnets will fail.

Checklist

• I have read the Submitting Changes section of CONTRIBUTING.md
• The title of the PR is clear and informative
• The appropriate ChangeLog.md file(s) has been updated:
  • For any service, the ChangeLog.md file can be found at src/{{SERVICE}}/{{SERVICE}}/ChangeLog.md
  • A snippet outlining the change(s) made in the PR should be written under the ## Upcoming Release header -- no new version header should be added
• The PR does not introduce breaking changes
• If applicable, the changes made in the PR have proper test coverage
• For public API changes to cmdlets:
  • a cmdlet design review was approved for the changes in this repository (Microsoft internal only)
  • the markdown help files have been regenerated using the commands listed here

[adxsdkps]

Can one of the admins verify this patch?

[msftclas]

All CLA requirements met.

[VeryEarly]

/azp run

[azure-pipelines]

Azure Pipelines successfully started running 3 pipeline(s).

[VeryEarly]

Hi @petrajkogit ,

since the change is on Common.ps1, can you please verify whether it has impact on other test cases

[stefbomdcs]

Hi @petrajkogit ,

since the change is on Common.ps1, can you please verify whether it has impact on other test cases

I've run one of the tests which is using the changed method. However, it looks like I'll need to run all tests which are using this method in recording mode, as there is one more ARM call added with this change.

[stefbomdcs]

@VeryEarly
Do you maybe know why it takes this long for these checks to complete?

[VeryEarly]

/azp run

[azure-pipelines]

Azure Pipelines successfully started running 3 pipeline(s).

[VeryEarly]

@VeryEarly
Do you maybe know why it takes this long for these checks to complete?

It looks like the CI was not triggered

[stefbomdcs]

@VeryEarly
Thanks for starting this. Am I missing some permission as it looks like that Merging is blocked?

[VeryEarly]

@stefbomdcs @petrajkogit ,

It looks to me the function CreateAndGetVirtualNetworkForManagedInstance
was been used by not just one test case.

Please also re-record test cases that referenced this function.

[stefbomdcs]

@VeryEarly
Yes, this function is referenced in all MI related test cases.
The tests which are creating MI are very expensive and creation of MI lasts about 4h.
I've tested the change thoroughly for all possible scenarios as it is scoped to adding delegation and NSG object to subnet.
Running all the tests will be very painful and time consuming.