Skip to content

Making change in SQL MI tests to delegate subnet to SQL MI service #11874

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 25, 2020
Merged

Making change in SQL MI tests to delegate subnet to SQL MI service #11874

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fea7d60
Initial commit
stefbomdcs May 11, 2020
09325c7
Change to add NSG to the subnet if there is no NSG assigned
stefbomdcs May 13, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
49 changes: 47 additions & 2 deletions src/Sql/Sql.Test/ScenarioTests/Common.ps1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1024,7 +1024,7 @@ function CreateAndGetVirtualNetworkForManagedInstance ($vnetName, $subnetName, $
$defaultSubnetAddressPrefix = "10.0.0.0/24"

try {
$getVnet = Get-AzVirtualNetwork -Name $vnetName -ResourceGroupName $resourceGroupName
$getVnet = DelegateSubnetToSQLMIAndGetVnet $vnetName $subnetName $resourceGroupName
return $getVnet
} catch {
$virtualNetwork = New-AzVirtualNetwork `
Expand Down Expand Up @@ -1056,7 +1056,52 @@ function CreateAndGetVirtualNetworkForManagedInstance ($vnetName, $subnetName, $
-NextHopType "Internet" `
| Set-AzRouteTable

$getVnet = Get-AzVirtualNetwork -Name $vnetName -ResourceGroupName $resourceGroupName
$getVnet = DelegateSubnetToSQLMIAndGetVnet $vnetName $subnetName $resourceGroupName
return $getVnet
}
}

<#
.SYNOPSIS
Delegate subnet to SQL MI service if not already delegated.
#>
function DelegateSubnetToSQLMIAndGetVnet ($vnetName, $subnetName, $resourceGroupName)
{
$vnet = Get-AzVirtualNetwork -Name $vnetName -ResourceGroupName $resourceGroupName
$subnet = Get-AzVirtualNetworkSubnetConfig -Name $subnetName -VirtualNetwork $vnet

$delegations = Get-AzDelegation -Subnet $subnet | ? {$_.ServiceName -eq "Microsoft.Sql/managedInstances"}

# Condition (Get-SqlTestMode) -eq 'Record' is addedd in order to skip this path in Playback mode
if ($delegations -eq $null -and (Get-SqlTestMode) -eq 'Record'){
$subnet = Add-AzDelegation -Name "test-delegation-sqlmi" -ServiceName "Microsoft.Sql/managedInstances" -Subnet $subnet
Set-AzVirtualNetwork -VirtualNetwork $vnet
$vnet = Get-AzVirtualNetwork -Name $vnetName -ResourceGroupName $resourceGroupName
$subnet = Get-AzVirtualNetworkSubnetConfig -Name $subnetName -VirtualNetwork $vnet
}

if ($subnet.NetworkSecurityGroup -eq $null -and (Get-SqlTestMode) -eq 'Record'){
$inboundAllowAllRule = New-AzNetworkSecurityRuleConfig -Name allow-all-inbound -Description "Allow all inbound" `
-Access Allow -Protocol * -Direction Inbound -Priority 100 -SourceAddressPrefix * `
-SourcePortRange * -DestinationAddressPrefix * -DestinationPortRange *

$outboundAllowAllRule = New-AzNetworkSecurityRuleConfig -Name allow-all-outbound -Description "Allow all outbound" `
-Access Allow -Protocol * -Direction Outbound -Priority 100 -SourceAddressPrefix * `
-SourcePortRange * -DestinationAddressPrefix * -DestinationPortRange *

$nsg = New-AzNetworkSecurityGroup `
-Name "$vnetName-$subnetName-nsg-allow-all" `
-ResourceGroupName $resourceGroupName `
-location $vnet.Location `
-SecurityRules $inboundAllowAllRule, $outboundAllowAllRule `
-Force

$subnet.NetworkSecurityGroup += $nsg

Set-AzVirtualNetwork -VirtualNetwork $vnet

$vnet = Get-AzVirtualNetwork -Name $vnetName -ResourceGroupName $resourceGroupName
}

return $vnet
}
Loading