[Network] Add Cmdlets for BYOIP Feature #12666

dexiang-ms · 2020-08-13T18:13:33Z

Description

This PR adds the code for the Powershell Cmdlets for the BYOIP feature and is in accordance with the following review PRs:

Initial proposal to add Master and CustomIpPrefix: https://github.com/Azure/azure-powershell-cmdlet-review-pr/issues/632
Update PublicIpPrefix: https://github.com/Azure/azure-powershell-cmdlet-review-pr/issues/670
Removal of MasterCustomIpPrefix: https://github.com/Azure/azure-powershell-cmdlet-review-pr/issues/696

Checklist

I have read the Submitting Changes section of CONTRIBUTING.md
The title of the PR is clear and informative
The appropriate ChangeLog.md file(s) has been updated:
- For any service, the ChangeLog.md file can be found at src/{{SERVICE}}/{{SERVICE}}/ChangeLog.md
- A snippet outlining the change(s) made in the PR should be written under the ## Upcoming Release header -- no new version header should be added
The PR does not introduce breaking changes
If applicable, the changes made in the PR have proper test coverage
For public API changes to cmdlets:
- a cmdlet design review was approved for the changes in this repository (Microsoft internal only)
- the markdown help files have been regenerated using the commands listed here

Az.storage preview (Do Not Squash)

[Storage] Support File Share accesstier and usage

* lb backend address pool create/update/delete operations * adding tests with draft * making some updates for design review PR to powershell team * adding .md files * -adding tests -updating help files -addressing feedback * pulling in sdk changes for network-may branch for validation errors * Addressing comments and updating output format for PsLoadBalancerBackendAddress * updating .md files and making final changes Co-authored-by: Ali Egal <alegal@microsoft.com>

…P2SVpnGateway and P2SClients (Azure#12006) * Adding new optional parameter to specify dns servers for Virtual Wan-P2SVpnGateway and P2SClients * Incorporate code review comments and added test record * Suppress warnings * Suppress cred scan errors

[Do Not Squash][Storage] Merge Master changes to storage preview branch

Co-authored-by: Ali Egal <alegal@microsoft.com>

upgrade Az.Storage to 2.1.1-preview

…ly (Azure#12076)

* Network SDK for 2020-05-01 * Fixes for FirewallPolicy * Recs * Recs * SDK package * Ignore Network API version in Batch tests * CredScan suppression

* commit1 * commit2 * Fix1 Co-authored-by: Khushboo Baheti <khbaheti@microsoft.com>

…or Multiple DNAT Rule Collections (Azure#12095) * Change RuleGroup and RuleCollectionGroup based on swagger change. Also, add support for NAT Rule Collections containing multiple NAT Rule Collections * PR Comments * Updated the SDK * StaticAnalysis * Previous changes got removed in rebase

* Use Network SDK from NuGet * Additional mappings

* ti whitelist changes * build fix * help files * added examples for help files * adding the online version * recordings done * changed to markdown files * fixed statis analysis * added exception for static analysis * addressing comments * updated recordings * new recordings

adxsdkps · 2020-08-13T18:13:42Z

Can one of the admins verify this patch?

src/Network/Network/ChangeLog.md

src/Network/Network/Properties/Resources.Designer.cs

src/Network/Network/PublicIpPrefix/NewAzurePublicIpPrefixCommand.cs

isra-fel · 2020-08-14T08:38:14Z

BTW I rembmer NRP used to have a seperate branch e.g. network-july for all the features to be merged to. Are you not following that practice any more?

dexiang-ms · 2020-08-14T17:50:16Z

BTW I rembmer NRP used to have a seperate branch e.g. network-july for all the features to be merged to. Are you not following that practice any more?

Oh you might be right, would you prefer that I re-do this PR onto that branch?

isra-fel · 2020-08-17T01:47:59Z

Oh you might be right, would you prefer that I re-do this PR onto that branch?

Cool. Simply click the "Edit" button and choose network-june as the base branch.
FYI - there are build issues. Please check the pipelines

dexiang-ms · 2020-08-17T16:43:07Z

Oh you might be right, would you prefer that I re-do this PR onto that branch?

Cool. Simply click the "Edit" button and choose network-june as the base branch.
FYI - there are build issues. Please check the pipelines

Also about the build issues, it seems like the build is failing because it cant find references to the SDK files. It seems like the SDK for Network has not been released yet, latest is still the May release (https://www.nuget.org/packages/Microsoft.Azure.Management.Network/). I'm assuming I have to wait until the Network team updates their SDK before I can merge this PR?

isra-fel · 2020-08-18T02:16:41Z

Also about the build issues, it seems like the build is failing because it cant find references to the SDK files. It seems like the SDK for Network has not been released yet, latest is still the May release (https://www.nuget.org/packages/Microsoft.Azure.Management.Network/). I'm assuming I have to wait until the Network team updates their SDK before I can merge this PR?

I think NRP has a practice of using local SDK package in network branch. @MikhailTryakhov could you point the instructions to @dexiang-ms ? Thanks

Besides, your branch was not created from Azure:network-june so changing the base branch causes too many commits in this PR. I suggest create a new one from Azure:network-june and cherry-pick your commits there. Then submit a new PR

dexiang-ms · 2020-08-18T17:17:47Z

Also about the build issues, it seems like the build is failing because it cant find references to the SDK files. It seems like the SDK for Network has not been released yet, latest is still the May release (https://www.nuget.org/packages/Microsoft.Azure.Management.Network/). I'm assuming I have to wait until the Network team updates their SDK before I can merge this PR?

I think NRP has a practice of using local SDK package in network branch. @MikhailTryakhov could you point the instructions to @dexiang-ms ? Thanks

Besides, your branch was not created from Azure:network-june so changing the base branch causes too many commits in this PR. I suggest create a new one from Azure:network-june and cherry-pick your commits there. Then submit a new PR

I think the local SDK practice is only for local development, but these merge validation checks are using the published SDK. Waiting on @MikhailTryakhov to update us on the progress of the SDK.

dexiang-ms · 2020-08-19T20:04:22Z

Re-created PR: https://github.com/Azure/azure-powershell/pull/12704/files

VeryEarly and others added 30 commits May 21, 2020 16:11

merge from master

df72db5

suppress breaking change issues

4258738

bump up version for Az.Storage

992f77f

Merge pull request Azure#11967 from VeryEarly/Az.Storage-Preview2

ca06a5f

Az.storage preview (Do Not Squash)

[Storage] Support share usage

14db8a9

[Storage] Support share Accesstier

20a4761

Merge pull request Azure#12013 from wastoresh/sharetier

06f5d6b

[Storage] Support File Share accesstier and usage

fix merge conflicts

415bcbb

Merge pull request Azure#12043 from wastoresh/mergestorage

0250bd1

[Do Not Squash][Storage] Merge Master changes to storage preview branch

upgrade Az.Storage to 2.1.1-preview

99a484a

updating help files examples (Azure#12068)

b242a55

Co-authored-by: Ali Egal <alegal@microsoft.com>

Merge pull request Azure#12053 from VeryEarly/Az.Storage-preview

42ab0c3

upgrade Az.Storage to 2.1.1-preview

Do not pass new fields with default values unless configured explicit…

b7c50ca

…ly (Azure#12076)

Used signed Network SDK with API version 2020-05-01 (Azure#12100)

6a9de29

* Network SDK for 2020-05-01 * Fixes for FirewallPolicy * Recs * Recs * SDK package * Ignore Network API version in Batch tests * CredScan suppression

Vpn gateway commandlet update (Azure#12108)

b31b6a7

* commit1 * commit2 * Fix1 Co-authored-by: Khushboo Baheti <khbaheti@microsoft.com>

Use Network SDK from NuGet (Azure#12114)

5248182

* Use Network SDK from NuGet * Additional mappings

nic renaming changes for TFO/FO

62edd98

add BYOIP models

4bd43ec

started the master custom ip prefix cmdlets

fe38099

added nicRenaming parameters to NicConfig Cmdlet

70eb940

updated help file

59e366e

added example in help file and updated changeLog

dba3b30

added UT

e06ecac

undid typo added by mistake

557b315

finished MasterCustomIpPrefix cmdlets

4b7e5d3

add customIpPrefix cmdlets

18ca1a0

dexiang-ms requested review from MS-syh2qs, Sandido, dkulkarni-ms, grizzlytheodore, haagha and madewithsmiles as code owners August 13, 2020 18:13

dexiang-ms added 3 commits August 13, 2020 13:20

merge from master and fix conflicts

c4fb857

accidentally deleted publicIpPrefix changes, reinstated

711c7ec

change tabs to spaces

569e49c

isra-fel self-assigned this Aug 14, 2020

isra-fel added the needs-review label Aug 14, 2020

isra-fel requested changes Aug 14, 2020

View reviewed changes

src/Network/Network/ChangeLog.md Outdated Show resolved Hide resolved

src/Network/Network/Properties/Resources.Designer.cs Show resolved Hide resolved

src/Network/Network/PublicIpPrefix/NewAzurePublicIpPrefixCommand.cs Show resolved Hide resolved

isra-fel assigned dexiang-ms Aug 14, 2020

isra-fel added needs-revision and removed needs-review labels Aug 14, 2020

azuresdkci added the needs-review label Aug 14, 2020

fixes per review comments

a95772e

isra-fel removed the needs-review label Aug 17, 2020

dexiang-ms changed the base branch from master to network-june August 17, 2020 17:25

Merge branch 'network-june' into byoip

06755d0

dexiang-ms closed this Aug 19, 2020

dexiang-ms mentioned this pull request Aug 20, 2020

[Network] Add Cmdlets for BYOIP Feature #12704

Merged

8 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

[Network] Add Cmdlets for BYOIP Feature #12666

[Network] Add Cmdlets for BYOIP Feature #12666

Uh oh!

dexiang-ms commented Aug 13, 2020

Uh oh!

adxsdkps commented Aug 13, 2020

Uh oh!

Uh oh!

Uh oh!

Uh oh!

isra-fel commented Aug 14, 2020 •

edited

Loading

Uh oh!

dexiang-ms commented Aug 14, 2020

Uh oh!

isra-fel commented Aug 17, 2020 •

edited

Loading

Uh oh!

dexiang-ms commented Aug 17, 2020 •

edited

Loading

Uh oh!

isra-fel commented Aug 18, 2020 •

edited

Loading

Uh oh!

dexiang-ms commented Aug 18, 2020

Uh oh!

dexiang-ms commented Aug 19, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

71 participants

[Network] Add Cmdlets for BYOIP Feature #12666

[Network] Add Cmdlets for BYOIP Feature #12666

Uh oh!

Conversation

dexiang-ms commented Aug 13, 2020

Description

Checklist

Uh oh!

adxsdkps commented Aug 13, 2020

Uh oh!

Uh oh!

Uh oh!

Uh oh!

isra-fel commented Aug 14, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

dexiang-ms commented Aug 14, 2020

Uh oh!

isra-fel commented Aug 17, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

dexiang-ms commented Aug 17, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

isra-fel commented Aug 18, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

dexiang-ms commented Aug 18, 2020

Uh oh!

dexiang-ms commented Aug 19, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

71 participants

isra-fel commented Aug 14, 2020 •

edited

Loading

isra-fel commented Aug 17, 2020 •

edited

Loading

dexiang-ms commented Aug 17, 2020 •

edited

Loading

isra-fel commented Aug 18, 2020 •

edited

Loading