Skip to content

Conversation

@Sandido
Copy link
Contributor

@Sandido Sandido commented Oct 14, 2020

Work for work item 8142427.

Description

Checklist

  • I have read the Submitting Changes section of CONTRIBUTING.md
  • The title of the PR is clear and informative
  • The appropriate ChangeLog.md file(s) has been updated:
    • For any service, the ChangeLog.md file can be found at src/{{SERVICE}}/{{SERVICE}}/ChangeLog.md
    • A snippet outlining the change(s) made in the PR should be written under the ## Upcoming Release header -- no new version header should be added
  • The PR does not introduce breaking changes
  • If applicable, the changes made in the PR have proper test coverage
  • For public API changes to cmdlets:
    • a cmdlet design review was approved for the changes in this repository (Microsoft internal only)
    • the markdown help files have been regenerated using the commands listed here

Copy link
Member

@haagha haagha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@Sandido Sandido marked this pull request as ready for review October 14, 2020 20:03
@Sandido Sandido merged commit 29f048c into cplat_diskRP Oct 14, 2020
wyunchi-ms pushed a commit that referenced this pull request Oct 16, 2020
* updating project version values to 39.0.0

* New-AzDiskConfig cmdlet with new parameters Tier and Sectorsize  (#13191)

* in progress commit. Still investigating

* dev and some testing and project version updates that are likely no longer needed

* diskconfig test

* changelog, help doc for new-azdiskconfig

* New-AzDiskUpdateConfig added parameters Tier, diskIOPSReadOnly, and diskMBpsReadOnly (#13218)

* dev work for New-AzDiskUpdateConfig

* New-AzDiskUpdateConfig test and New-AzDiskConfig changes for tests.
Help doc and changelog.

* recorded test file

* cleanup new-azdiskconfig for merge

* trying to undo new-azdiskconfig changes

* additional cleanup

* commit to re run CI tests

* removing unneeded update

* new cmdlet Get-AzDiskEncryptionSetAssociatedResource (#13212)

* update 1

* help doc, first draft test

* debugging test

* Final draft

* making cmd name not plural

name was plural in the header of the markdown file, seemed to cause CI failures on Generate Help.

* removing 'online version: ' from the top

see if it allows CI checks to pass.

* empty update to rerun ci checks 

ci rerun button is not working.

* Update Get-AzDiskEncryptionSetAssociatedResource.md

Co-authored-by: Adam Sandor <adsandor@microsoft.com>

* new-azdiskupdateconfig dev, test, changelog, help doc (#13232)

* removing extra logical sector size assignment

Co-authored-by: Theodore Chang <thchan@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants