New-AzDiskUpdateConfig new parameter MaxSharesCount #13232
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sandido
requested review from
MS-syh2qs,
bilaakpan-ms,
dkulkarni-ms,
grizzlytheodore,
haagha and
madewithsmiles
as code owners
wyunchi-ms
pushed a commit
that referenced
this pull request
Oct 16, 2020
* updating project version values to 39.0.0 * New-AzDiskConfig cmdlet with new parameters Tier and Sectorsize (#13191) * in progress commit. Still investigating * dev and some testing and project version updates that are likely no longer needed * diskconfig test * changelog, help doc for new-azdiskconfig * New-AzDiskUpdateConfig added parameters Tier, diskIOPSReadOnly, and diskMBpsReadOnly (#13218) * dev work for New-AzDiskUpdateConfig * New-AzDiskUpdateConfig test and New-AzDiskConfig changes for tests. Help doc and changelog. * recorded test file * cleanup new-azdiskconfig for merge * trying to undo new-azdiskconfig changes * additional cleanup * commit to re run CI tests * removing unneeded update * new cmdlet Get-AzDiskEncryptionSetAssociatedResource (#13212) * update 1 * help doc, first draft test * debugging test * Final draft * making cmd name not plural name was plural in the header of the markdown file, seemed to cause CI failures on Generate Help. * removing 'online version: ' from the top see if it allows CI checks to pass. * empty update to rerun ci checks ci rerun button is not working. * Update Get-AzDiskEncryptionSetAssociatedResource.md Co-authored-by: Adam Sandor <adsandor@microsoft.com> * new-azdiskupdateconfig dev, test, changelog, help doc (#13232) * removing extra logical sector size assignment Co-authored-by: Theodore Chang <thchan@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Checklist
CONTRIBUTING.mdChangeLog.mdfile(s) has been updated:ChangeLog.mdfile can be found atsrc/{{SERVICE}}/{{SERVICE}}/ChangeLog.md## Upcoming Releaseheader -- no new version header should be added