Skip to content

Conversation

@Sandido
Copy link
Contributor

@Sandido Sandido commented Oct 15, 2020

For work items:
https://msazure.visualstudio.com/One/_workitems/edit/8142427
https://msazure.visualstudio.com/One/_workitems/edit/8142424
https://msazure.visualstudio.com/One/_workitems/edit/8142422

This PR also updates the API versions in the project files.

Description

Checklist

  • I have read the Submitting Changes section of CONTRIBUTING.md
  • The title of the PR is clear and informative
  • The appropriate ChangeLog.md file(s) has been updated:
    • For any service, the ChangeLog.md file can be found at src/{{SERVICE}}/{{SERVICE}}/ChangeLog.md
    • A snippet outlining the change(s) made in the PR should be written under the ## Upcoming Release header -- no new version header should be added
  • The PR does not introduce breaking changes
  • If applicable, the changes made in the PR have proper test coverage
  • For public API changes to cmdlets:
    • a cmdlet design review was approved for the changes in this repository (Microsoft internal only)
    • the markdown help files have been regenerated using the commands listed here

Sandido and others added 6 commits October 9, 2020 15:02
* in progress commit. Still investigating

* dev and some testing and project version updates that are likely no longer needed

* diskconfig test

* changelog, help doc for new-azdiskconfig
…iskMBpsReadOnly (#13218)

* dev work for New-AzDiskUpdateConfig

* New-AzDiskUpdateConfig test and New-AzDiskConfig changes for tests.
Help doc and changelog.

* recorded test file

* cleanup new-azdiskconfig for merge

* trying to undo new-azdiskconfig changes

* additional cleanup

* commit to re run CI tests

* removing unneeded update
* update 1

* help doc, first draft test

* debugging test

* Final draft

* making cmd name not plural

name was plural in the header of the markdown file, seemed to cause CI failures on Generate Help.

* removing 'online version: ' from the top

see if it allows CI checks to pass.

* empty update to rerun ci checks 

ci rerun button is not working.

* Update Get-AzDiskEncryptionSetAssociatedResource.md

Co-authored-by: Adam Sandor <adsandor@microsoft.com>
@wyunchi-ms wyunchi-ms merged commit d54017c into master Oct 16, 2020
@grizzlytheodore grizzlytheodore deleted the cplat_diskRP branch March 22, 2021 21:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants