Update module definitions for common runtime #4734

cormacpayne · 2017-10-07T00:11:22Z

Description

Fix for issue #3972

This checklist is used to make sure that common guidelines for a pull request are followed. You can find a more complete discussion of PowerShell cmdlet best practices here.

I have read the contribution guidelines.
If changes were made to any cmdlet, the XML help was regenerated using the platyPSHelp module.
If any large changes are made to a service, they are reflected in the respective change log.

General Guidelines

Title of the pull request is clear and informative.
There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.
The pull request does not introduce breaking changes (unless a major version change occurs in the assembly and module).

Testing Guidelines

Pull request includes test coverage for the included changes.
PowerShell scripts used in tests should do any necessary setup as part of the test or suite setup, and should not use hard-coded values for locations or existing resources.

Cmdlet Signature Guidelines

New cmdlets that make changes or have side effects should implement ShouldProcess and have SupportShouldProcess=true specified in the cmdlet attribute. You can find more information on ShouldProcess here.
Cmdlet specifies OutputType attribute if any output is produced - if the cmdlet produces no output, it should implement a PassThru parameter.

Cmdlet Parameter Guidelines

Parameter types should not expose types from the management library - complex parameter types should be defined in the module.
Complex parameter types are discouraged - a parameter type should be simple types as often as possible. If complex types are used, they should be shallow and easily creatable from a constructor or another cmdlet.
Cmdlet parameter sets should be mutually exclusive - each parameter set must have at least one mandatory parameter not in other parameter sets.

cormacpayne · 2017-10-07T00:12:29Z

Packing job: http://azuresdkci.cloudapp.net/job/posh-pack/26/

cormacpayne · 2017-10-16T23:17:52Z

@azuresdkci test this please

markcowl · 2017-10-23T17:08:31Z

setup/azurecmdfiles.wxi

                        <Component Id="cmp18A4F358ED4D601BEBD0BB389140FE09" Guid="*">
                            <File Id="filDAD2F2CFF2BAC7646E21E7FE8545C982" KeyPath="yes" Source="$(var.sourceDir)\ResourceManager\AzureResourceManager\AzureRM.DataFactories\Microsoft.Azure.Management.DataFactories.dll" />
                        </Component>
-                        <Component Id="cmp43018C27AAE99DE2AACE593F0DA2D07A" Guid="*">


Why were these removed? The Microsoft.Data.* dlls are generally a dependencyof the WindowsAzure.Storage library, so references to them shoudl be independent, as it is for WIndosAzure.Storage

markcowl · 2017-10-23T17:12:55Z

src/ResourceManager/Automation/AzureRM.Automation.psd1


        # External dependent modules of this module
-        # ExternalModuleDependencies = ''
+        # ExternalModuleDependencies = 'AzureRM.Profile'


We should remove these, this should be added and removed by tools

markcowl · 2017-10-23T20:32:55Z

tools/CleanupBuild.ps1

+$resourcesFolders = @("de", "es", "fr", "it", "ja", "ko", "ru", "zh-Hans", "zh-Hant")
+Get-ChildItem -Include $resourcesFolders -Recurse -Force -Path $output | Remove-Item -Force -Recurse -ErrorAction SilentlyContinue
+
+Write-Verbose "Removing XML help files for helper dlls from $output"


Remove autogeenrated Xml help files, conde analysis, config files, and symbols

markcowl · 2017-10-23T20:34:30Z

tools/CleanupBuild.ps1

-Cleanup-MarkdownHelp -BuildConfig $BuildConfig
+    $acceptedDlls = $acceptedDlls | where { $_ -ne $null } | % { $_.Substring(2) }
+
+    Get-ChildItem -Path $RMFolder.FullName -Filter "*.dll" | where { $acceptedDlls -notcontains $_.Name} | Remove-Item -Force


It might be worthwhile to ensure we print out these files we are removing so we can debug any issues

markcowl · 2017-10-23T20:35:32Z

tools/PublishModules.ps1

+        }
+        else
+        {
+            $newModules += (@{ModuleName = $module["ModuleName"]; ModuleVersion= $module["ModuleVersion"]})


ensure that we have tested this

markcowl · 2017-10-23T20:53:36Z

tools/PublishModules.ps1

-        $nupkgPath = Join-Path -Path $TempRepoPath -ChildPath ($moduleName + "." + $manifest.Version.ToString() + ".nupkg")
+        $file = Get-Item $moduleSourcePath
+        Import-LocalizedData -BindingVariable ModuleMetadata -BaseDirectory $file.DirectoryName -FileName $file.Name
+        $nupkgPath = Join-Path -Path $TempRepoPath -ChildPath ($moduleName + "." + $ModuleMetadata.ModuleVersion.ToString() + ".nupkg")


Before we call PublishModule, we should add in 'ExternalModuleDependencies', and we should remove it before the final nuget package refactoring, liek here: https://github.com/markcowl/azure-powershell/blob/fixazs/tools/PublishModules.ps1#L283

…ne/azure-powershell into module-definition-psm1-spoof # Please enter a commit message to explain why this merge is necessary, # especially if it merges an updated upstream into a topic branch. # # Lines starting with '#' will be ignored, and an empty message aborts # the commit.

…ormacpayne/azure-powershell into module-definition-psm1-spoof" This reverts commit 4e6a420, reversing changes made to dd8ac94.

…dModules

…nto module-definition-psm1 # Conflicts: # src/ResourceManager/Compute/Commands.Compute/Generated/VirtualMachine/VirtualMachineRunCommandMethod.cs

cormacpayne · 2017-11-01T01:30:36Z

UPDATED

Packaging job: http://azuresdkci.cloudapp.net/job/posh-pack/94/
On-demand: https://azuresdkci.westus2.cloudapp.azure.com/job/powershell-demand/100/

…nto module-definition-psm1 # Conflicts: # setup/azurecmdfiles.wxi

markcowl · 2017-11-02T21:46:55Z

tools/UpdateModules.ps1

+        return "`$module = Get-Module $ModuleName `
+if (`$module -ne `$null -and `$module.Version.ToString().CompareTo(`"$MinimumVersion`") -lt 0) `
+{ `
+    Write-Warning `"A later version of $ModuleName was found to be imported already. Please see <link> for more details.`" `


Please change these strings:

This module requires $ModuleName version $ModuleVersion. An earlier version of $ModuleName is imported in the current PowerShell session. Please open a new session before importing this module. This error could indicate that multiple incompatible versions of the Azure PowerShell cmdlets are installed on your system. Please see https://aka.ms/azps-version-error for troubleshooting information.

…owershell into module-definition-psm1 # Conflicts: # src/ResourceManager/ContainerInstance/AzureRM.ContainerInstance.psd1 # tools/AzureRM.Example.psm1

…hell into module-definition-psm1

cormacpayne · 2017-11-03T06:28:58Z

Closing in favor of #4921

cormacpayne mentioned this pull request Oct 7, 2017

Update module definitions for common runtime #4713

Closed

13 tasks

azuresdkci added the needs-review label Oct 7, 2017

azuresdkci assigned markcowl Oct 7, 2017

cormacpayne mentioned this pull request Oct 16, 2017

Clean up module package files in post-build script #3971

Closed

Update module definitions to prepare for preview modules

639874a

cormacpayne force-pushed the module-definition-psm1 branch from d1e7dc2 to 639874a Compare October 18, 2017 00:14

cormacpayne added 4 commits October 17, 2017 17:21

Comment out ExternalModuleDependencies

50de284

Fix issues in newly added modules

2d91405

Update module scripts to fix install scenarios

2e32ee0

Mock version updates for Compute and Profile, update AzureRM

e6a07b4

markcowl requested changes Oct 23, 2017

View reviewed changes

markcowl added needs-revision and removed needs-review labels Oct 23, 2017

markcowl assigned cormacpayne and unassigned markcowl Oct 23, 2017

cormacpayne added 11 commits October 25, 2017 15:51

Removing ExternalModuleDependencies

6584cce

Resolve review feedback

2ae5d0f

Fix typo

dd8ac94

Skip updating external dependencies for modules with no required modules

8956576

Revert "Merge branch 'module-definition-psm1' of https://github.com/c…

e5fcf37

…ormacpayne/azure-powershell into module-definition-psm1-spoof" This reverts commit 4e6a420, reversing changes made to dd8ac94.

Fix error with accessing null RequiredModules property

f5de9d0

Remove external module work

955b33a

Remove NestedModules during build, reformat psm1 file to import Neste…

b13681d

…dModules

Merge branch 'preview' of https://github.com/Azure/azure-powershell i…

61a062c

…nto module-definition-psm1 # Conflicts: # src/ResourceManager/Compute/Commands.Compute/Generated/VirtualMachine/VirtualMachineRunCommandMethod.cs

Fix typo

08081d4

cormacpayne added 2 commits October 31, 2017 22:38

Fix error in release build

8d369b6

Fix error with multiple nested modules

2759c5d

maddieclayton mentioned this pull request Nov 2, 2017

Add ResourceGroup to DefaultParameterValues #4911

Merged

13 tasks

cormacpayne added 2 commits November 1, 2017 23:04

Merge branch 'preview' of https://github.com/Azure/azure-powershell i…

96346c0

…nto module-definition-psm1 # Conflicts: # setup/azurecmdfiles.wxi

Update ApplicationInsights and generate wxi file

2717c1a

markcowl requested changes Nov 2, 2017

View reviewed changes

Merge branch 'fix-encoding' of https://github.com/cormacpayne/azure-p…

10e03ed

…owershell into module-definition-psm1 # Conflicts: # src/ResourceManager/ContainerInstance/AzureRM.ContainerInstance.psd1 # tools/AzureRM.Example.psm1

markcowl changed the base branch from preview to release-5.0.0 November 2, 2017 23:23

cormacpayne added 2 commits November 2, 2017 18:23

Update error description

4dd4a32

Merge branch 'release-5.0.0' of https://github.com/Azure/azure-powers…

724bca1

…hell into module-definition-psm1

cormacpayne closed this Nov 3, 2017

cormacpayne deleted the module-definition-psm1 branch May 2, 2018 23:53

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Update module definitions for common runtime #4734

Update module definitions for common runtime #4734

Uh oh!

cormacpayne commented Oct 7, 2017 •

edited

Loading

Uh oh!

cormacpayne commented Oct 7, 2017

Uh oh!

cormacpayne commented Oct 16, 2017

Uh oh!

markcowl Oct 23, 2017

Uh oh!

markcowl Oct 23, 2017

Uh oh!

markcowl Oct 23, 2017

Uh oh!

markcowl Oct 23, 2017

Uh oh!

markcowl Oct 23, 2017

Uh oh!

markcowl Oct 23, 2017

Uh oh!

cormacpayne commented Nov 1, 2017 •

edited

Loading

Uh oh!

markcowl Nov 2, 2017

Uh oh!

cormacpayne commented Nov 3, 2017

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Update module definitions for common runtime #4734

Update module definitions for common runtime #4734

Uh oh!

Conversation

cormacpayne commented Oct 7, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Uh oh!

cormacpayne commented Oct 7, 2017

Uh oh!

cormacpayne commented Oct 16, 2017

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

cormacpayne commented Nov 1, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

cormacpayne commented Nov 3, 2017

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

cormacpayne commented Oct 7, 2017 •

edited

Loading

cormacpayne commented Nov 1, 2017 •

edited

Loading