Website convenience cmdlets #5585
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sergey-shandar
suggested changes
Feb 20, 2018
| var percent = (int)(progress * 100.0); | ||
| var r = new[] { "|", "/", "-", "\\" }; | ||
| var x = r[DateTime.Now.Second % 4]; | ||
| WriteProgressAsync( |
Contributor
There was a problem hiding this comment.
this implementation may have a bug in progress bar. Here's a fix for it https://github.com/Azure/azure-powershell/pull/5487/files
| { | ||
| get | ||
| { | ||
| return "To connect your website with a git repository, you must have the git executable installed. Please download and install git from https://git-scm.com/"; |
Contributor
There was a problem hiding this comment.
Should it be a resource string?
|
|
||
| ConcurrentQueue<ShouldContinuePrompt> _continue = new ConcurrentQueue<ShouldContinuePrompt>(); | ||
|
|
||
| ConcurrentQueue<ProgressRecord> _progress = new ConcurrentQueue<ProgressRecord>(); |
Contributor
There was a problem hiding this comment.
nit: we may have only one queue of actions instead of several data queues.
sergey-shandar
previously approved these changes
Mar 5, 2018
Member
Author
maddieclayton
approved these changes
Mar 5, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Checklist
CONTRIBUTING.mdplatyPSmodule