Improve synchronization of fields#68
Merged
Merged
Conversation
dlstucki
reviewed
Mar 24, 2020
| */ | ||
| static final class ControlConnection implements AutoCloseable { | ||
| final class ControlConnection implements AutoCloseable { | ||
| private final HybridConnectionListener listener; |
Contributor
There was a problem hiding this comment.
private final HybridConnectionListener listener; [](start = 2, length = 48)
It's a minor point and might introduce unnecessary churn but once this class is no longer static you no longer need to explicitly pass in the "listener" reference, right? #WontFix
Contributor
Author
There was a problem hiding this comment.
In that case the "listener" reference would have to be referred to as "HybridConnectionListener.this", I personally feel like it's more readable as it is currently.
In reply to: 397338730 [](ancestors = 397338730)
bainian12345
added a commit
that referenced
this pull request
Jan 20, 2022
* improve synchronization of fields (#68) Co-authored-by: bailiu <bailiu@microsoft.com> * make status description for HTTP response be JSON safe (#69) * make status description for HTTP response be JSON safe * assert response description Co-authored-by: bailiu <bailiu@microsoft.com> * allow empty URI query param (#67) Co-authored-by: bailiu <bailiu@microsoft.com> * Add new API to allow authentication with Azure Identity (#76) * cleanup unnecessary pom configurations * Enable authentication using Azure Identity * add copyright headers Co-authored-by: bailiu <bailiu@microsoft.com> * Updating dependency according to github issues (#77) Co-authored-by: bailiu <bailiu@microsoft.com> * update version to 0.0.4 (#78) Co-authored-by: bailiu <bailiu@microsoft.com> Co-authored-by: bailiu <bailiu@microsoft.com>
jbjordan
added a commit
that referenced
this pull request
May 21, 2026
* improve synchronization of fields (#68) Co-authored-by: bailiu <bailiu@microsoft.com> * make status description for HTTP response be JSON safe (#69) * make status description for HTTP response be JSON safe * assert response description Co-authored-by: bailiu <bailiu@microsoft.com> * allow empty URI query param (#67) Co-authored-by: bailiu <bailiu@microsoft.com> * Add new API to allow authentication with Azure Identity (#76) * cleanup unnecessary pom configurations * Enable authentication using Azure Identity * add copyright headers Co-authored-by: bailiu <bailiu@microsoft.com> * Updating dependency according to github issues (#77) Co-authored-by: bailiu <bailiu@microsoft.com> * update version to 0.0.4 (#78) Co-authored-by: bailiu <bailiu@microsoft.com> * Enables text send and read operations for WebSocket connections. (#81) * text write/read support for websockets * uri encode request path * Merge state Add more commits by pushing to the fix/write-read-text branch on giventocode/azure-relay-java.Revert "uri encode request path" This reverts commit ee855e0. Review required At least 1 approving review is required by reviewers with write access. # Please enter the commit message for your changes. Lines starting All checks have passed# with '#' will be ignored, and an empty message aborts the commit. 1 successful check# @microsoft-cla# On branch fix/write-read-text license/cla — All CLA requirements met.# Your branch is up to date with 'origin/fix/write-read-text'. Required# Details# Changes to be committed: Merging is blocked# modified: src/main/java/com/microsoft/azure/relay/HybridHttpConnection.java Merging can be performed automatically with 1 approving review.# modified: src/test/java/com/microsoft/azure/relay/HybridConnectionListenerTest.java @giventocode# # # Leave a comment No file chosen Attach files by dragging & dropping, selecting or pasting them. Remember, contributions to this repository should follow its code of conduct. ProTip! Add .patch or .diff to the end of URLs for Git’s plaintext views. Reviewers No reviews Still in progress? Assignees No one assigned Labels None yet * added large message test, pr feedback * import fixes, and nit * import fix * Hybrid HTTP connection handles URL requests with spaces. (#83) * encode requests url paths * PR feedback Co-authored-by: Bainian Liu <bainian12345@hotmail.com> * .env, logging, and updated dependencies (#88) * Replace JSR-356 WebSocket implementation with Jetty (#89) * .env, logging, and updated dependencies * replace javax.websockets with jetty websockets * Implement keep-alive via WebSocket Ping (#91) * .env, logging, and updated dependencies * replace javax.websockets with jetty websockets * implement ping * update interval and fix spacing * fix whitespace * formatting * make ping interval configurable and add test --------- Co-authored-by: Bainian Liu <bainian12345@hotmail.com> Co-authored-by: bailiu <bailiu@microsoft.com> Co-authored-by: Jesus Aguilar <3589801+giventocode@users.noreply.github.com> Co-authored-by: Todd Venhaus <tvenhaus@gmail.com>
jbjordan
added a commit
that referenced
this pull request
May 21, 2026
* improve synchronization of fields (#68) Co-authored-by: bailiu <bailiu@microsoft.com> * make status description for HTTP response be JSON safe (#69) * make status description for HTTP response be JSON safe * assert response description Co-authored-by: bailiu <bailiu@microsoft.com> * allow empty URI query param (#67) Co-authored-by: bailiu <bailiu@microsoft.com> * Add new API to allow authentication with Azure Identity (#76) * cleanup unnecessary pom configurations * Enable authentication using Azure Identity * add copyright headers Co-authored-by: bailiu <bailiu@microsoft.com> * Updating dependency according to github issues (#77) Co-authored-by: bailiu <bailiu@microsoft.com> * update version to 0.0.4 (#78) Co-authored-by: bailiu <bailiu@microsoft.com> * Enables text send and read operations for WebSocket connections. (#81) * text write/read support for websockets * uri encode request path * Merge state Add more commits by pushing to the fix/write-read-text branch on giventocode/azure-relay-java.Revert "uri encode request path" This reverts commit ee855e0. Review required At least 1 approving review is required by reviewers with write access. # Please enter the commit message for your changes. Lines starting All checks have passed# with '#' will be ignored, and an empty message aborts the commit. 1 successful check# @microsoft-cla# On branch fix/write-read-text license/cla — All CLA requirements met.# Your branch is up to date with 'origin/fix/write-read-text'. Required# Details# Changes to be committed: Merging is blocked# modified: src/main/java/com/microsoft/azure/relay/HybridHttpConnection.java Merging can be performed automatically with 1 approving review.# modified: src/test/java/com/microsoft/azure/relay/HybridConnectionListenerTest.java @giventocode# # # Leave a comment No file chosen Attach files by dragging & dropping, selecting or pasting them. Remember, contributions to this repository should follow its code of conduct. ProTip! Add .patch or .diff to the end of URLs for Git’s plaintext views. Reviewers No reviews Still in progress? Assignees No one assigned Labels None yet * added large message test, pr feedback * import fixes, and nit * import fix * Hybrid HTTP connection handles URL requests with spaces. (#83) * encode requests url paths * PR feedback Co-authored-by: Bainian Liu <bainian12345@hotmail.com> * .env, logging, and updated dependencies (#88) * Replace JSR-356 WebSocket implementation with Jetty (#89) * .env, logging, and updated dependencies * replace javax.websockets with jetty websockets * Implement keep-alive via WebSocket Ping (#91) * .env, logging, and updated dependencies * replace javax.websockets with jetty websockets * implement ping * update interval and fix spacing * fix whitespace * formatting * make ping interval configurable and add test --------- Co-authored-by: Bainian Liu <bainian12345@hotmail.com> Co-authored-by: bailiu <bailiu@microsoft.com> Co-authored-by: Jesus Aguilar <3589801+giventocode@users.noreply.github.com> Co-authored-by: Todd Venhaus <tvenhaus@gmail.com>
jbjordan
added a commit
that referenced
this pull request
May 21, 2026
* Merge dev branch into master for version 0.0.4 (#79) * improve synchronization of fields (#68) Co-authored-by: bailiu <bailiu@microsoft.com> * make status description for HTTP response be JSON safe (#69) * make status description for HTTP response be JSON safe * assert response description Co-authored-by: bailiu <bailiu@microsoft.com> * allow empty URI query param (#67) Co-authored-by: bailiu <bailiu@microsoft.com> * Add new API to allow authentication with Azure Identity (#76) * cleanup unnecessary pom configurations * Enable authentication using Azure Identity * add copyright headers Co-authored-by: bailiu <bailiu@microsoft.com> * Updating dependency according to github issues (#77) Co-authored-by: bailiu <bailiu@microsoft.com> * update version to 0.0.4 (#78) Co-authored-by: bailiu <bailiu@microsoft.com> Co-authored-by: bailiu <bailiu@microsoft.com> * Enables text send and read operations for WebSocket connections. (#81) * text write/read support for websockets * uri encode request path * Merge state Add more commits by pushing to the fix/write-read-text branch on giventocode/azure-relay-java.Revert "uri encode request path" This reverts commit ee855e0. Review required At least 1 approving review is required by reviewers with write access. # Please enter the commit message for your changes. Lines starting All checks have passed# with '#' will be ignored, and an empty message aborts the commit. 1 successful check# @microsoft-cla# On branch fix/write-read-text license/cla — All CLA requirements met.# Your branch is up to date with 'origin/fix/write-read-text'. Required# Details# Changes to be committed: Merging is blocked# modified: src/main/java/com/microsoft/azure/relay/HybridHttpConnection.java Merging can be performed automatically with 1 approving review.# modified: src/test/java/com/microsoft/azure/relay/HybridConnectionListenerTest.java @giventocode# # # Leave a comment No file chosen Attach files by dragging & dropping, selecting or pasting them. Remember, contributions to this repository should follow its code of conduct. ProTip! Add .patch or .diff to the end of URLs for Git’s plaintext views. Reviewers No reviews Still in progress? Assignees No one assigned Labels None yet * added large message test, pr feedback * import fixes, and nit * import fix * Hybrid HTTP connection handles URL requests with spaces. (#83) * encode requests url paths * PR feedback Co-authored-by: Bainian Liu <bainian12345@hotmail.com> * Version Update (#90) Removed Javadoc throws comment and updated version in pom.xml * Microsoft mandatory file (#85) Co-authored-by: microsoft-github-policy-service[bot] <77245923+microsoft-github-policy-service[bot]@users.noreply.github.com> Co-authored-by: Jacob <108886350+jbjordan@users.noreply.github.com> * Bump json from 20180813 to 20230227 (#92) Bumps [json](https://github.com/douglascrockford/JSON-java) from 20180813 to 20230227. - [Release notes](https://github.com/douglascrockford/JSON-java/releases) - [Changelog](https://github.com/stleary/JSON-java/blob/master/docs/RELEASES.md) - [Commits](https://github.com/douglascrockford/JSON-java/commits) --- updated-dependencies: - dependency-name: org.json:json dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Jacob <108886350+jbjordan@users.noreply.github.com> * Update pom.xml to version 0.0.6 (#93) * Bump org.json:json from 20230227 to 20231013 (#94) Bumps [org.json:json](https://github.com/douglascrockford/JSON-java) from 20230227 to 20231013. - [Release notes](https://github.com/douglascrockford/JSON-java/releases) - [Changelog](https://github.com/stleary/JSON-java/blob/master/docs/RELEASES.md) - [Commits](https://github.com/douglascrockford/JSON-java/commits) --- updated-dependencies: - dependency-name: org.json:json dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump com.azure:azure-identity from 1.4.0 to 1.12.2 (#95) Bumps [com.azure:azure-identity](https://github.com/Azure/azure-sdk-for-java) from 1.4.0 to 1.12.2. - [Release notes](https://github.com/Azure/azure-sdk-for-java/releases) - [Commits](Azure/azure-sdk-for-java@azure-json_1.4.0...azure-identity_1.12.2) --- updated-dependencies: - dependency-name: com.azure:azure-identity dependency-version: 1.12.2 dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Update Util (#96) * Merge dev into master and resolve conflicts (#97) Agent-Logs-Url: https://github.com/Azure/azure-relay-java/sessions/570c7374-cd9f-48c1-a806-3192052d742e Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: jbjordan <108886350+jbjordan@users.noreply.github.com> * Revert "Merge dev into master and resolve conflicts (#97)" (#98) This reverts commit bc10c8c. * merge dev into main (#100) * improve synchronization of fields (#68) Co-authored-by: bailiu <bailiu@microsoft.com> * make status description for HTTP response be JSON safe (#69) * make status description for HTTP response be JSON safe * assert response description Co-authored-by: bailiu <bailiu@microsoft.com> * allow empty URI query param (#67) Co-authored-by: bailiu <bailiu@microsoft.com> * Add new API to allow authentication with Azure Identity (#76) * cleanup unnecessary pom configurations * Enable authentication using Azure Identity * add copyright headers Co-authored-by: bailiu <bailiu@microsoft.com> * Updating dependency according to github issues (#77) Co-authored-by: bailiu <bailiu@microsoft.com> * update version to 0.0.4 (#78) Co-authored-by: bailiu <bailiu@microsoft.com> * Enables text send and read operations for WebSocket connections. (#81) * text write/read support for websockets * uri encode request path * Merge state Add more commits by pushing to the fix/write-read-text branch on giventocode/azure-relay-java.Revert "uri encode request path" This reverts commit ee855e0. Review required At least 1 approving review is required by reviewers with write access. # Please enter the commit message for your changes. Lines starting All checks have passed# with '#' will be ignored, and an empty message aborts the commit. 1 successful check# @microsoft-cla# On branch fix/write-read-text license/cla — All CLA requirements met.# Your branch is up to date with 'origin/fix/write-read-text'. Required# Details# Changes to be committed: Merging is blocked# modified: src/main/java/com/microsoft/azure/relay/HybridHttpConnection.java Merging can be performed automatically with 1 approving review.# modified: src/test/java/com/microsoft/azure/relay/HybridConnectionListenerTest.java @giventocode# # # Leave a comment No file chosen Attach files by dragging & dropping, selecting or pasting them. Remember, contributions to this repository should follow its code of conduct. ProTip! Add .patch or .diff to the end of URLs for Git’s plaintext views. Reviewers No reviews Still in progress? Assignees No one assigned Labels None yet * added large message test, pr feedback * import fixes, and nit * import fix * Hybrid HTTP connection handles URL requests with spaces. (#83) * encode requests url paths * PR feedback Co-authored-by: Bainian Liu <bainian12345@hotmail.com> * .env, logging, and updated dependencies (#88) * Replace JSR-356 WebSocket implementation with Jetty (#89) * .env, logging, and updated dependencies * replace javax.websockets with jetty websockets * Implement keep-alive via WebSocket Ping (#91) * .env, logging, and updated dependencies * replace javax.websockets with jetty websockets * implement ping * update interval and fix spacing * fix whitespace * formatting * make ping interval configurable and add test --------- Co-authored-by: Bainian Liu <bainian12345@hotmail.com> Co-authored-by: bailiu <bailiu@microsoft.com> Co-authored-by: Jesus Aguilar <3589801+giventocode@users.noreply.github.com> Co-authored-by: Todd Venhaus <tvenhaus@gmail.com> --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: Bainian Liu <bainian12345@hotmail.com> Co-authored-by: bailiu <bailiu@microsoft.com> Co-authored-by: Jesus Aguilar <3589801+giventocode@users.noreply.github.com> Co-authored-by: microsoft-github-policy-service[bot] <77245923+microsoft-github-policy-service[bot]@users.noreply.github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Copilot <198982749+Copilot@users.noreply.github.com> Co-authored-by: Todd Venhaus <tvenhaus@gmail.com>
jbjordan
added a commit
that referenced
this pull request
May 21, 2026
* improve synchronization of fields (#68) Co-authored-by: bailiu <bailiu@microsoft.com> * make status description for HTTP response be JSON safe (#69) * make status description for HTTP response be JSON safe * assert response description Co-authored-by: bailiu <bailiu@microsoft.com> * allow empty URI query param (#67) Co-authored-by: bailiu <bailiu@microsoft.com> * Add new API to allow authentication with Azure Identity (#76) * cleanup unnecessary pom configurations * Enable authentication using Azure Identity * add copyright headers Co-authored-by: bailiu <bailiu@microsoft.com> * Updating dependency according to github issues (#77) Co-authored-by: bailiu <bailiu@microsoft.com> * update version to 0.0.4 (#78) Co-authored-by: bailiu <bailiu@microsoft.com> * Enables text send and read operations for WebSocket connections. (#81) * text write/read support for websockets * uri encode request path * Merge state Add more commits by pushing to the fix/write-read-text branch on giventocode/azure-relay-java.Revert "uri encode request path" This reverts commit ee855e0. Review required At least 1 approving review is required by reviewers with write access. # Please enter the commit message for your changes. Lines starting All checks have passed# with '#' will be ignored, and an empty message aborts the commit. 1 successful check# @microsoft-cla# On branch fix/write-read-text license/cla — All CLA requirements met.# Your branch is up to date with 'origin/fix/write-read-text'. Required# Details# Changes to be committed: Merging is blocked# modified: src/main/java/com/microsoft/azure/relay/HybridHttpConnection.java Merging can be performed automatically with 1 approving review.# modified: src/test/java/com/microsoft/azure/relay/HybridConnectionListenerTest.java @giventocode# # # Leave a comment No file chosen Attach files by dragging & dropping, selecting or pasting them. Remember, contributions to this repository should follow its code of conduct. ProTip! Add .patch or .diff to the end of URLs for Git’s plaintext views. Reviewers No reviews Still in progress? Assignees No one assigned Labels None yet * added large message test, pr feedback * import fixes, and nit * import fix * Hybrid HTTP connection handles URL requests with spaces. (#83) * encode requests url paths * PR feedback Co-authored-by: Bainian Liu <bainian12345@hotmail.com> * .env, logging, and updated dependencies (#88) * Replace JSR-356 WebSocket implementation with Jetty (#89) * .env, logging, and updated dependencies * replace javax.websockets with jetty websockets * Implement keep-alive via WebSocket Ping (#91) * .env, logging, and updated dependencies * replace javax.websockets with jetty websockets * implement ping * update interval and fix spacing * fix whitespace * formatting * make ping interval configurable and add test * Rebase dev (#104) * Merge dev branch into master for version 0.0.4 (#79) * improve synchronization of fields (#68) Co-authored-by: bailiu <bailiu@microsoft.com> * make status description for HTTP response be JSON safe (#69) * make status description for HTTP response be JSON safe * assert response description Co-authored-by: bailiu <bailiu@microsoft.com> * allow empty URI query param (#67) Co-authored-by: bailiu <bailiu@microsoft.com> * Add new API to allow authentication with Azure Identity (#76) * cleanup unnecessary pom configurations * Enable authentication using Azure Identity * add copyright headers Co-authored-by: bailiu <bailiu@microsoft.com> * Updating dependency according to github issues (#77) Co-authored-by: bailiu <bailiu@microsoft.com> * update version to 0.0.4 (#78) Co-authored-by: bailiu <bailiu@microsoft.com> Co-authored-by: bailiu <bailiu@microsoft.com> * Enables text send and read operations for WebSocket connections. (#81) * text write/read support for websockets * uri encode request path * Merge state Add more commits by pushing to the fix/write-read-text branch on giventocode/azure-relay-java.Revert "uri encode request path" This reverts commit ee855e0. Review required At least 1 approving review is required by reviewers with write access. # Please enter the commit message for your changes. Lines starting All checks have passed# with '#' will be ignored, and an empty message aborts the commit. 1 successful check# @microsoft-cla# On branch fix/write-read-text license/cla — All CLA requirements met.# Your branch is up to date with 'origin/fix/write-read-text'. Required# Details# Changes to be committed: Merging is blocked# modified: src/main/java/com/microsoft/azure/relay/HybridHttpConnection.java Merging can be performed automatically with 1 approving review.# modified: src/test/java/com/microsoft/azure/relay/HybridConnectionListenerTest.java @giventocode# # # Leave a comment No file chosen Attach files by dragging & dropping, selecting or pasting them. Remember, contributions to this repository should follow its code of conduct. ProTip! Add .patch or .diff to the end of URLs for Git’s plaintext views. Reviewers No reviews Still in progress? Assignees No one assigned Labels None yet * added large message test, pr feedback * import fixes, and nit * import fix * Hybrid HTTP connection handles URL requests with spaces. (#83) * encode requests url paths * PR feedback Co-authored-by: Bainian Liu <bainian12345@hotmail.com> * Version Update (#90) Removed Javadoc throws comment and updated version in pom.xml * Microsoft mandatory file (#85) Co-authored-by: microsoft-github-policy-service[bot] <77245923+microsoft-github-policy-service[bot]@users.noreply.github.com> Co-authored-by: Jacob <108886350+jbjordan@users.noreply.github.com> * Bump json from 20180813 to 20230227 (#92) Bumps [json](https://github.com/douglascrockford/JSON-java) from 20180813 to 20230227. - [Release notes](https://github.com/douglascrockford/JSON-java/releases) - [Changelog](https://github.com/stleary/JSON-java/blob/master/docs/RELEASES.md) - [Commits](https://github.com/douglascrockford/JSON-java/commits) --- updated-dependencies: - dependency-name: org.json:json dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Jacob <108886350+jbjordan@users.noreply.github.com> * Update pom.xml to version 0.0.6 (#93) * Bump org.json:json from 20230227 to 20231013 (#94) Bumps [org.json:json](https://github.com/douglascrockford/JSON-java) from 20230227 to 20231013. - [Release notes](https://github.com/douglascrockford/JSON-java/releases) - [Changelog](https://github.com/stleary/JSON-java/blob/master/docs/RELEASES.md) - [Commits](https://github.com/douglascrockford/JSON-java/commits) --- updated-dependencies: - dependency-name: org.json:json dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump com.azure:azure-identity from 1.4.0 to 1.12.2 (#95) Bumps [com.azure:azure-identity](https://github.com/Azure/azure-sdk-for-java) from 1.4.0 to 1.12.2. - [Release notes](https://github.com/Azure/azure-sdk-for-java/releases) - [Commits](Azure/azure-sdk-for-java@azure-json_1.4.0...azure-identity_1.12.2) --- updated-dependencies: - dependency-name: com.azure:azure-identity dependency-version: 1.12.2 dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Update Util (#96) * Merge dev into master and resolve conflicts (#97) Agent-Logs-Url: https://github.com/Azure/azure-relay-java/sessions/570c7374-cd9f-48c1-a806-3192052d742e Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: jbjordan <108886350+jbjordan@users.noreply.github.com> * Revert "Merge dev into master and resolve conflicts (#97)" (#98) This reverts commit bc10c8c. * merge dev into main (#100) * improve synchronization of fields (#68) Co-authored-by: bailiu <bailiu@microsoft.com> * make status description for HTTP response be JSON safe (#69) * make status description for HTTP response be JSON safe * assert response description Co-authored-by: bailiu <bailiu@microsoft.com> * allow empty URI query param (#67) Co-authored-by: bailiu <bailiu@microsoft.com> * Add new API to allow authentication with Azure Identity (#76) * cleanup unnecessary pom configurations * Enable authentication using Azure Identity * add copyright headers Co-authored-by: bailiu <bailiu@microsoft.com> * Updating dependency according to github issues (#77) Co-authored-by: bailiu <bailiu@microsoft.com> * update version to 0.0.4 (#78) Co-authored-by: bailiu <bailiu@microsoft.com> * Enables text send and read operations for WebSocket connections. (#81) * text write/read support for websockets * uri encode request path * Merge state Add more commits by pushing to the fix/write-read-text branch on giventocode/azure-relay-java.Revert "uri encode request path" This reverts commit ee855e0. Review required At least 1 approving review is required by reviewers with write access. # Please enter the commit message for your changes. Lines starting All checks have passed# with '#' will be ignored, and an empty message aborts the commit. 1 successful check# @microsoft-cla# On branch fix/write-read-text license/cla — All CLA requirements met.# Your branch is up to date with 'origin/fix/write-read-text'. Required# Details# Changes to be committed: Merging is blocked# modified: src/main/java/com/microsoft/azure/relay/HybridHttpConnection.java Merging can be performed automatically with 1 approving review.# modified: src/test/java/com/microsoft/azure/relay/HybridConnectionListenerTest.java @giventocode# # # Leave a comment No file chosen Attach files by dragging & dropping, selecting or pasting them. Remember, contributions to this repository should follow its code of conduct. ProTip! Add .patch or .diff to the end of URLs for Git’s plaintext views. Reviewers No reviews Still in progress? Assignees No one assigned Labels None yet * added large message test, pr feedback * import fixes, and nit * import fix * Hybrid HTTP connection handles URL requests with spaces. (#83) * encode requests url paths * PR feedback Co-authored-by: Bainian Liu <bainian12345@hotmail.com> * .env, logging, and updated dependencies (#88) * Replace JSR-356 WebSocket implementation with Jetty (#89) * .env, logging, and updated dependencies * replace javax.websockets with jetty websockets * Implement keep-alive via WebSocket Ping (#91) * .env, logging, and updated dependencies * replace javax.websockets with jetty websockets * implement ping * update interval and fix spacing * fix whitespace * formatting * make ping interval configurable and add test --------- Co-authored-by: Bainian Liu <bainian12345@hotmail.com> Co-authored-by: bailiu <bailiu@microsoft.com> Co-authored-by: Jesus Aguilar <3589801+giventocode@users.noreply.github.com> Co-authored-by: Todd Venhaus <tvenhaus@gmail.com> --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: Bainian Liu <bainian12345@hotmail.com> Co-authored-by: bailiu <bailiu@microsoft.com> Co-authored-by: Jesus Aguilar <3589801+giventocode@users.noreply.github.com> Co-authored-by: microsoft-github-policy-service[bot] <77245923+microsoft-github-policy-service[bot]@users.noreply.github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Copilot <198982749+Copilot@users.noreply.github.com> Co-authored-by: Todd Venhaus <tvenhaus@gmail.com> --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: Bainian Liu <bainian12345@hotmail.com> Co-authored-by: bailiu <bailiu@microsoft.com> Co-authored-by: Jesus Aguilar <3589801+giventocode@users.noreply.github.com> Co-authored-by: Todd Venhaus <tvenhaus@gmail.com> Co-authored-by: microsoft-github-policy-service[bot] <77245923+microsoft-github-policy-service[bot]@users.noreply.github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Copilot <198982749+Copilot@users.noreply.github.com>
jbjordan
added a commit
that referenced
this pull request
May 21, 2026
* improve synchronization of fields (#68) Co-authored-by: bailiu <bailiu@microsoft.com> * make status description for HTTP response be JSON safe (#69) * make status description for HTTP response be JSON safe * assert response description Co-authored-by: bailiu <bailiu@microsoft.com> * allow empty URI query param (#67) Co-authored-by: bailiu <bailiu@microsoft.com> * Add new API to allow authentication with Azure Identity (#76) * cleanup unnecessary pom configurations * Enable authentication using Azure Identity * add copyright headers Co-authored-by: bailiu <bailiu@microsoft.com> * Updating dependency according to github issues (#77) Co-authored-by: bailiu <bailiu@microsoft.com> * update version to 0.0.4 (#78) Co-authored-by: bailiu <bailiu@microsoft.com> * Enables text send and read operations for WebSocket connections. (#81) * text write/read support for websockets * uri encode request path * Merge state Add more commits by pushing to the fix/write-read-text branch on giventocode/azure-relay-java.Revert "uri encode request path" This reverts commit ee855e0. Review required At least 1 approving review is required by reviewers with write access. # Please enter the commit message for your changes. Lines starting All checks have passed# with '#' will be ignored, and an empty message aborts the commit. 1 successful check# @microsoft-cla# On branch fix/write-read-text license/cla — All CLA requirements met.# Your branch is up to date with 'origin/fix/write-read-text'. Required# Details# Changes to be committed: Merging is blocked# modified: src/main/java/com/microsoft/azure/relay/HybridHttpConnection.java Merging can be performed automatically with 1 approving review.# modified: src/test/java/com/microsoft/azure/relay/HybridConnectionListenerTest.java @giventocode# # # Leave a comment No file chosen Attach files by dragging & dropping, selecting or pasting them. Remember, contributions to this repository should follow its code of conduct. ProTip! Add .patch or .diff to the end of URLs for Git’s plaintext views. Reviewers No reviews Still in progress? Assignees No one assigned Labels None yet * added large message test, pr feedback * import fixes, and nit * import fix * Hybrid HTTP connection handles URL requests with spaces. (#83) * encode requests url paths * PR feedback Co-authored-by: Bainian Liu <bainian12345@hotmail.com> * .env, logging, and updated dependencies (#88) * Replace JSR-356 WebSocket implementation with Jetty (#89) * .env, logging, and updated dependencies * replace javax.websockets with jetty websockets * Implement keep-alive via WebSocket Ping (#91) * .env, logging, and updated dependencies * replace javax.websockets with jetty websockets * implement ping * update interval and fix spacing * fix whitespace * formatting * make ping interval configurable and add test * Rebase dev (#104) * Merge dev branch into master for version 0.0.4 (#79) * improve synchronization of fields (#68) Co-authored-by: bailiu <bailiu@microsoft.com> * make status description for HTTP response be JSON safe (#69) * make status description for HTTP response be JSON safe * assert response description Co-authored-by: bailiu <bailiu@microsoft.com> * allow empty URI query param (#67) Co-authored-by: bailiu <bailiu@microsoft.com> * Add new API to allow authentication with Azure Identity (#76) * cleanup unnecessary pom configurations * Enable authentication using Azure Identity * add copyright headers Co-authored-by: bailiu <bailiu@microsoft.com> * Updating dependency according to github issues (#77) Co-authored-by: bailiu <bailiu@microsoft.com> * update version to 0.0.4 (#78) Co-authored-by: bailiu <bailiu@microsoft.com> Co-authored-by: bailiu <bailiu@microsoft.com> * Enables text send and read operations for WebSocket connections. (#81) * text write/read support for websockets * uri encode request path * Merge state Add more commits by pushing to the fix/write-read-text branch on giventocode/azure-relay-java.Revert "uri encode request path" This reverts commit ee855e0. Review required At least 1 approving review is required by reviewers with write access. # Please enter the commit message for your changes. Lines starting All checks have passed# with '#' will be ignored, and an empty message aborts the commit. 1 successful check# @microsoft-cla# On branch fix/write-read-text license/cla — All CLA requirements met.# Your branch is up to date with 'origin/fix/write-read-text'. Required# Details# Changes to be committed: Merging is blocked# modified: src/main/java/com/microsoft/azure/relay/HybridHttpConnection.java Merging can be performed automatically with 1 approving review.# modified: src/test/java/com/microsoft/azure/relay/HybridConnectionListenerTest.java @giventocode# # # Leave a comment No file chosen Attach files by dragging & dropping, selecting or pasting them. Remember, contributions to this repository should follow its code of conduct. ProTip! Add .patch or .diff to the end of URLs for Git’s plaintext views. Reviewers No reviews Still in progress? Assignees No one assigned Labels None yet * added large message test, pr feedback * import fixes, and nit * import fix * Hybrid HTTP connection handles URL requests with spaces. (#83) * encode requests url paths * PR feedback Co-authored-by: Bainian Liu <bainian12345@hotmail.com> * Version Update (#90) Removed Javadoc throws comment and updated version in pom.xml * Microsoft mandatory file (#85) Co-authored-by: microsoft-github-policy-service[bot] <77245923+microsoft-github-policy-service[bot]@users.noreply.github.com> Co-authored-by: Jacob <108886350+jbjordan@users.noreply.github.com> * Bump json from 20180813 to 20230227 (#92) Bumps [json](https://github.com/douglascrockford/JSON-java) from 20180813 to 20230227. - [Release notes](https://github.com/douglascrockford/JSON-java/releases) - [Changelog](https://github.com/stleary/JSON-java/blob/master/docs/RELEASES.md) - [Commits](https://github.com/douglascrockford/JSON-java/commits) --- updated-dependencies: - dependency-name: org.json:json dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Jacob <108886350+jbjordan@users.noreply.github.com> * Update pom.xml to version 0.0.6 (#93) * Bump org.json:json from 20230227 to 20231013 (#94) Bumps [org.json:json](https://github.com/douglascrockford/JSON-java) from 20230227 to 20231013. - [Release notes](https://github.com/douglascrockford/JSON-java/releases) - [Changelog](https://github.com/stleary/JSON-java/blob/master/docs/RELEASES.md) - [Commits](https://github.com/douglascrockford/JSON-java/commits) --- updated-dependencies: - dependency-name: org.json:json dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump com.azure:azure-identity from 1.4.0 to 1.12.2 (#95) Bumps [com.azure:azure-identity](https://github.com/Azure/azure-sdk-for-java) from 1.4.0 to 1.12.2. - [Release notes](https://github.com/Azure/azure-sdk-for-java/releases) - [Commits](Azure/azure-sdk-for-java@azure-json_1.4.0...azure-identity_1.12.2) --- updated-dependencies: - dependency-name: com.azure:azure-identity dependency-version: 1.12.2 dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Update Util (#96) * Merge dev into master and resolve conflicts (#97) Agent-Logs-Url: https://github.com/Azure/azure-relay-java/sessions/570c7374-cd9f-48c1-a806-3192052d742e Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: jbjordan <108886350+jbjordan@users.noreply.github.com> * Revert "Merge dev into master and resolve conflicts (#97)" (#98) This reverts commit bc10c8c. * merge dev into main (#100) * improve synchronization of fields (#68) Co-authored-by: bailiu <bailiu@microsoft.com> * make status description for HTTP response be JSON safe (#69) * make status description for HTTP response be JSON safe * assert response description Co-authored-by: bailiu <bailiu@microsoft.com> * allow empty URI query param (#67) Co-authored-by: bailiu <bailiu@microsoft.com> * Add new API to allow authentication with Azure Identity (#76) * cleanup unnecessary pom configurations * Enable authentication using Azure Identity * add copyright headers Co-authored-by: bailiu <bailiu@microsoft.com> * Updating dependency according to github issues (#77) Co-authored-by: bailiu <bailiu@microsoft.com> * update version to 0.0.4 (#78) Co-authored-by: bailiu <bailiu@microsoft.com> * Enables text send and read operations for WebSocket connections. (#81) * text write/read support for websockets * uri encode request path * Merge state Add more commits by pushing to the fix/write-read-text branch on giventocode/azure-relay-java.Revert "uri encode request path" This reverts commit ee855e0. Review required At least 1 approving review is required by reviewers with write access. # Please enter the commit message for your changes. Lines starting All checks have passed# with '#' will be ignored, and an empty message aborts the commit. 1 successful check# @microsoft-cla# On branch fix/write-read-text license/cla — All CLA requirements met.# Your branch is up to date with 'origin/fix/write-read-text'. Required# Details# Changes to be committed: Merging is blocked# modified: src/main/java/com/microsoft/azure/relay/HybridHttpConnection.java Merging can be performed automatically with 1 approving review.# modified: src/test/java/com/microsoft/azure/relay/HybridConnectionListenerTest.java @giventocode# # # Leave a comment No file chosen Attach files by dragging & dropping, selecting or pasting them. Remember, contributions to this repository should follow its code of conduct. ProTip! Add .patch or .diff to the end of URLs for Git’s plaintext views. Reviewers No reviews Still in progress? Assignees No one assigned Labels None yet * added large message test, pr feedback * import fixes, and nit * import fix * Hybrid HTTP connection handles URL requests with spaces. (#83) * encode requests url paths * PR feedback Co-authored-by: Bainian Liu <bainian12345@hotmail.com> * .env, logging, and updated dependencies (#88) * Replace JSR-356 WebSocket implementation with Jetty (#89) * .env, logging, and updated dependencies * replace javax.websockets with jetty websockets * Implement keep-alive via WebSocket Ping (#91) * .env, logging, and updated dependencies * replace javax.websockets with jetty websockets * implement ping * update interval and fix spacing * fix whitespace * formatting * make ping interval configurable and add test --------- Co-authored-by: Bainian Liu <bainian12345@hotmail.com> Co-authored-by: bailiu <bailiu@microsoft.com> Co-authored-by: Jesus Aguilar <3589801+giventocode@users.noreply.github.com> Co-authored-by: Todd Venhaus <tvenhaus@gmail.com> --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: Bainian Liu <bainian12345@hotmail.com> Co-authored-by: bailiu <bailiu@microsoft.com> Co-authored-by: Jesus Aguilar <3589801+giventocode@users.noreply.github.com> Co-authored-by: microsoft-github-policy-service[bot] <77245923+microsoft-github-policy-service[bot]@users.noreply.github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Copilot <198982749+Copilot@users.noreply.github.com> Co-authored-by: Todd Venhaus <tvenhaus@gmail.com> --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: Bainian Liu <bainian12345@hotmail.com> Co-authored-by: bailiu <bailiu@microsoft.com> Co-authored-by: Jesus Aguilar <3589801+giventocode@users.noreply.github.com> Co-authored-by: Todd Venhaus <tvenhaus@gmail.com> Co-authored-by: microsoft-github-policy-service[bot] <77245923+microsoft-github-policy-service[bot]@users.noreply.github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Copilot <198982749+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Improve synchronization of fields in HybridConnectionListener.java