Skip to content

Enables text send and read operations for WebSocket connections. #81

Merged
bainian12345 merged 6 commits into
Azure:devfrom
giventocode:fix/write-read-text
May 20, 2022
Merged

Enables text send and read operations for WebSocket connections. #81
bainian12345 merged 6 commits into
Azure:devfrom
giventocode:fix/write-read-text

Conversation

@giventocode
Copy link
Copy Markdown
Contributor

@giventocode giventocode commented Feb 14, 2022 •
edited
Loading

Closes #80

@giventocode
uri encode request path
ee855e0
@giventocode
Merge state Add more commits by pushing to the fix/write-read-text br…
78da761 
…anch on

giventocode/azure-relay-java.Revert "uri encode request path"

This reverts commit ee855e0. Review required At least 1 approving review
is required by reviewers with write access. # Please enter the commit message for your changes. Lines
starting All checks have passed# with '#' will be ignored, and an empty message aborts the commit. 1
successful check# @microsoft-cla# On branch fix/write-read-text license/cla — All CLA requirements met.#
Your branch is up to date with 'origin/fix/write-read-text'. Required# Details# Changes to be committed:
Merging is blocked# modified: src/main/java/com/microsoft/azure/relay/HybridHttpConnection.java Merging can
be performed automatically with 1 approving review.# modified:
src/test/java/com/microsoft/azure/relay/HybridConnectionListenerTest.java @giventocode#
 #
 #
Leave a comment No file chosen Attach files by dragging & dropping, selecting or pasting them. Remember,
contributions to this repository should follow its code of conduct.
 ProTip! Add .patch or .diff to the end of URLs for Git’s plaintext views. Reviewers No reviews Still in
progress? Assignees No one assigned Labels None yet
bainian12345
bainian12345 reviewed Apr 8, 2022
View reviewed changes
Comment thread src/main/java/com/microsoft/azure/relay/ClientWebSocket.java Outdated
* @return Returns a CompletableFuture which completes when websocket receives text messages
*/
CompletableFuture<String> readTextAsync() {
public CompletableFuture<String> readTextAsync() {
Copy link
Copy Markdown
Contributor

@bainian12345 bainian12345 Apr 8, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

public C

Why do you need to make the two methods in this class public? WebSocketChannel is more public facing and ClientWebSocket is more of an internal implementation class, so I would prefer if you leave these methods internal.

Copy link
Copy Markdown
Contributor

@bainian12345 bainian12345 Apr 8, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can expose public methods in WebSocketChannel class instead.

bainian12345
bainian12345 reviewed Apr 8, 2022
View reviewed changes
Comment thread src/test/java/com/microsoft/azure/relay/SendReceiveTest.java Outdated
}


@Test
Copy link
Copy Markdown
Contributor

@bainian12345 bainian12345 Apr 8, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: remove the extra empty line

bainian12345
bainian12345 reviewed Apr 8, 2022
View reviewed changes
Comment thread src/test/java/com/microsoft/azure/relay/SendReceiveTest.java Outdated

@Test
public void websocketSendTextResponseTextTest() {
CompletableFuture<Void> listenerTask = sendAndReceiveTextWithWebsocketListener(WS_MSG, WS_MSG);
Copy link
Copy Markdown
Contributor

@bainian12345 bainian12345 Apr 8, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would like to see larger data (>64kb) be tested as well. Maybe you can create small and large strings out of the SMALL_BYTES and LARGE_BYTES from above.

Copy link
Copy Markdown
Contributor Author

@giventocode giventocode May 3, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

64kb is not possible in a single message. The DefaultMaxTextMessageBufferSize is by default RelayConstants.DEFAULT_CONNECTION_BUFFER_SIZE, which is 64Kb. I added a test with a string of 64KB.

bainian12345
bainian12345 reviewed Apr 8, 2022
View reviewed changes
Comment thread src/main/java/com/microsoft/azure/relay/WebSocketChannel.java
* @return A CompletableFuture which completes when websocket finishes sending the data.
* @throws TimeoutException Throws when the sending task does not complete within the given timeout.
*/
public CompletableFuture<Void> writeTextAsync(String textData, Duration timeout) {
Copy link
Copy Markdown
Contributor

@bainian12345 bainian12345 Apr 8, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just wondering, is there any functional difference where you would need to use WriteMode.TEXT instead?

Copy link
Copy Markdown
Contributor Author

@giventocode giventocode May 3, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps if you want to control the encoding of the String. However, in our case there is no value in exposing the WriteMode or multi-part messages.

bainian12345
bainian12345 suggested changes Apr 8, 2022
View reviewed changes
Copy link
Copy Markdown
Contributor

@bainian12345 bainian12345 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🕐

@giventocode giventocode requested a review from bainian12345 May 3, 2022 00:49
bainian12345
bainian12345 approved these changes May 20, 2022
View reviewed changes
Copy link
Copy Markdown
Contributor

@bainian12345 bainian12345 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@bainian12345 bainian12345 merged commit b81840f into Azure:dev May 20, 2022
jbjordan pushed a commit that referenced this pull request Dec 2, 2022
@giventocode @jbjordan
Enables text send and read operations for WebSocket connections. (#81)
0a0f483 
* text write/read support for websockets

* uri encode request path

* Merge state Add more commits by pushing to the fix/write-read-text branch on
giventocode/azure-relay-java.Revert "uri encode request path"

This reverts commit ee855e0. Review required At least 1 approving review
is required by reviewers with write access. # Please enter the commit message for your changes. Lines
starting All checks have passed# with '#' will be ignored, and an empty message aborts the commit. 1
successful check# @microsoft-cla# On branch fix/write-read-text license/cla — All CLA requirements met.#
Your branch is up to date with 'origin/fix/write-read-text'. Required# Details# Changes to be committed:
Merging is blocked# modified: src/main/java/com/microsoft/azure/relay/HybridHttpConnection.java Merging can
be performed automatically with 1 approving review.# modified:
src/test/java/com/microsoft/azure/relay/HybridConnectionListenerTest.java @giventocode#
 #
 #
Leave a comment No file chosen Attach files by dragging & dropping, selecting or pasting them. Remember,
contributions to this repository should follow its code of conduct.
 ProTip! Add .patch or .diff to the end of URLs for Git’s plaintext views. Reviewers No reviews Still in
progress? Assignees No one assigned Labels None yet

* added large message test, pr feedback

* import fixes, and nit

* import fix
jbjordan added a commit that referenced this pull request May 21, 2026
@jbjordan @bainian12345
@giventocode @tvenhaus
merge dev into main (#100)
7786df7 
* improve synchronization of fields (#68)

Co-authored-by: bailiu <bailiu@microsoft.com>

* make status description for HTTP response be JSON safe (#69)

* make status description for HTTP response be JSON safe

* assert response description

Co-authored-by: bailiu <bailiu@microsoft.com>

* allow empty URI query param (#67)

Co-authored-by: bailiu <bailiu@microsoft.com>

* Add new API to allow authentication with Azure Identity (#76)

* cleanup unnecessary pom configurations

* Enable authentication using Azure Identity

* add copyright headers

Co-authored-by: bailiu <bailiu@microsoft.com>

* Updating dependency according to github issues (#77)

Co-authored-by: bailiu <bailiu@microsoft.com>

* update version to 0.0.4 (#78)

Co-authored-by: bailiu <bailiu@microsoft.com>

* Enables text send and read operations for WebSocket connections.  (#81)

* text write/read support for websockets

* uri encode request path

* Merge state Add more commits by pushing to the fix/write-read-text branch on
giventocode/azure-relay-java.Revert "uri encode request path"

This reverts commit ee855e0. Review required At least 1 approving review
is required by reviewers with write access. # Please enter the commit message for your changes. Lines
starting All checks have passed# with '#' will be ignored, and an empty message aborts the commit. 1
successful check# @microsoft-cla# On branch fix/write-read-text license/cla — All CLA requirements met.#
Your branch is up to date with 'origin/fix/write-read-text'. Required# Details# Changes to be committed:
Merging is blocked# modified: src/main/java/com/microsoft/azure/relay/HybridHttpConnection.java Merging can
be performed automatically with 1 approving review.# modified:
src/test/java/com/microsoft/azure/relay/HybridConnectionListenerTest.java @giventocode#
 #
 #
Leave a comment No file chosen Attach files by dragging & dropping, selecting or pasting them. Remember,
contributions to this repository should follow its code of conduct.
 ProTip! Add .patch or .diff to the end of URLs for Git’s plaintext views. Reviewers No reviews Still in
progress? Assignees No one assigned Labels None yet

* added large message test, pr feedback

* import fixes, and nit

* import fix

* Hybrid HTTP connection handles URL requests with spaces.  (#83)

* encode requests url paths

* PR feedback

Co-authored-by: Bainian Liu <bainian12345@hotmail.com>

* .env, logging, and updated dependencies (#88)

* Replace JSR-356 WebSocket implementation with Jetty (#89)

* .env, logging, and updated dependencies

* replace javax.websockets with jetty websockets

* Implement keep-alive via WebSocket Ping (#91)

* .env, logging, and updated dependencies

* replace javax.websockets with jetty websockets

* implement ping

* update interval and fix spacing

* fix whitespace

* formatting

* make ping interval configurable and add test

---------

Co-authored-by: Bainian Liu <bainian12345@hotmail.com>
Co-authored-by: bailiu <bailiu@microsoft.com>
Co-authored-by: Jesus Aguilar <3589801+giventocode@users.noreply.github.com>
Co-authored-by: Todd Venhaus <tvenhaus@gmail.com>
jbjordan added a commit that referenced this pull request May 21, 2026
@jbjordan @bainian12345
@giventocode @tvenhaus
merge main into dev (#101)
da09938 
* improve synchronization of fields (#68)

Co-authored-by: bailiu <bailiu@microsoft.com>

* make status description for HTTP response be JSON safe (#69)

* make status description for HTTP response be JSON safe

* assert response description

Co-authored-by: bailiu <bailiu@microsoft.com>

* allow empty URI query param (#67)

Co-authored-by: bailiu <bailiu@microsoft.com>

* Add new API to allow authentication with Azure Identity (#76)

* cleanup unnecessary pom configurations

* Enable authentication using Azure Identity

* add copyright headers

Co-authored-by: bailiu <bailiu@microsoft.com>

* Updating dependency according to github issues (#77)

Co-authored-by: bailiu <bailiu@microsoft.com>

* update version to 0.0.4 (#78)

Co-authored-by: bailiu <bailiu@microsoft.com>

* Enables text send and read operations for WebSocket connections.  (#81)

* text write/read support for websockets

* uri encode request path

* Merge state Add more commits by pushing to the fix/write-read-text branch on
giventocode/azure-relay-java.Revert "uri encode request path"

This reverts commit ee855e0. Review required At least 1 approving review
is required by reviewers with write access. # Please enter the commit message for your changes. Lines
starting All checks have passed# with '#' will be ignored, and an empty message aborts the commit. 1
successful check# @microsoft-cla# On branch fix/write-read-text license/cla — All CLA requirements met.#
Your branch is up to date with 'origin/fix/write-read-text'. Required# Details# Changes to be committed:
Merging is blocked# modified: src/main/java/com/microsoft/azure/relay/HybridHttpConnection.java Merging can
be performed automatically with 1 approving review.# modified:
src/test/java/com/microsoft/azure/relay/HybridConnectionListenerTest.java @giventocode#
 #
 #
Leave a comment No file chosen Attach files by dragging & dropping, selecting or pasting them. Remember,
contributions to this repository should follow its code of conduct.
 ProTip! Add .patch or .diff to the end of URLs for Git’s plaintext views. Reviewers No reviews Still in
progress? Assignees No one assigned Labels None yet

* added large message test, pr feedback

* import fixes, and nit

* import fix

* Hybrid HTTP connection handles URL requests with spaces.  (#83)

* encode requests url paths

* PR feedback

Co-authored-by: Bainian Liu <bainian12345@hotmail.com>

* .env, logging, and updated dependencies (#88)

* Replace JSR-356 WebSocket implementation with Jetty (#89)

* .env, logging, and updated dependencies

* replace javax.websockets with jetty websockets

* Implement keep-alive via WebSocket Ping (#91)

* .env, logging, and updated dependencies

* replace javax.websockets with jetty websockets

* implement ping

* update interval and fix spacing

* fix whitespace

* formatting

* make ping interval configurable and add test

---------

Co-authored-by: Bainian Liu <bainian12345@hotmail.com>
Co-authored-by: bailiu <bailiu@microsoft.com>
Co-authored-by: Jesus Aguilar <3589801+giventocode@users.noreply.github.com>
Co-authored-by: Todd Venhaus <tvenhaus@gmail.com>
jbjordan added a commit that referenced this pull request May 21, 2026
@jbjordan @bainian12345
@giventocode @microsoft-github-policy-service @dependabot @tvenhaus
Rebase dev (#104)
522a44a 
* Merge dev branch into master for version 0.0.4 (#79)

* improve synchronization of fields (#68)

Co-authored-by: bailiu <bailiu@microsoft.com>

* make status description for HTTP response be JSON safe (#69)

* make status description for HTTP response be JSON safe

* assert response description

Co-authored-by: bailiu <bailiu@microsoft.com>

* allow empty URI query param (#67)

Co-authored-by: bailiu <bailiu@microsoft.com>

* Add new API to allow authentication with Azure Identity (#76)

* cleanup unnecessary pom configurations

* Enable authentication using Azure Identity

* add copyright headers

Co-authored-by: bailiu <bailiu@microsoft.com>

* Updating dependency according to github issues (#77)

Co-authored-by: bailiu <bailiu@microsoft.com>

* update version to 0.0.4 (#78)

Co-authored-by: bailiu <bailiu@microsoft.com>

Co-authored-by: bailiu <bailiu@microsoft.com>

* Enables text send and read operations for WebSocket connections.  (#81)

* text write/read support for websockets

* uri encode request path

* Merge state Add more commits by pushing to the fix/write-read-text branch on
giventocode/azure-relay-java.Revert "uri encode request path"

This reverts commit ee855e0. Review required At least 1 approving review
is required by reviewers with write access. # Please enter the commit message for your changes. Lines
starting All checks have passed# with '#' will be ignored, and an empty message aborts the commit. 1
successful check# @microsoft-cla# On branch fix/write-read-text license/cla — All CLA requirements met.#
Your branch is up to date with 'origin/fix/write-read-text'. Required# Details# Changes to be committed:
Merging is blocked# modified: src/main/java/com/microsoft/azure/relay/HybridHttpConnection.java Merging can
be performed automatically with 1 approving review.# modified:
src/test/java/com/microsoft/azure/relay/HybridConnectionListenerTest.java @giventocode#
 #
 #
Leave a comment No file chosen Attach files by dragging & dropping, selecting or pasting them. Remember,
contributions to this repository should follow its code of conduct.
 ProTip! Add .patch or .diff to the end of URLs for Git’s plaintext views. Reviewers No reviews Still in
progress? Assignees No one assigned Labels None yet

* added large message test, pr feedback

* import fixes, and nit

* import fix

* Hybrid HTTP connection handles URL requests with spaces.  (#83)

* encode requests url paths

* PR feedback

Co-authored-by: Bainian Liu <bainian12345@hotmail.com>

* Version Update (#90)

Removed Javadoc throws comment and updated version in pom.xml

* Microsoft mandatory file (#85)

Co-authored-by: microsoft-github-policy-service[bot] <77245923+microsoft-github-policy-service[bot]@users.noreply.github.com>
Co-authored-by: Jacob <108886350+jbjordan@users.noreply.github.com>

* Bump json from 20180813 to 20230227 (#92)

Bumps [json](https://github.com/douglascrockford/JSON-java) from 20180813 to 20230227.
- [Release notes](https://github.com/douglascrockford/JSON-java/releases)
- [Changelog](https://github.com/stleary/JSON-java/blob/master/docs/RELEASES.md)
- [Commits](https://github.com/douglascrockford/JSON-java/commits)

---
updated-dependencies:
- dependency-name: org.json:json
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Jacob <108886350+jbjordan@users.noreply.github.com>

* Update pom.xml to version 0.0.6 (#93)

* Bump org.json:json from 20230227 to 20231013 (#94)

Bumps [org.json:json](https://github.com/douglascrockford/JSON-java) from 20230227 to 20231013.
- [Release notes](https://github.com/douglascrockford/JSON-java/releases)
- [Changelog](https://github.com/stleary/JSON-java/blob/master/docs/RELEASES.md)
- [Commits](https://github.com/douglascrockford/JSON-java/commits)

---
updated-dependencies:
- dependency-name: org.json:json
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Bump com.azure:azure-identity from 1.4.0 to 1.12.2 (#95)

Bumps [com.azure:azure-identity](https://github.com/Azure/azure-sdk-for-java) from 1.4.0 to 1.12.2.
- [Release notes](https://github.com/Azure/azure-sdk-for-java/releases)
- [Commits](Azure/azure-sdk-for-java@azure-json_1.4.0...azure-identity_1.12.2)

---
updated-dependencies:
- dependency-name: com.azure:azure-identity
  dependency-version: 1.12.2
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Update Util (#96)

* Merge dev into master and resolve conflicts (#97)

Agent-Logs-Url: https://github.com/Azure/azure-relay-java/sessions/570c7374-cd9f-48c1-a806-3192052d742e

Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: jbjordan <108886350+jbjordan@users.noreply.github.com>

* Revert "Merge dev into master and resolve conflicts (#97)" (#98)

This reverts commit bc10c8c.

* merge dev into main (#100)

* improve synchronization of fields (#68)

Co-authored-by: bailiu <bailiu@microsoft.com>

* make status description for HTTP response be JSON safe (#69)

* make status description for HTTP response be JSON safe

* assert response description

Co-authored-by: bailiu <bailiu@microsoft.com>

* allow empty URI query param (#67)

Co-authored-by: bailiu <bailiu@microsoft.com>

* Add new API to allow authentication with Azure Identity (#76)

* cleanup unnecessary pom configurations

* Enable authentication using Azure Identity

* add copyright headers

Co-authored-by: bailiu <bailiu@microsoft.com>

* Updating dependency according to github issues (#77)

Co-authored-by: bailiu <bailiu@microsoft.com>

* update version to 0.0.4 (#78)

Co-authored-by: bailiu <bailiu@microsoft.com>

* Enables text send and read operations for WebSocket connections.  (#81)

* text write/read support for websockets

* uri encode request path

* Merge state Add more commits by pushing to the fix/write-read-text branch on
giventocode/azure-relay-java.Revert "uri encode request path"

This reverts commit ee855e0. Review required At least 1 approving review
is required by reviewers with write access. # Please enter the commit message for your changes. Lines
starting All checks have passed# with '#' will be ignored, and an empty message aborts the commit. 1
successful check# @microsoft-cla# On branch fix/write-read-text license/cla — All CLA requirements met.#
Your branch is up to date with 'origin/fix/write-read-text'. Required# Details# Changes to be committed:
Merging is blocked# modified: src/main/java/com/microsoft/azure/relay/HybridHttpConnection.java Merging can
be performed automatically with 1 approving review.# modified:
src/test/java/com/microsoft/azure/relay/HybridConnectionListenerTest.java @giventocode#
 #
 #
Leave a comment No file chosen Attach files by dragging & dropping, selecting or pasting them. Remember,
contributions to this repository should follow its code of conduct.
 ProTip! Add .patch or .diff to the end of URLs for Git’s plaintext views. Reviewers No reviews Still in
progress? Assignees No one assigned Labels None yet

* added large message test, pr feedback

* import fixes, and nit

* import fix

* Hybrid HTTP connection handles URL requests with spaces.  (#83)

* encode requests url paths

* PR feedback

Co-authored-by: Bainian Liu <bainian12345@hotmail.com>

* .env, logging, and updated dependencies (#88)

* Replace JSR-356 WebSocket implementation with Jetty (#89)

* .env, logging, and updated dependencies

* replace javax.websockets with jetty websockets

* Implement keep-alive via WebSocket Ping (#91)

* .env, logging, and updated dependencies

* replace javax.websockets with jetty websockets

* implement ping

* update interval and fix spacing

* fix whitespace

* formatting

* make ping interval configurable and add test

---------

Co-authored-by: Bainian Liu <bainian12345@hotmail.com>
Co-authored-by: bailiu <bailiu@microsoft.com>
Co-authored-by: Jesus Aguilar <3589801+giventocode@users.noreply.github.com>
Co-authored-by: Todd Venhaus <tvenhaus@gmail.com>

---------

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: Bainian Liu <bainian12345@hotmail.com>
Co-authored-by: bailiu <bailiu@microsoft.com>
Co-authored-by: Jesus Aguilar <3589801+giventocode@users.noreply.github.com>
Co-authored-by: microsoft-github-policy-service[bot] <77245923+microsoft-github-policy-service[bot]@users.noreply.github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Copilot <198982749+Copilot@users.noreply.github.com>
Co-authored-by: Todd Venhaus <tvenhaus@gmail.com>
jbjordan added a commit that referenced this pull request May 21, 2026
@jbjordan @bainian12345
@giventocode @tvenhaus @microsoft-github-policy-service @dependabot
merge dev into main (#105)
bedcd49 
* improve synchronization of fields (#68)

Co-authored-by: bailiu <bailiu@microsoft.com>

* make status description for HTTP response be JSON safe (#69)

* make status description for HTTP response be JSON safe

* assert response description

Co-authored-by: bailiu <bailiu@microsoft.com>

* allow empty URI query param (#67)

Co-authored-by: bailiu <bailiu@microsoft.com>

* Add new API to allow authentication with Azure Identity (#76)

* cleanup unnecessary pom configurations

* Enable authentication using Azure Identity

* add copyright headers

Co-authored-by: bailiu <bailiu@microsoft.com>

* Updating dependency according to github issues (#77)

Co-authored-by: bailiu <bailiu@microsoft.com>

* update version to 0.0.4 (#78)

Co-authored-by: bailiu <bailiu@microsoft.com>

* Enables text send and read operations for WebSocket connections.  (#81)

* text write/read support for websockets

* uri encode request path

* Merge state Add more commits by pushing to the fix/write-read-text branch on
giventocode/azure-relay-java.Revert "uri encode request path"

This reverts commit ee855e0. Review required At least 1 approving review
is required by reviewers with write access. # Please enter the commit message for your changes. Lines
starting All checks have passed# with '#' will be ignored, and an empty message aborts the commit. 1
successful check# @microsoft-cla# On branch fix/write-read-text license/cla — All CLA requirements met.#
Your branch is up to date with 'origin/fix/write-read-text'. Required# Details# Changes to be committed:
Merging is blocked# modified: src/main/java/com/microsoft/azure/relay/HybridHttpConnection.java Merging can
be performed automatically with 1 approving review.# modified:
src/test/java/com/microsoft/azure/relay/HybridConnectionListenerTest.java @giventocode#
 #
 #
Leave a comment No file chosen Attach files by dragging & dropping, selecting or pasting them. Remember,
contributions to this repository should follow its code of conduct.
 ProTip! Add .patch or .diff to the end of URLs for Git’s plaintext views. Reviewers No reviews Still in
progress? Assignees No one assigned Labels None yet

* added large message test, pr feedback

* import fixes, and nit

* import fix

* Hybrid HTTP connection handles URL requests with spaces.  (#83)

* encode requests url paths

* PR feedback

Co-authored-by: Bainian Liu <bainian12345@hotmail.com>

* .env, logging, and updated dependencies (#88)

* Replace JSR-356 WebSocket implementation with Jetty (#89)

* .env, logging, and updated dependencies

* replace javax.websockets with jetty websockets

* Implement keep-alive via WebSocket Ping (#91)

* .env, logging, and updated dependencies

* replace javax.websockets with jetty websockets

* implement ping

* update interval and fix spacing

* fix whitespace

* formatting

* make ping interval configurable and add test

* Rebase dev (#104)

* Merge dev branch into master for version 0.0.4 (#79)

* improve synchronization of fields (#68)

Co-authored-by: bailiu <bailiu@microsoft.com>

* make status description for HTTP response be JSON safe (#69)

* make status description for HTTP response be JSON safe

* assert response description

Co-authored-by: bailiu <bailiu@microsoft.com>

* allow empty URI query param (#67)

Co-authored-by: bailiu <bailiu@microsoft.com>

* Add new API to allow authentication with Azure Identity (#76)

* cleanup unnecessary pom configurations

* Enable authentication using Azure Identity

* add copyright headers

Co-authored-by: bailiu <bailiu@microsoft.com>

* Updating dependency according to github issues (#77)

Co-authored-by: bailiu <bailiu@microsoft.com>

* update version to 0.0.4 (#78)

Co-authored-by: bailiu <bailiu@microsoft.com>

Co-authored-by: bailiu <bailiu@microsoft.com>

* Enables text send and read operations for WebSocket connections.  (#81)

* text write/read support for websockets

* uri encode request path

* Merge state Add more commits by pushing to the fix/write-read-text branch on
giventocode/azure-relay-java.Revert "uri encode request path"

This reverts commit ee855e0. Review required At least 1 approving review
is required by reviewers with write access. # Please enter the commit message for your changes. Lines
starting All checks have passed# with '#' will be ignored, and an empty message aborts the commit. 1
successful check# @microsoft-cla# On branch fix/write-read-text license/cla — All CLA requirements met.#
Your branch is up to date with 'origin/fix/write-read-text'. Required# Details# Changes to be committed:
Merging is blocked# modified: src/main/java/com/microsoft/azure/relay/HybridHttpConnection.java Merging can
be performed automatically with 1 approving review.# modified:
src/test/java/com/microsoft/azure/relay/HybridConnectionListenerTest.java @giventocode#
 #
 #
Leave a comment No file chosen Attach files by dragging & dropping, selecting or pasting them. Remember,
contributions to this repository should follow its code of conduct.
 ProTip! Add .patch or .diff to the end of URLs for Git’s plaintext views. Reviewers No reviews Still in
progress? Assignees No one assigned Labels None yet

* added large message test, pr feedback

* import fixes, and nit

* import fix

* Hybrid HTTP connection handles URL requests with spaces.  (#83)

* encode requests url paths

* PR feedback

Co-authored-by: Bainian Liu <bainian12345@hotmail.com>

* Version Update (#90)

Removed Javadoc throws comment and updated version in pom.xml

* Microsoft mandatory file (#85)

Co-authored-by: microsoft-github-policy-service[bot] <77245923+microsoft-github-policy-service[bot]@users.noreply.github.com>
Co-authored-by: Jacob <108886350+jbjordan@users.noreply.github.com>

* Bump json from 20180813 to 20230227 (#92)

Bumps [json](https://github.com/douglascrockford/JSON-java) from 20180813 to 20230227.
- [Release notes](https://github.com/douglascrockford/JSON-java/releases)
- [Changelog](https://github.com/stleary/JSON-java/blob/master/docs/RELEASES.md)
- [Commits](https://github.com/douglascrockford/JSON-java/commits)

---
updated-dependencies:
- dependency-name: org.json:json
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Jacob <108886350+jbjordan@users.noreply.github.com>

* Update pom.xml to version 0.0.6 (#93)

* Bump org.json:json from 20230227 to 20231013 (#94)

Bumps [org.json:json](https://github.com/douglascrockford/JSON-java) from 20230227 to 20231013.
- [Release notes](https://github.com/douglascrockford/JSON-java/releases)
- [Changelog](https://github.com/stleary/JSON-java/blob/master/docs/RELEASES.md)
- [Commits](https://github.com/douglascrockford/JSON-java/commits)

---
updated-dependencies:
- dependency-name: org.json:json
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Bump com.azure:azure-identity from 1.4.0 to 1.12.2 (#95)

Bumps [com.azure:azure-identity](https://github.com/Azure/azure-sdk-for-java) from 1.4.0 to 1.12.2.
- [Release notes](https://github.com/Azure/azure-sdk-for-java/releases)
- [Commits](Azure/azure-sdk-for-java@azure-json_1.4.0...azure-identity_1.12.2)

---
updated-dependencies:
- dependency-name: com.azure:azure-identity
  dependency-version: 1.12.2
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Update Util (#96)

* Merge dev into master and resolve conflicts (#97)

Agent-Logs-Url: https://github.com/Azure/azure-relay-java/sessions/570c7374-cd9f-48c1-a806-3192052d742e

Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: jbjordan <108886350+jbjordan@users.noreply.github.com>

* Revert "Merge dev into master and resolve conflicts (#97)" (#98)

This reverts commit bc10c8c.

* merge dev into main (#100)

* improve synchronization of fields (#68)

Co-authored-by: bailiu <bailiu@microsoft.com>

* make status description for HTTP response be JSON safe (#69)

* make status description for HTTP response be JSON safe

* assert response description

Co-authored-by: bailiu <bailiu@microsoft.com>

* allow empty URI query param (#67)

Co-authored-by: bailiu <bailiu@microsoft.com>

* Add new API to allow authentication with Azure Identity (#76)

* cleanup unnecessary pom configurations

* Enable authentication using Azure Identity

* add copyright headers

Co-authored-by: bailiu <bailiu@microsoft.com>

* Updating dependency according to github issues (#77)

Co-authored-by: bailiu <bailiu@microsoft.com>

* update version to 0.0.4 (#78)

Co-authored-by: bailiu <bailiu@microsoft.com>

* Enables text send and read operations for WebSocket connections.  (#81)

* text write/read support for websockets

* uri encode request path

* Merge state Add more commits by pushing to the fix/write-read-text branch on
giventocode/azure-relay-java.Revert "uri encode request path"

This reverts commit ee855e0. Review required At least 1 approving review
is required by reviewers with write access. # Please enter the commit message for your changes. Lines
starting All checks have passed# with '#' will be ignored, and an empty message aborts the commit. 1
successful check# @microsoft-cla# On branch fix/write-read-text license/cla — All CLA requirements met.#
Your branch is up to date with 'origin/fix/write-read-text'. Required# Details# Changes to be committed:
Merging is blocked# modified: src/main/java/com/microsoft/azure/relay/HybridHttpConnection.java Merging can
be performed automatically with 1 approving review.# modified:
src/test/java/com/microsoft/azure/relay/HybridConnectionListenerTest.java @giventocode#
 #
 #
Leave a comment No file chosen Attach files by dragging & dropping, selecting or pasting them. Remember,
contributions to this repository should follow its code of conduct.
 ProTip! Add .patch or .diff to the end of URLs for Git’s plaintext views. Reviewers No reviews Still in
progress? Assignees No one assigned Labels None yet

* added large message test, pr feedback

* import fixes, and nit

* import fix

* Hybrid HTTP connection handles URL requests with spaces.  (#83)

* encode requests url paths

* PR feedback

Co-authored-by: Bainian Liu <bainian12345@hotmail.com>

* .env, logging, and updated dependencies (#88)

* Replace JSR-356 WebSocket implementation with Jetty (#89)

* .env, logging, and updated dependencies

* replace javax.websockets with jetty websockets

* Implement keep-alive via WebSocket Ping (#91)

* .env, logging, and updated dependencies

* replace javax.websockets with jetty websockets

* implement ping

* update interval and fix spacing

* fix whitespace

* formatting

* make ping interval configurable and add test

---------

Co-authored-by: Bainian Liu <bainian12345@hotmail.com>
Co-authored-by: bailiu <bailiu@microsoft.com>
Co-authored-by: Jesus Aguilar <3589801+giventocode@users.noreply.github.com>
Co-authored-by: Todd Venhaus <tvenhaus@gmail.com>

---------

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: Bainian Liu <bainian12345@hotmail.com>
Co-authored-by: bailiu <bailiu@microsoft.com>
Co-authored-by: Jesus Aguilar <3589801+giventocode@users.noreply.github.com>
Co-authored-by: microsoft-github-policy-service[bot] <77245923+microsoft-github-policy-service[bot]@users.noreply.github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Copilot <198982749+Copilot@users.noreply.github.com>
Co-authored-by: Todd Venhaus <tvenhaus@gmail.com>

---------

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: Bainian Liu <bainian12345@hotmail.com>
Co-authored-by: bailiu <bailiu@microsoft.com>
Co-authored-by: Jesus Aguilar <3589801+giventocode@users.noreply.github.com>
Co-authored-by: Todd Venhaus <tvenhaus@gmail.com>
Co-authored-by: microsoft-github-policy-service[bot] <77245923+microsoft-github-policy-service[bot]@users.noreply.github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Copilot <198982749+Copilot@users.noreply.github.com>
jbjordan added a commit that referenced this pull request May 21, 2026
@jbjordan @bainian12345
@giventocode @tvenhaus @microsoft-github-policy-service @dependabot
update commit history based on dev (#106)
a8612c6 
* improve synchronization of fields (#68)

Co-authored-by: bailiu <bailiu@microsoft.com>

* make status description for HTTP response be JSON safe (#69)

* make status description for HTTP response be JSON safe

* assert response description

Co-authored-by: bailiu <bailiu@microsoft.com>

* allow empty URI query param (#67)

Co-authored-by: bailiu <bailiu@microsoft.com>

* Add new API to allow authentication with Azure Identity (#76)

* cleanup unnecessary pom configurations

* Enable authentication using Azure Identity

* add copyright headers

Co-authored-by: bailiu <bailiu@microsoft.com>

* Updating dependency according to github issues (#77)

Co-authored-by: bailiu <bailiu@microsoft.com>

* update version to 0.0.4 (#78)

Co-authored-by: bailiu <bailiu@microsoft.com>

* Enables text send and read operations for WebSocket connections.  (#81)

* text write/read support for websockets

* uri encode request path

* Merge state Add more commits by pushing to the fix/write-read-text branch on
giventocode/azure-relay-java.Revert "uri encode request path"

This reverts commit ee855e0. Review required At least 1 approving review
is required by reviewers with write access. # Please enter the commit message for your changes. Lines
starting All checks have passed# with '#' will be ignored, and an empty message aborts the commit. 1
successful check# @microsoft-cla# On branch fix/write-read-text license/cla — All CLA requirements met.#
Your branch is up to date with 'origin/fix/write-read-text'. Required# Details# Changes to be committed:
Merging is blocked# modified: src/main/java/com/microsoft/azure/relay/HybridHttpConnection.java Merging can
be performed automatically with 1 approving review.# modified:
src/test/java/com/microsoft/azure/relay/HybridConnectionListenerTest.java @giventocode#
 #
 #
Leave a comment No file chosen Attach files by dragging & dropping, selecting or pasting them. Remember,
contributions to this repository should follow its code of conduct.
 ProTip! Add .patch or .diff to the end of URLs for Git’s plaintext views. Reviewers No reviews Still in
progress? Assignees No one assigned Labels None yet

* added large message test, pr feedback

* import fixes, and nit

* import fix

* Hybrid HTTP connection handles URL requests with spaces.  (#83)

* encode requests url paths

* PR feedback

Co-authored-by: Bainian Liu <bainian12345@hotmail.com>

* .env, logging, and updated dependencies (#88)

* Replace JSR-356 WebSocket implementation with Jetty (#89)

* .env, logging, and updated dependencies

* replace javax.websockets with jetty websockets

* Implement keep-alive via WebSocket Ping (#91)

* .env, logging, and updated dependencies

* replace javax.websockets with jetty websockets

* implement ping

* update interval and fix spacing

* fix whitespace

* formatting

* make ping interval configurable and add test

* Rebase dev (#104)

* Merge dev branch into master for version 0.0.4 (#79)

* improve synchronization of fields (#68)

Co-authored-by: bailiu <bailiu@microsoft.com>

* make status description for HTTP response be JSON safe (#69)

* make status description for HTTP response be JSON safe

* assert response description

Co-authored-by: bailiu <bailiu@microsoft.com>

* allow empty URI query param (#67)

Co-authored-by: bailiu <bailiu@microsoft.com>

* Add new API to allow authentication with Azure Identity (#76)

* cleanup unnecessary pom configurations

* Enable authentication using Azure Identity

* add copyright headers

Co-authored-by: bailiu <bailiu@microsoft.com>

* Updating dependency according to github issues (#77)

Co-authored-by: bailiu <bailiu@microsoft.com>

* update version to 0.0.4 (#78)

Co-authored-by: bailiu <bailiu@microsoft.com>

Co-authored-by: bailiu <bailiu@microsoft.com>

* Enables text send and read operations for WebSocket connections.  (#81)

* text write/read support for websockets

* uri encode request path

* Merge state Add more commits by pushing to the fix/write-read-text branch on
giventocode/azure-relay-java.Revert "uri encode request path"

This reverts commit ee855e0. Review required At least 1 approving review
is required by reviewers with write access. # Please enter the commit message for your changes. Lines
starting All checks have passed# with '#' will be ignored, and an empty message aborts the commit. 1
successful check# @microsoft-cla# On branch fix/write-read-text license/cla — All CLA requirements met.#
Your branch is up to date with 'origin/fix/write-read-text'. Required# Details# Changes to be committed:
Merging is blocked# modified: src/main/java/com/microsoft/azure/relay/HybridHttpConnection.java Merging can
be performed automatically with 1 approving review.# modified:
src/test/java/com/microsoft/azure/relay/HybridConnectionListenerTest.java @giventocode#
 #
 #
Leave a comment No file chosen Attach files by dragging & dropping, selecting or pasting them. Remember,
contributions to this repository should follow its code of conduct.
 ProTip! Add .patch or .diff to the end of URLs for Git’s plaintext views. Reviewers No reviews Still in
progress? Assignees No one assigned Labels None yet

* added large message test, pr feedback

* import fixes, and nit

* import fix

* Hybrid HTTP connection handles URL requests with spaces.  (#83)

* encode requests url paths

* PR feedback

Co-authored-by: Bainian Liu <bainian12345@hotmail.com>

* Version Update (#90)

Removed Javadoc throws comment and updated version in pom.xml

* Microsoft mandatory file (#85)

Co-authored-by: microsoft-github-policy-service[bot] <77245923+microsoft-github-policy-service[bot]@users.noreply.github.com>
Co-authored-by: Jacob <108886350+jbjordan@users.noreply.github.com>

* Bump json from 20180813 to 20230227 (#92)

Bumps [json](https://github.com/douglascrockford/JSON-java) from 20180813 to 20230227.
- [Release notes](https://github.com/douglascrockford/JSON-java/releases)
- [Changelog](https://github.com/stleary/JSON-java/blob/master/docs/RELEASES.md)
- [Commits](https://github.com/douglascrockford/JSON-java/commits)

---
updated-dependencies:
- dependency-name: org.json:json
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Jacob <108886350+jbjordan@users.noreply.github.com>

* Update pom.xml to version 0.0.6 (#93)

* Bump org.json:json from 20230227 to 20231013 (#94)

Bumps [org.json:json](https://github.com/douglascrockford/JSON-java) from 20230227 to 20231013.
- [Release notes](https://github.com/douglascrockford/JSON-java/releases)
- [Changelog](https://github.com/stleary/JSON-java/blob/master/docs/RELEASES.md)
- [Commits](https://github.com/douglascrockford/JSON-java/commits)

---
updated-dependencies:
- dependency-name: org.json:json
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Bump com.azure:azure-identity from 1.4.0 to 1.12.2 (#95)

Bumps [com.azure:azure-identity](https://github.com/Azure/azure-sdk-for-java) from 1.4.0 to 1.12.2.
- [Release notes](https://github.com/Azure/azure-sdk-for-java/releases)
- [Commits](Azure/azure-sdk-for-java@azure-json_1.4.0...azure-identity_1.12.2)

---
updated-dependencies:
- dependency-name: com.azure:azure-identity
  dependency-version: 1.12.2
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Update Util (#96)

* Merge dev into master and resolve conflicts (#97)

Agent-Logs-Url: https://github.com/Azure/azure-relay-java/sessions/570c7374-cd9f-48c1-a806-3192052d742e

Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: jbjordan <108886350+jbjordan@users.noreply.github.com>

* Revert "Merge dev into master and resolve conflicts (#97)" (#98)

This reverts commit bc10c8c.

* merge dev into main (#100)

* improve synchronization of fields (#68)

Co-authored-by: bailiu <bailiu@microsoft.com>

* make status description for HTTP response be JSON safe (#69)

* make status description for HTTP response be JSON safe

* assert response description

Co-authored-by: bailiu <bailiu@microsoft.com>

* allow empty URI query param (#67)

Co-authored-by: bailiu <bailiu@microsoft.com>

* Add new API to allow authentication with Azure Identity (#76)

* cleanup unnecessary pom configurations

* Enable authentication using Azure Identity

* add copyright headers

Co-authored-by: bailiu <bailiu@microsoft.com>

* Updating dependency according to github issues (#77)

Co-authored-by: bailiu <bailiu@microsoft.com>

* update version to 0.0.4 (#78)

Co-authored-by: bailiu <bailiu@microsoft.com>

* Enables text send and read operations for WebSocket connections.  (#81)

* text write/read support for websockets

* uri encode request path

* Merge state Add more commits by pushing to the fix/write-read-text branch on
giventocode/azure-relay-java.Revert "uri encode request path"

This reverts commit ee855e0. Review required At least 1 approving review
is required by reviewers with write access. # Please enter the commit message for your changes. Lines
starting All checks have passed# with '#' will be ignored, and an empty message aborts the commit. 1
successful check# @microsoft-cla# On branch fix/write-read-text license/cla — All CLA requirements met.#
Your branch is up to date with 'origin/fix/write-read-text'. Required# Details# Changes to be committed:
Merging is blocked# modified: src/main/java/com/microsoft/azure/relay/HybridHttpConnection.java Merging can
be performed automatically with 1 approving review.# modified:
src/test/java/com/microsoft/azure/relay/HybridConnectionListenerTest.java @giventocode#
 #
 #
Leave a comment No file chosen Attach files by dragging & dropping, selecting or pasting them. Remember,
contributions to this repository should follow its code of conduct.
 ProTip! Add .patch or .diff to the end of URLs for Git’s plaintext views. Reviewers No reviews Still in
progress? Assignees No one assigned Labels None yet

* added large message test, pr feedback

* import fixes, and nit

* import fix

* Hybrid HTTP connection handles URL requests with spaces.  (#83)

* encode requests url paths

* PR feedback

Co-authored-by: Bainian Liu <bainian12345@hotmail.com>

* .env, logging, and updated dependencies (#88)

* Replace JSR-356 WebSocket implementation with Jetty (#89)

* .env, logging, and updated dependencies

* replace javax.websockets with jetty websockets

* Implement keep-alive via WebSocket Ping (#91)

* .env, logging, and updated dependencies

* replace javax.websockets with jetty websockets

* implement ping

* update interval and fix spacing

* fix whitespace

* formatting

* make ping interval configurable and add test

---------

Co-authored-by: Bainian Liu <bainian12345@hotmail.com>
Co-authored-by: bailiu <bailiu@microsoft.com>
Co-authored-by: Jesus Aguilar <3589801+giventocode@users.noreply.github.com>
Co-authored-by: Todd Venhaus <tvenhaus@gmail.com>

---------

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: Bainian Liu <bainian12345@hotmail.com>
Co-authored-by: bailiu <bailiu@microsoft.com>
Co-authored-by: Jesus Aguilar <3589801+giventocode@users.noreply.github.com>
Co-authored-by: microsoft-github-policy-service[bot] <77245923+microsoft-github-policy-service[bot]@users.noreply.github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Copilot <198982749+Copilot@users.noreply.github.com>
Co-authored-by: Todd Venhaus <tvenhaus@gmail.com>

---------

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: Bainian Liu <bainian12345@hotmail.com>
Co-authored-by: bailiu <bailiu@microsoft.com>
Co-authored-by: Jesus Aguilar <3589801+giventocode@users.noreply.github.com>
Co-authored-by: Todd Venhaus <tvenhaus@gmail.com>
Co-authored-by: microsoft-github-policy-service[bot] <77245923+microsoft-github-policy-service[bot]@users.noreply.github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Copilot <198982749+Copilot@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@bainian12345 bainian12345 bainian12345 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@giventocode @bainian12345