Update codeowners for Microsoft.Azure.ServiceBus #23654
Conversation
Adding @shankarsama and @DorothySun216 as code owners for the Microsoft.Azure.ServiceBus package. This will result in 2 things - All PRs to this package will add the above two folks as code reviewers automatically - Test failure notifications for this package will go to the emails of the above two folks
|
This pull request is protected by Check Enforcer. What is Check Enforcer?Check Enforcer helps ensure all pull requests are covered by at least one check-run (typically an Azure Pipeline). When all check-runs associated with this pull request pass then Check Enforcer itself will pass. Why am I getting this message?You are getting this message because Check Enforcer did not detect any check-runs being associated with this pull request within five minutes. This may indicate that your pull request is not covered by any pipelines and so Check Enforcer is correctly blocking the pull request being merged. What should I do now?If the check-enforcer check-run is not passing and all other check-runs associated with this PR are passing (excluding license-cla) then you could try telling Check Enforcer to evaluate your pull request again. You can do this by adding a comment to this pull request as follows: What if I am onboarding a new service?Often, new services do not have validation pipelines associated with them. In order to bootstrap pipelines for a new service, please perform following steps: For data-plane/track 2 SDKs Issue the following command as a pull request comment:
For track 1 management-plane SDKsPlease open a separate PR and to your service SDK path in this file. Once that PR has been merged, you can re-run the pipeline to trigger the verification. |
|
/check-enforcer override |
|
I've also updated the bot rules to reflect this change. |
|
|
||
| # ServiceLabel: %Service Bus %Service Attention | ||
| /sdk/servicebus/Microsoft.Azure.ServiceBus/ @axisc | ||
| /sdk/servicebus/Microsoft.Azure.ServiceBus/ @shankarsama @DorothySun216 |
There was a problem hiding this comment.
Unfortunately this change will not split of the test notifications because that is based on the yml file path. If you want those to be unique you would need to add another entry with a full path to the yml file like:
/sdk/servicebus/tests.data.yml @shankarsama @DorothySun216
There was a problem hiding this comment.
@jsquire confirmed that the notifications are indeed split for Event Hubs where they used this model and not the full path
azure-sdk-for-net/.github/CODEOWNERS
Lines 294 to 307 in b33567b
There was a problem hiding this comment.
The code owners are probably split up correctly but the pipeline notifications I don't believe are split up as you expect.
Track 1 (i.e. tests.data.yml) DevOps notification group:
net - servicebus - tests.data
vs
Track 2 (i.e. tests.yml) DevOps notification group:
net - servicebus - tests
They both only contain Jesse and Josh. If you want the other owners for the different pipelines you will have to fully specify the path to the yml file given they are in the same root directory.
There was a problem hiding this comment.
Thanks @weshaggard! Created #23663
There was a problem hiding this comment.
Interesting; I haven't been receiving notifications for Event Hubs T1 tests since we split them, but have continued to receive the T2 notifications. Does this mean that nobody is receiving the T1 notifications, I wonder?
There was a problem hiding this comment.
Until #23663 when in I was showing that you should have been getting T1 (net - eventhub - tests.data) notifications but after that change it only has the new entries.
There was a problem hiding this comment.
That's curious. I haven't been seeing them and confirmed they're not going to Junk or being caught by rules.
Adding @shankarsama and @DorothySun216 as code owners for the Microsoft.Azure.ServiceBus package.
This will result in 2 things