Skip to content

Update codeowners for Microsoft.Azure.ServiceBus #23654

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 30, 2021
Merged

Update codeowners for Microsoft.Azure.ServiceBus #23654

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/CODEOWNERS
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -543,7 +543,7 @@ sdk/trafficmanager/Microsoft.Azure.Management.TrafficManager/ @tmsupp
/sdk/servicebus/Microsoft.Azure.WebJobs.Extensions.ServiceBus/ @pakrym @JoshLove-msft @jsquire

# ServiceLabel: %Service Bus %Service Attention
/sdk/servicebus/Microsoft.Azure.ServiceBus/ @axisc
/sdk/servicebus/Microsoft.Azure.ServiceBus/ @shankarsama @DorothySun216
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unfortunately this change will not split of the test notifications because that is based on the yml file path. If you want those to be unique you would need to add another entry with a full path to the yml file like:

/sdk/servicebus/tests.data.yml       @shankarsama @DorothySun216

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jsquire confirmed that the notifications are indeed split for Event Hubs where they used this model and not the full path

azure-sdk-for-net/.github/CODEOWNERS

Lines 294 to 307 in b33567b

# PRLabel: %Event Hubs
/sdk/eventhub/ @serkantkaraca @jsquire
# PRLabel: %Event Hubs %Functions
/sdk/eventhub/Microsoft.Azure.WebJobs.Extensions.EventHubs/ @pakrym @JoshLove-msft @jsquire
# ServiceLabel: %Event Hubs %Service Attention
/sdk/eventhub/Microsoft.Azure.EventHubs/ @serkantkaraca @sjkwak @kasun04
# ServiceLabel: %Event Hubs %Service Attention
/sdk/eventhub/Microsoft.Azure.EventHubs.Processor/ @serkantkaraca @sjkwak @kasun04
# ServiceLabel: %Event Hubs %Service Attention
/sdk/eventhub/Microsoft.Azure.EventHubs.ServiceFabricProcessor/ @JamesBirdsall @serkantkaraca @sjkwak

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code owners are probably split up correctly but the pipeline notifications I don't believe are split up as you expect.

Track 1 (i.e. tests.data.yml) DevOps notification group:
net - servicebus - tests.data

vs

Track 2 (i.e. tests.yml) DevOps notification group:
net - servicebus - tests

They both only contain Jesse and Josh. If you want the other owners for the different pipelines you will have to fully specify the path to the yml file given they are in the same root directory.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @weshaggard! Created #23663

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interesting; I haven't been receiving notifications for Event Hubs T1 tests since we split them, but have continued to receive the T2 notifications. Does this mean that nobody is receiving the T1 notifications, I wonder?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Until #23663 when in I was showing that you should have been getting T1 (net - eventhub - tests.data) notifications but after that change it only has the new entries.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's curious. I haven't been seeing them and confirmed they're not going to Junk or being caught by rules.


# ServiceLabel: %Service Fabric %Service Attention
/sdk/servicefabric/Microsoft.Azure.Management.ServiceFabric/ @QingChenmsft @vaishnavk @juhacket
Expand Down