Make DeviceCodeCredential client_id parameter optional#14474
Merged
chlowell merged 3 commits intoAzure:masterfrom Oct 20, 2020
Merged
Make DeviceCodeCredential client_id parameter optional#14474chlowell merged 3 commits intoAzure:masterfrom
chlowell merged 3 commits intoAzure:masterfrom
Conversation
chlowell
added
Client
mccoyp
approved these changes
Oct 19, 2020
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This makes DeviceCodeCredential's client_id parameter optional, to align with other Azure SDKs. Most of the diff is renaming the default client ID constant. Using that constant in a public signature makes it visible to callers, so I took this opportunity to give it a more future proof name.