[Key Vault] Test keys library against managed HSM #17458
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mccoyp
added
KeyVault
Client
chlowell
reviewed
Mar 23, 2021
sdk/keyvault/azure-keyvault-keys/tests/test_crypto_client_async.py
Outdated
Show resolved
Hide resolved
chlowell
reviewed
Mar 25, 2021
chlowell
reviewed
Mar 26, 2021
chlowell
approved these changes
Mar 29, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #13716.
This uses parameterized tests to run each applicable keys test against both Key Vault and Managed HSM, creating a recording for each. It also adds a platform to pipeline keys tests with
enableHsm = $true, resulting in a single test run against MHSM.