-
Notifications
You must be signed in to change notification settings - Fork 3.2k
Update sample readme slug #18009
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update sample readme slug #18009
Conversation
| products: | ||
| - azure | ||
| - azure-identity | ||
| - azure-sdks |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
JS uses azure-active-directory here. Would it make sense to use the same?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would that cause these samples to show up in Azure AD documentation?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@witemple-msft do you know?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Answered my own question: it does, in the samples browser at least. At first glance I'm thinking our samples shouldn't be grouped with Azure Active Directory samples. This library uses Azure AD but is narrowly focused on authenticating Azure SDK clients. Our samples are poor demonstrations of Azure AD features and in general just noise for people not using the SDK.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Where would someone expect to find the identity SDK samples in the microsoft docs?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For example, in form recognizer, our MS docs menu has a drop down for "Samples" where our samples readme gets published: https://docs.microsoft.com/en-us/azure/cognitive-services/form-recognizer/overview?tabs=v2-1
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Authentication is covered in the SDK conceptual docs. As for the sample browser, the taxonomy is ordered by product, so I think azure-identity samples belong under azure (though I think that's too broad a category to be really useful) and azure-sdks.
| - python | ||
| products: | ||
| - azure | ||
| - azure-identity |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is an identity tag necessary for these to show up with Identity samples?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe so but question whether we want these samples to show up there. Today there's no "there" there; the sample browser has nothing for "identity". The sample browser covers products outside Azure, so not knowing the intended scope of "identity", I'm reluctant to make our samples the only ones in that category.
Closes #17994