Skip to content

Conversation

@chlowell
Copy link
Member

Closes #17994

products:
- azure
- azure-identity
- azure-sdks
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

JS uses azure-active-directory here. Would it make sense to use the same?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would that cause these samples to show up in Azure AD documentation?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@witemple-msft do you know?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Answered my own question: it does, in the samples browser at least. At first glance I'm thinking our samples shouldn't be grouped with Azure Active Directory samples. This library uses Azure AD but is narrowly focused on authenticating Azure SDK clients. Our samples are poor demonstrations of Azure AD features and in general just noise for people not using the SDK.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Where would someone expect to find the identity SDK samples in the microsoft docs?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For example, in form recognizer, our MS docs menu has a drop down for "Samples" where our samples readme gets published: https://docs.microsoft.com/en-us/azure/cognitive-services/form-recognizer/overview?tabs=v2-1

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Authentication is covered in the SDK conceptual docs. As for the sample browser, the taxonomy is ordered by product, so I think azure-identity samples belong under azure (though I think that's too broad a category to be really useful) and azure-sdks.

- python
products:
- azure
- azure-identity
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is an identity tag necessary for these to show up with Identity samples?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe so but question whether we want these samples to show up there. Today there's no "there" there; the sample browser has nothing for "identity". The sample browser covers products outside Azure, so not knowing the intended scope of "identity", I'm reluctant to make our samples the only ones in that category.

@chlowell chlowell merged commit 4c6112b into Azure:master Apr 15, 2021
@chlowell chlowell deleted the slugs branch April 15, 2021 20:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[identity] update sample slug in sample README

3 participants