[formrecognizer] Refactor DAC tests into separate files #21968
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
catalinaperalta
force-pushed
the
mq/refactorTests
branch
from
04baf45 to
d02d55c
Compare
catalinaperalta
changed the title
catalinaperalta
requested review from
iscai-msft and
kristapratico
as code owners
kristapratico
approved these changes
Dec 9, 2021
Contributor
kristapratico
left a comment
kristapratico
left a comment
There was a problem hiding this comment.
yay LGTM! this feels a lot cleaner ✨
hildurhodd
pushed a commit
to hildurhodd/azure-sdk-for-python
that referenced
this pull request
Jan 4, 2022
* refactor async prebuilt analyze tests * clean up refactored tests and recordings * refactor async url analyze prebuilt tests * add recordings for async url tests * refactor sync prebuilt analyze tests * add new recordings, delete old ones * refactor sync analyze prebuilt from url tests * add new url test recordings and delete old ones * remove unused imports * rename general document and layout tests * update general document and layout recordings * refactor custom documents tests, update recordings
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR refactors DAC tests into separate files, a separate PR will separate DMAC tests.
Part of #20862, #20849 these issues will be closed in the DMAC tests PR.
Part of #16689 : the omnibus methods have greatly helped in reducing redundant tests that previously existed for all prebuilt verticals, also previous PRs some redundant tests from the v2.1 test set.
Pending issues: #22025