ACS Rooms public preview changes for Python SDK #25554
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add files needed for new rooms python sdk. As right now there is no api review accepted, add swagger file directly to the swagger folder. Added README.md in swagger directory to list options needed to run autorest for update.
Add new apis for add and remove participants
Add new update role tests.
Python Room SDK: All Changes For Rooms Until Now
Related work items: 2812274, 2866897 Updating with the new RoomJoinPolicy for open/closed rooms. Adding new generated files for the room join policy. Adding changes for open rooms. Fixing imports. Updating to using generated enum. Adjusting the imports.
ghost
added
the
Collaborator
|
API change check APIView has identified API level changes in this PR and created following API reviews. |
fix spelling and dependency for pipeline checks
annatisch
requested changes
Aug 5, 2022
sdk/communication/azure-communication-rooms/azure/communication/rooms/_rooms_client.py
Outdated
Show resolved
Hide resolved
sdk/communication/azure-communication-rooms/azure/communication/rooms/_rooms_client.py
Outdated
Show resolved
Hide resolved
sdk/communication/azure-communication-rooms/azure/communication/rooms/_version.py
Outdated
Show resolved
Hide resolved
sdk/communication/azure-communication-rooms/samples/rooms_client_sample.py
Outdated
Show resolved
Hide resolved
address pr review comments
add file and docs for pipeline check
fix spelling and sdlist
annatisch
reviewed
Aug 8, 2022
sdk/communication/azure-communication-rooms/azure/communication/rooms/__init__.py
Show resolved
Hide resolved
sdk/communication/azure-communication-rooms/azure/communication/rooms/_rooms_client.py
Outdated
Show resolved
Hide resolved
sdk/communication/azure-communication-rooms/azure/communication/rooms/_rooms_client.py
Outdated
Show resolved
Hide resolved
minor fix for versions and error message
Member
|
/azp run python - azure-communication-rooms - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
annatisch
approved these changes
Aug 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
ACS Rooms public preview changes for Python SDK
All SDK Contribution checklist:
General Guidelines and Best Practices
Testing Guidelines