Skip to content

Conversation

@rads-1996
Copy link
Member

@rads-1996 rads-1996 commented Jan 27, 2026

Description

Feature tracking for when customer sdkstats is disabled by the user

All SDK Contribution checklist:

  • The pull request does not introduce [breaking changes]
  • CHANGELOG is updated for new features, bug fixes or other significant changes.
  • I have read the contribution guidelines.

General Guidelines and Best Practices

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

@github-actions github-actions bot added the Monitor - Exporter Monitor OpenTelemetry Exporter label Jan 27, 2026
@rads-1996 rads-1996 force-pushed the set_feature_tracking_when_customer_sdkstats_disabled branch from 3c6e93e to 275e343 Compare January 28, 2026 20:36
@rads-1996 rads-1996 marked this pull request as ready for review January 28, 2026 21:17
Copilot AI review requested due to automatic review settings January 28, 2026 21:17
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR aims to add feature tracking for customer sdkstats when it is disabled by the user. The changes move the call to set_statsbeat_customer_sdkstats_feature_set() from the initialization path (when enabled) to the constructor path (when disabled).

Changes:

  • Moved set_statsbeat_customer_sdkstats_feature_set() call from collect_customer_sdkstats() to CustomerSdkStatsManager.__init__() when status is DISABLED
  • Removed the import and function call from _customer_sdkstats.py
  • Updated CHANGELOG with formatting fixes and new entry

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.

File Description
sdk/monitor/azure-monitor-opentelemetry-exporter/azure/monitor/opentelemetry/exporter/statsbeat/customer/_manager.py Added import for set_statsbeat_customer_sdkstats_feature_set and calls it when customer sdkstats is disabled
sdk/monitor/azure-monitor-opentelemetry-exporter/azure/monitor/opentelemetry/exporter/statsbeat/customer/_customer_sdkstats.py Removed the import and call to set_statsbeat_customer_sdkstats_feature_set
sdk/monitor/azure-monitor-opentelemetry-exporter/CHANGELOG.md Added entry for this feature change and fixed formatting inconsistencies

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

@rads-1996 rads-1996 merged commit 027c885 into Azure:main Jan 29, 2026
21 checks passed
@rads-1996 rads-1996 deleted the set_feature_tracking_when_customer_sdkstats_disabled branch January 29, 2026 17:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Monitor - Exporter Monitor OpenTelemetry Exporter

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants