-
Notifications
You must be signed in to change notification settings - Fork 3.2k
Feature tracking for when customer sdkstats is disabled by the user #44888
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature tracking for when customer sdkstats is disabled by the user #44888
Conversation
3c6e93e to
275e343
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR aims to add feature tracking for customer sdkstats when it is disabled by the user. The changes move the call to set_statsbeat_customer_sdkstats_feature_set() from the initialization path (when enabled) to the constructor path (when disabled).
Changes:
- Moved
set_statsbeat_customer_sdkstats_feature_set()call fromcollect_customer_sdkstats()toCustomerSdkStatsManager.__init__()when status is DISABLED - Removed the import and function call from
_customer_sdkstats.py - Updated CHANGELOG with formatting fixes and new entry
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| sdk/monitor/azure-monitor-opentelemetry-exporter/azure/monitor/opentelemetry/exporter/statsbeat/customer/_manager.py | Added import for set_statsbeat_customer_sdkstats_feature_set and calls it when customer sdkstats is disabled |
| sdk/monitor/azure-monitor-opentelemetry-exporter/azure/monitor/opentelemetry/exporter/statsbeat/customer/_customer_sdkstats.py | Removed the import and call to set_statsbeat_customer_sdkstats_feature_set |
| sdk/monitor/azure-monitor-opentelemetry-exporter/CHANGELOG.md | Added entry for this feature change and fixed formatting inconsistencies |
...r-opentelemetry-exporter/azure/monitor/opentelemetry/exporter/statsbeat/customer/_manager.py
Show resolved
Hide resolved
...metry-exporter/azure/monitor/opentelemetry/exporter/statsbeat/customer/_customer_sdkstats.py
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.
Description
Feature tracking for when customer sdkstats is disabled by the user
All SDK Contribution checklist:
General Guidelines and Best Practices