[Storage] Live Tests - self.fail does not exist#45003
Merged
weirongw23-msft merged 1 commit intoAzure:mainfrom Feb 5, 2026
Merged
[Storage] Live Tests - self.fail does not exist#45003weirongw23-msft merged 1 commit intoAzure:mainfrom
self.fail does not exist#45003weirongw23-msft merged 1 commit intoAzure:mainfrom
Conversation
weirongw23-msft
requested review from
annatisch,
jalauzon-msft and
vincenttran-msft
as code owners
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes failing live tests by replacing self.fail(...) (not available on these pytest-style test classes) with pytest.fail(...).
Changes:
- Update async file copy polling helper to use
pytest.failon timeout. - Update sync file copy polling helper to use
pytest.failon timeout.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| sdk/storage/azure-storage-file-share/tests/test_file_async.py | Use pytest.fail(...) instead of self.fail(...) in async copy wait helper. |
| sdk/storage/azure-storage-file-share/tests/test_file.py | Use pytest.fail(...) instead of self.fail(...) in sync copy wait helper. |
jalauzon-msft
approved these changes
Feb 5, 2026
Member
Author
|
/check-enforcer override |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.