[ContentUnderstanding] Precise page number assertions in content range tests#45793
Merged
changjian-wang merged 2 commits intochangjian-wang/add-contentrange-samples-doc-audio-videofrom Mar 19, 2026
Conversation
…_content_range Co-authored-by: changjian-wang <15209050+changjian-wang@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] [ContentUnderstanding] Add ContentRange samples for document, video, and audio
[ContentUnderstanding] Precise page number assertions in content range tests
Mar 19, 2026
changjian-wang
approved these changes
Mar 19, 2026
0a2a6c3
into
changjian-wang/add-contentrange-samples-doc-audio-video
6 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Content range assertions in
test_sample_analyze_binary.pywere too loose — checking> 0or>= 2instead of exact counts, and not verifying which pages were actually extracted.Changes
assert ==for all content range scenarios ("3-"→full_page_count - 2,"1-3,5,9-"→full_page_count - 4,"1,3-4"→3)page_numberfrom each returned page, compare against expected list (e.g.,"1-3"→[1, 2, 3],"1,3-4"→[1, 3, 4])start_page_number/end_page_numberonDocumentContentfor all range scenarios🔒 GitHub Advanced Security automatically protects Copilot coding agent pull requests. You can protect all pull requests by enabling Advanced Security for your repositories. Learn more about Advanced Security.