Skip to content

Sync eng/common directory with azure-sdk-tools for PR 14973#46199

Merged
azure-sdk merged 2 commits into
mainfrom
sync-eng/common-storage/supportSoftDeletedBlobsDuringResourceCleanup-14973
Apr 14, 2026
Merged

Sync eng/common directory with azure-sdk-tools for PR 14973#46199
azure-sdk merged 2 commits into
mainfrom
sync-eng/common-storage/supportSoftDeletedBlobsDuringResourceCleanup-14973

Conversation

@azure-sdk
Copy link
Copy Markdown
Collaborator

Sync eng/common directory with azure-sdk-tools for PR Azure/azure-sdk-tools#14973 See eng/common workflow

@azure-sdk azure-sdk requested a review from ibrandes April 8, 2026 18:40
@azure-sdk azure-sdk requested a review from a team as a code owner April 8, 2026 18:40
@azure-sdk azure-sdk added EngSys This issue is impacting the engineering system. Central-EngSys This issue is owned by the Engineering System team. labels Apr 8, 2026
Copilot AI review requested due to automatic review settings April 8, 2026 18:40
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Note

Copilot was unable to run its full agentic suite in this review.

Syncs eng/common with changes from azure-sdk-tools PR 14973, improving storage account cleanup by adding version-aware deletion for VLW (versioned immutable) blob containers so containers can be deleted successfully.

Changes:

  • Adds VLW-container detection during storage account cleanup and routes those containers through specialized cleanup.
  • Introduces Remove-VlwContainerBlobs to delete soft-deleted blobs and non-current versions (including clearing legal hold / immutability policy).
  • Adds inline documentation explaining why standard blob listing doesn’t unblock container deletion in VLW scenarios.

Comment thread eng/common/scripts/Helpers/Resource-Helpers.ps1
Comment thread eng/common/scripts/Helpers/Resource-Helpers.ps1
Comment thread eng/common/scripts/Helpers/Resource-Helpers.ps1
Comment thread eng/common/scripts/Helpers/Resource-Helpers.ps1
@azure-sdk azure-sdk force-pushed the sync-eng/common-storage/supportSoftDeletedBlobsDuringResourceCleanup-14973 branch from c4b3abc to 912251e Compare April 13, 2026 17:17
ibrandes and others added 2 commits April 13, 2026 18:31
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@azure-sdk azure-sdk force-pushed the sync-eng/common-storage/supportSoftDeletedBlobsDuringResourceCleanup-14973 branch from 912251e to 55d3bea Compare April 13, 2026 18:31
@azure-sdk azure-sdk merged commit e47d04b into main Apr 14, 2026
16 checks passed
@azure-sdk azure-sdk deleted the sync-eng/common-storage/supportSoftDeletedBlobsDuringResourceCleanup-14973 branch April 14, 2026 19:26
fafhrd91 pushed a commit to fafhrd91/azure-sdk-for-python that referenced this pull request Apr 28, 2026
)

* adding support for soft deleted blobs and blob versions during resource cleanup

* Apply suggestions from code review

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

---------

Co-authored-by: Isabelle <ibrandes@microsoft.com>
Co-authored-by: Isabelle <141270045+ibrandes@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Central-EngSys This issue is owned by the Engineering System team. EngSys This issue is impacting the engineering system.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants