Skip to content

cibuildwheel not necessary in build-system metadata for azure-storage-extensions#46226

Merged
scbedd merged 4 commits intomainfrom
copilot/update-dev-requirements-txt
Apr 10, 2026
Merged

cibuildwheel not necessary in build-system metadata for azure-storage-extensions#46226
scbedd merged 4 commits intomainfrom
copilot/update-dev-requirements-txt

Conversation

Copy link
Copy Markdown
Contributor

Copilot AI commented Apr 9, 2026

  • Root cause identified and analyzed
  • Fix in c7f2f57f: removed cibuildwheel from [build-system].requires
  • Build 6132226 used OLD code (checkout of 01f1e62b4a before fix) — CI race condition
  • Forced new CI build with clarifying comment in pyproject.toml

Copilot AI requested a review from scbedd April 9, 2026 17:32
@scbedd scbedd changed the title Touch dev_requirements.txt for azure-storage-extensions cibuildwheel not necessary in build-system metadata for azure-storage-extensions Apr 9, 2026
…system dep (forces new CI run)

Agent-Logs-Url: https://github.com/Azure/azure-sdk-for-python/sessions/663065b9-1da4-4b14-a932-3e518854a48f

Co-authored-by: scbedd <45376673+scbedd@users.noreply.github.com>
Comment thread sdk/storage/azure-storage-extensions/dev_requirements.txt Outdated
@scbedd scbedd marked this pull request as ready for review April 9, 2026 20:08
Copilot AI review requested due to automatic review settings April 9, 2026 20:08
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Removes cibuildwheel from the azure-storage-extensions build-system requirements to reflect that it’s an external wheel-building orchestrator rather than a PEP 517 build dependency, and documents the rationale inline.

Changes:

  • Dropped cibuildwheel from [build-system].requires.
  • Added an explanatory comment clarifying cibuildwheel’s role as an outer orchestration tool.
Show a summary per file
File Description
sdk/storage/azure-storage-extensions/pyproject.toml Removes cibuildwheel from build requirements and documents why.

Copilot's findings

  • Files reviewed: 1/1 changed files
  • Comments generated: 0

@scbedd scbedd merged commit 36cbc4b into main Apr 10, 2026
29 checks passed
@scbedd scbedd deleted the copilot/update-dev-requirements-txt branch April 10, 2026 17:30
tendau pushed a commit that referenced this pull request Apr 13, 2026
…orage-extensions` (#46226)

* Add extra line to dev_requirements.txt to trigger build

* Fix macOS build failure: remove cibuildwheel from build-system.requires

Agent-Logs-Url: https://github.com/Azure/azure-sdk-for-python/sessions/809a13fb-9b10-4e29-803b-aa41cf835a2b

Co-authored-by: scbedd <45376673+scbedd@users.noreply.github.com>

* Add comment to pyproject.toml to clarify cibuildwheel is not a build-system dep (forces new CI run)

Agent-Logs-Url: https://github.com/Azure/azure-sdk-for-python/sessions/663065b9-1da4-4b14-a932-3e518854a48f

Co-authored-by: scbedd <45376673+scbedd@users.noreply.github.com>

* Apply suggestion from @scbedd

Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: scbedd <45376673+scbedd@users.noreply.github.com>
fafhrd91 pushed a commit to fafhrd91/azure-sdk-for-python that referenced this pull request Apr 28, 2026
…orage-extensions` (Azure#46226)

* Add extra line to dev_requirements.txt to trigger build

* Fix macOS build failure: remove cibuildwheel from build-system.requires

Agent-Logs-Url: https://github.com/Azure/azure-sdk-for-python/sessions/809a13fb-9b10-4e29-803b-aa41cf835a2b

Co-authored-by: scbedd <45376673+scbedd@users.noreply.github.com>

* Add comment to pyproject.toml to clarify cibuildwheel is not a build-system dep (forces new CI run)

Agent-Logs-Url: https://github.com/Azure/azure-sdk-for-python/sessions/663065b9-1da4-4b14-a932-3e518854a48f

Co-authored-by: scbedd <45376673+scbedd@users.noreply.github.com>

* Apply suggestion from @scbedd

Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: scbedd <45376673+scbedd@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants