Ensure that failures during pyright invocation are properly surfaced in verifytypes#46418
Draft
Ensure that failures during pyright invocation are properly surfaced in verifytypes#46418
pyright invocation are properly surfaced in verifytypes#46418Conversation
…tion within verifytypes
Contributor
There was a problem hiding this comment.
Pull request overview
This PR improves the robustness of the azpysdk verifytypes flow by ensuring pyright --verifytypes failures that don’t emit valid JSON are clearly logged and treated as a failure, rather than causing an unhandled JSON parsing exception.
Changes:
- Guard
json.loads(e.output)inverifytypesto handle non-JSON/empty output and surface stdout/stderr in logs. - Fix incorrect
logger.error(..., e)usage during dev requirements installation so the exception is properly included in the log message.
Show a summary per file
| File | Description |
|---|---|
eng/tools/azure-sdk-tools/azpysdk/verifytypes.py |
Adds error handling for invalid/missing JSON output from pyright --verifytypes on return code 1. |
eng/tools/azure-sdk-tools/azpysdk/Check.py |
Fixes exception logging for dev requirements installation failures. |
Copilot's findings
- Files reviewed: 2/2 changed files
- Comments generated: 1
| except subprocess.CalledProcessError as e: | ||
| logger.error("Failed to install dev requirements:", e) | ||
| logger.error(f"Failed to install dev requirements: {e}") | ||
| raise e |
There was a problem hiding this comment.
In this exception handler, raise e will re-raise the exception with a new traceback and can hide where the CalledProcessError actually originated. Use a bare raise (and optionally logger.exception(...) if you want the traceback in logs) to preserve the original traceback/context.
Suggested change
| raise e | |
| raise |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Working through a
transcriptionfailure.