Use constants to decide distro version in the exporter#46613
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the exporter’s internal SDK version string generation so it can report different “distribution” identifiers based on standardized environment variable names, and adds unit tests covering the new formatting/priority rules.
Changes:
- Add SDK-version-related environment variable constants and use them in
_utils._get_sdk_version(). - Extend
_get_sdk_version()formatting to emitmot(Microsoft OpenTelemetry) ordst(Azure Monitor distro) when corresponding env vars are present, withmottaking priority. - Add unit tests to validate default, distro, Microsoft OTel, and priority behaviors.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| sdk/monitor/azure-monitor-opentelemetry-exporter/tests/test_utils.py | Adds coverage for _get_sdk_version() across default/distro/Microsoft OTel scenarios and priority behavior. |
| sdk/monitor/azure-monitor-opentelemetry-exporter/azure/monitor/opentelemetry/exporter/_utils.py | Implements env-var-driven SDK version string variants and prioritization logic. |
| sdk/monitor/azure-monitor-opentelemetry-exporter/azure/monitor/opentelemetry/exporter/_constants.py | Introduces constants for SDK-version environment variable names. |
70e99f4 to
71dc561
Compare
lzchen
approved these changes
May 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Populate the different distro names based on the naming convention.
All SDK Contribution checklist:
General Guidelines and Best Practices
Testing Guidelines