Skip to content

Sync eng/common directory with azure-sdk-tools for PR 15454#46702

Merged
scbedd merged 2 commits intomainfrom
sync-eng/common-adjust-login-15454
May 4, 2026
Merged

Sync eng/common directory with azure-sdk-tools for PR 15454#46702
scbedd merged 2 commits intomainfrom
sync-eng/common-adjust-login-15454

Conversation

@azure-sdk
Copy link
Copy Markdown
Collaborator

Sync eng/common directory with azure-sdk-tools for PR Azure/azure-sdk-tools#15454 See eng/common workflow

Copilot AI review requested due to automatic review settings May 4, 2026 19:45
@azure-sdk azure-sdk requested a review from a team as a code owner May 4, 2026 19:45
@azure-sdk azure-sdk requested a review from scbedd May 4, 2026 19:45
@azure-sdk azure-sdk added EngSys This issue is impacting the engineering system. Central-EngSys This issue is owned by the Engineering System team. labels May 4, 2026
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the shared eng/common PR automation templates to use owner-specific GitHub App tokens when creating PRs across different owners/orgs. This fits the repo’s shared engineering infrastructure by keeping the synced pipeline templates aligned with the newer login-to-github token behavior.

Changes:

  • Switches git-push-changes.yml to mint the GitHub token for the fork/base repo owner that receives the push.
  • Updates create-pull-request.yml to request tokens for both the push owner and target repo owner.
  • Routes push and PR creation steps to the correct owner-specific GH_TOKEN_<Owner> variable when auto-login is used.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
eng/common/pipelines/templates/steps/git-push-changes.yml Adjusts auto-login to request the token for the repo owner that the branch is pushed to.
eng/common/pipelines/templates/steps/create-pull-request.yml Adds multi-owner token acquisition and uses owner-specific token variables for push vs. PR API calls.

@scbedd scbedd merged commit 98dc152 into main May 4, 2026
24 checks passed
@scbedd scbedd deleted the sync-eng/common-adjust-login-15454 branch May 4, 2026 20:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Central-EngSys This issue is owned by the Engineering System team. EngSys This issue is impacting the engineering system.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants