Skip to content

Sync eng/common directory with azure-sdk-tools for PR 15475#46706

Merged
azure-sdk merged 2 commits intomainfrom
sync-eng/common-masalama/fixPurgeDateBug-15475
May 5, 2026
Merged

Sync eng/common directory with azure-sdk-tools for PR 15475#46706
azure-sdk merged 2 commits intomainfrom
sync-eng/common-masalama/fixPurgeDateBug-15475

Conversation

@azure-sdk
Copy link
Copy Markdown
Collaborator

Sync eng/common directory with azure-sdk-tools for PR Azure/azure-sdk-tools#15475 See eng/common workflow

Copilot AI review requested due to automatic review settings May 4, 2026 21:42
@azure-sdk azure-sdk requested a review from a team as a code owner May 4, 2026 21:42
@azure-sdk azure-sdk requested a review from msalaman May 4, 2026 21:42
@azure-sdk azure-sdk added EngSys This issue is impacting the engineering system. Central-EngSys This issue is owned by the Engineering System team. labels May 4, 2026
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR syncs eng/common with the corresponding azure-sdk-tools change and adjusts purge-protection logging in the shared resource cleanup helper so it no longer assumes ScheduledPurgeDate is always present.

Changes:

  • Builds the purge-protection message incrementally for deleted Key Vaults.
  • Builds the purge-protection message incrementally for deleted Managed HSMs.
  • Adds a fallback message path when ScheduledPurgeDate is missing.

Comment thread eng/common/scripts/Helpers/Resource-Helpers.ps1
Comment thread eng/common/scripts/Helpers/Resource-Helpers.ps1
@azure-sdk azure-sdk merged commit 716d895 into main May 5, 2026
24 checks passed
@azure-sdk azure-sdk deleted the sync-eng/common-masalama/fixPurgeDateBug-15475 branch May 5, 2026 23:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Central-EngSys This issue is owned by the Engineering System team. EngSys This issue is impacting the engineering system.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants