[typespec-python] Push regenerated tests to dedicated branch#46995
Merged
Conversation
iscai-msft
requested review from
a team,
ChenxiJiang333,
benbp,
l0lawrence,
lirenhe,
lmazuel,
msyyc and
tadelesh
as code owners
Contributor
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
This PR updates the TypeSpec Python regeneration workflow to push regenerated test artifacts directly to a dedicated branch (typespec-python-generated-tests) rather than creating tracking issues/PRs against main, and updates documentation accordingly.
Changes:
- Update
typespec-python-regenerate.ymlto commit and force-push generated files directly totypespec-python-generated-tests(removing PR/issue creation logic andpull-requests: writepermission). - Update emitter docs to clarify generated output is stored on the dedicated branch, not
main. - Update skill documentation to reference the dedicated branch and revised failure behavior.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
.github/workflows/typespec-python-regenerate.yml |
Switch regeneration output publishing from PR/issue flow to direct pushes to typespec-python-generated-tests. |
eng/tools/emitter/README.md |
Document that gen/ output lives on the dedicated branch and is force-pushed by automation. |
eng/tools/emitter/gen/README.md |
Add prominent note that generated files live on the dedicated branch and update regeneration description. |
.github/skills/emitter-package-update/SKILL.md |
Update training docs to reference the new dedicated branch approach. |
iscai-msft
force-pushed
the
move-regen-to-dedicated-branch
branch
from
961edb1 to
a5858d4
Compare
iscai-msft
force-pushed
the
move-regen-to-dedicated-branch
branch
from
a5858d4 to
f58958e
Compare
…path Update the regeneration workflow to: - Push generated test files to eng/tools/azure-sdk-tools/emitter/generated/ on the 'typespec-python-generated-tests' branch (instead of creating PRs to main at eng/tools/emitter/gen/) - Remove tracking issue creation and PR-related steps - Remove pull-requests permission (no longer needed) Also updates READMEs, emitter docs, and skill docs to reference the new branch and path. The eng/tools/emitter/ folder will be fully removed in a follow-up PR. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
iscai-msft
force-pushed
the
move-regen-to-dedicated-branch
branch
from
f73ea47 to
76955c3
Compare
l0lawrence
approved these changes
May 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Update the regeneration workflow to push generated test files directly to the
typespec-python-generated-testsbranch instead of creating tracking issues/PRs targetingmain. This avoids false security reports triggered by generated code on the default branch.Changes
typespec-python-regenerate.yml): Push directly totypespec-python-generated-testsbranch using--force-with-lease, removing all PR/issue creation logicpull-requests: writepermission (no longer needed)eng/tools/emitter/README.md,eng/tools/emitter/gen/README.md, and.github/skills/emitter-package-update/SKILL.mdto reference the new branchtypespec-python-generated-testsbranch will be created automatically on the first workflow run after this PR mergesWhat's next\n\nAfter this PR merges, a follow-up PR will remove the generated files (
eng/tools/emitter/gen/azureandeng/tools/emitter/gen/unbranded) frommain. They will only exist on the dedicated branch going forward.