Reduce PR test matrix to python 2.7, 3.5 and 3.8#9031
Merged
Conversation
scbedd
previously approved these changes
Dec 6, 2019
Member
Author
|
@weshaggard : I have updated this PR as per your suggestion to create test matrix within one yml itself. |
scbedd
approved these changes
Dec 6, 2019
weshaggard
reviewed
Dec 6, 2019
| OSVmImage: 'ubuntu-16.04' | ||
| PythonVersion: '3.6' | ||
| CoverageArg: '' | ||
| RunForPR: false |
Member
There was a problem hiding this comment.
Not that it matters too much but can we get away with out listing the CoverageARg and RunForPr = false entries? It would help cut down on the size of this matrix table.
weshaggard
reviewed
Dec 6, 2019
| @@ -1 +1 @@ | |||
| -e ../../../tools/azure-sdk-tools No newline at end of file | |||
| -e ../../../tools/azure-sdk-tools | |||
weshaggard
reviewed
Dec 6, 2019
weshaggard
left a comment
weshaggard
left a comment
Member
There was a problem hiding this comment.
Awesome this looks a lot better. I added one comment about potential clean-up if possible.
Member
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR will run test only for 2.7, 3.5 and 3.8
CI and live test will continue to run for all versions as earlier.