Skip to content

Parse App Service MSI responses on Windows#9480

Merged
chlowell merged 4 commits intoAzure:masterfrom
chlowell:app-service-win
Feb 6, 2020
Merged

Parse App Service MSI responses on Windows#9480
chlowell merged 4 commits intoAzure:masterfrom
chlowell:app-service-win

Conversation

@chlowell
Copy link
Copy Markdown
Member

App Service MSI version 2017-09-01 (the latest) returns token expiration times as platform-dependent datetime strings. ManagedIdentityCredential currently works on Linux but not Windows. This adds support for the Windows format.

Fixes #9393

@chlowell chlowell added Client This issue points to a problem in the data-plane of the library. Azure.Identity labels Jan 15, 2020
@chlowell chlowell requested a review from schaabs as a code owner January 15, 2020 22:54
@chlowell chlowell self-assigned this Jan 15, 2020
@chlowell chlowell requested a review from bryevdv January 16, 2020 19:51
bryevdv
bryevdv previously approved these changes Jan 16, 2020
@chlowell chlowell requested a review from xiangyan99 January 22, 2020 20:15
Comment thread sdk/identity/azure-identity/HISTORY.md
Comment thread sdk/identity/azure-identity/azure/identity/_authn_client.py
@chlowell chlowell merged commit 4fdd65b into Azure:master Feb 6, 2020
@chlowell chlowell deleted the app-service-win branch February 6, 2020 21:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Azure.Identity Client This issue points to a problem in the data-plane of the library.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ManagedIdentityCredential cannot parse expires_on from App Service for Windows

3 participants