use configured slurm user and group in init-config.sh#529
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates init-config.sh to write autoscale.json using the configured Slurm service user/group (rather than hard-coding slurm:slurm), so generated config files match deployments that customize the Slurm account.
Changes:
- Read Slurm user/group from jetpack configuration.
- Use those values as the owner/group when installing
autoscale.json.
| Criterion | Max Points | Points Awarded | Notes |
|---|---|---|---|
| PR Description Accuracy | 20 | 0 | No PR description was provided in the metadata. |
| PR Atomicity | 20 | 20 | Single focused change. |
| Logical Implementation | 10 | 10 | Straightforward change. |
| Regression Risk | 10 | 0 | As implemented, set -e + unguarded jetpack calls can break init-config.sh in environments without jetpack / missing keys. |
| Exception Handling | 10 | 0 | No fallback/guarding for missing jetpack/missing config key in the new code path. |
| Code Comments | 10 | 10 | No new comment issues introduced. |
| Repetitive Code | 10 | 10 | No duplication introduced. |
| Spelling | 5 | 5 | No spelling issues noted. |
| Logging Quality | 5 | 5 | No logging changes. |
FINAL SCORE: 60/100
RECOMMENDATION: DO NOT MERGE
RATIONALE: The new jetpack lookups can cause init-config.sh to fail under set -e if jetpack isn’t installed or config keys are missing, and the group key used appears inconsistent with existing usage in this repo.
BLOCKERS:
- Guard jetpack config calls with a safe fallback and use the correct group key (consistent with existing repo usage).
ryanhamel
previously approved these changes
Jun 24, 2026
bwatrous
reviewed
Jun 25, 2026
bwatrous
previously approved these changes
Jun 25, 2026
…lurm user and group
azreenz
force-pushed
the
azreenzaman/autoscale-credentials
branch
from
June 25, 2026 13:38
47556be to
9e10f5c
Compare
ryanhamel
approved these changes
Jun 25, 2026
aditigaur4
approved these changes
Jun 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.