Skip to content

update default os to be ubuntu24 - #540

Merged
Azreen Zaman (azreenz) merged 1 commit into
masterfrom
azreenzaman/bump-default-os
Jul 28, 2026
Merged

update default os to be ubuntu24#540
Azreen Zaman (azreenz) merged 1 commit into
masterfrom
azreenzaman/bump-default-os

Conversation

@azreenz

@azreenz Azreen Zaman (azreenz) commented Jul 27, 2026

Copy link
Copy Markdown
Collaborator

Update each nodearray ImageName to be ubuntu 24 in slurm template.
Screenshot 2026-07-27 164424

Copilot AI review requested due to automatic review settings July 27, 2026 20:49

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the Slurm cluster template’s default OS image to Ubuntu 24.04 by switching the DefaultValue for all node role image parameters from cycle.image.ubuntu22 to cycle.image.ubuntu24, aligning the template’s defaults with the intended new baseline.

Changes:

  • Set SchedulerImageName default to cycle.image.ubuntu24
  • Set defaults for LoginImageName, HPCImageName, HTCImageName, GPUImageName, and DynamicImageName to cycle.image.ubuntu24
Criterion Max Points Points Awarded Notes
PR Description Accuracy 20 20 Description matches the template default image updates.
PR Atomicity 20 20 Single, focused change to defaults.
Logical Implementation 10 10 Straightforward value updates.
Regression Risk 10 10 No logic changes; only default selection updated.
Exception Handling 10 10 Not applicable (no code paths added/changed).
Code Comments 10 10 Not applicable (no comment/doc changes required).
Repetitive Code 10 10 No duplicated logic introduced.
Spelling 5 5 No spelling issues found in changed lines.
Logging Quality 5 5 Not applicable.

FINAL SCORE: 100/100

RECOMMENDATION: MERGE
RATIONALE: The PR cleanly updates the default image for all relevant node image parameters and matches the stated intent.
BLOCKERS: None

@azreenz
Azreen Zaman (azreenz) merged commit c5a13be into master Jul 28, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants