update default os to be ubuntu24 - #540
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the Slurm cluster template’s default OS image to Ubuntu 24.04 by switching the DefaultValue for all node role image parameters from cycle.image.ubuntu22 to cycle.image.ubuntu24, aligning the template’s defaults with the intended new baseline.
Changes:
- Set
SchedulerImageNamedefault tocycle.image.ubuntu24 - Set defaults for
LoginImageName,HPCImageName,HTCImageName,GPUImageName, andDynamicImageNametocycle.image.ubuntu24
| Criterion | Max Points | Points Awarded | Notes |
|---|---|---|---|
| PR Description Accuracy | 20 | 20 | Description matches the template default image updates. |
| PR Atomicity | 20 | 20 | Single, focused change to defaults. |
| Logical Implementation | 10 | 10 | Straightforward value updates. |
| Regression Risk | 10 | 10 | No logic changes; only default selection updated. |
| Exception Handling | 10 | 10 | Not applicable (no code paths added/changed). |
| Code Comments | 10 | 10 | Not applicable (no comment/doc changes required). |
| Repetitive Code | 10 | 10 | No duplicated logic introduced. |
| Spelling | 5 | 5 | No spelling issues found in changed lines. |
| Logging Quality | 5 | 5 | Not applicable. |
FINAL SCORE: 100/100
RECOMMENDATION: MERGE
RATIONALE: The PR cleanly updates the default image for all relevant node image parameters and matches the stated intent.
BLOCKERS: None
Azreen Zaman (azreenz)
requested review from
Aditi Gaur (aditigaur4),
bwatrous and
ryanhamel
July 27, 2026 20:53
bwatrous
approved these changes
Jul 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update each nodearray ImageName to be ubuntu 24 in slurm template.
