Skip generation of multiple config files along with build #1029
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
severussundar
changed the title
severussundar
changed the title
severussundar
requested review from
Aniruddh25,
JelteF,
Mathos1432,
aaronburtle,
aaronpowell,
abhishekkumams,
ayush3797,
gledis69,
jarupatj,
junsu0ms,
mbhaskar,
milismsft,
ravishetye,
seantleonard and
tarazou9
as code owners
abhishekkumams
approved these changes
Dec 13, 2022
Contributor
abhishekkumams
left a comment
abhishekkumams
left a comment
There was a problem hiding this comment.
LGTM, just one nit. Thanks for making the build faster.
seantleonard
approved these changes
Dec 13, 2022
Contributor
seantleonard
left a comment
seantleonard
left a comment
There was a problem hiding this comment.
Thank you for updating this! Will definitely speed up the CI/CD runs, because generating config files for all databases was VERY time consuming. Sometimes took longer than the actual tests.
ayush3797
approved these changes
Dec 14, 2022
severussundar
deleted the
dev/shyamsundarj/modify-generateConfigFiles-parameter
branch
abhishekkumams
pushed a commit
that referenced
this pull request
Dec 16, 2022
* accepting database type instead of bool * using database type in pipelines * changing leftover param to database type * updating docs * renaming param to generateConfigFile * renaming param to generateConfigFileForDbType
abhishekkumams
pushed a commit
that referenced
this pull request
Dec 16, 2022
* accepting database type instead of bool * using database type in pipelines * changing leftover param to database type * updating docs * renaming param to generateConfigFile * renaming param to generateConfigFileForDbType
abhishekkumams
added a commit
that referenced
this pull request
Dec 19, 2022
* Skip generation of multiple config files along with build (#1029) * accepting database type instead of bool * using database type in pipelines * changing leftover param to database type * updating docs * renaming param to generateConfigFile * renaming param to generateConfigFileForDbType * Adding support for nullable/varchar(*) result columns for stored-procedure (#1038) * adding support for nullable result columns * fix formatting * fixing nits * fixing test * Fix broken links (#1046) * Removing references to Cosmos Database in CLI/Engine/Pipelines/Config file names/Build commands. (#1045) * Removing references to Cosmos DatabaseType in CLI/Engine code * updating cosmos commands * updating scripts to use cosmosdb_nosql * updating pipeline files * updating cosmos -> cosmosdb_nosql * Renaming cosmos config file * fix pipeline issue * fix pipeline issue * fix pipeline issue * updating launch settings * debugging error * debugging error * debugging error * debugging error * Updating schema -> graphql-schema for cosmosdb_nosql * Reverting graphql-schema -> schema * Replacing references to cosmos with cosmosdb_nosql Co-authored-by: Ayush Agarwal <agarwalayush@microsoft.com> * Cli check for stored procedure Operations (#1041) * validation for stored-procedure permission in CLI * fix formatting * fixing tests * fix formatting * fix summary * fixing nits * fix formatting * fix formatting * addressing leftover comments from PR-1045 (#1052) * addressing leftover comments from PR-1045 * updating remaining references to cosmos in readme * updating cosmos getting started doc Co-authored-by: Ayush Agarwal <agarwalayush@microsoft.com> Co-authored-by: Shyam Sundar J <shyamsundarj@microsoft.com> Co-authored-by: Ayush Agarwal <34566234+ayush3797@users.noreply.github.com> Co-authored-by: Ayush Agarwal <agarwalayush@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why make this change?
dotnet build -p:generateConfigFiles=trueis used to generate the config files.MsSqlpipeline, it would be sufficient to generate only the config file for MsSql database type. Likewise, for other pipelines. Additionally, generating the config files for all database types leads to longer execution times for the pipeline runs.What is this change?
generateConfigFilesproperty is re-named togenerateConfigFileForDbType.generateConfigFileForDbTypeproperty accepts the database type (instead oftrue/false) and generates the config file for only that particular database.How was this tested?
Sample Request(s)