Cherry pick from last release ex version change #1053
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* accepting database type instead of bool * using database type in pipelines * changing leftover param to database type * updating docs * renaming param to generateConfigFile * renaming param to generateConfigFileForDbType
…edure (#1038) * adding support for nullable result columns * fix formatting * fixing nits * fixing test
… file names/Build commands. (#1045) * Removing references to Cosmos DatabaseType in CLI/Engine code * updating cosmos commands * updating scripts to use cosmosdb_nosql * updating pipeline files * updating cosmos -> cosmosdb_nosql * Renaming cosmos config file * fix pipeline issue * fix pipeline issue * fix pipeline issue * updating launch settings * debugging error * debugging error * debugging error * debugging error * Updating schema -> graphql-schema for cosmosdb_nosql * Reverting graphql-schema -> schema * Replacing references to cosmos with cosmosdb_nosql Co-authored-by: Ayush Agarwal <agarwalayush@microsoft.com>
* validation for stored-procedure permission in CLI * fix formatting * fixing tests * fix formatting * fix summary * fixing nits * fix formatting * fix formatting
* addressing leftover comments from PR-1045 * updating remaining references to cosmos in readme * updating cosmos getting started doc Co-authored-by: Ayush Agarwal <agarwalayush@microsoft.com>
abhishekkumams
requested review from
Aniruddh25,
JelteF,
Mathos1432,
aaronburtle,
aaronpowell,
ayush3797,
gledis69,
jarupatj,
junsu0ms,
mbhaskar,
milismsft,
ravishetye,
seantleonard,
severussundar and
tarazou9
as code owners
seantleonard
previously requested changes
Dec 16, 2022
Contributor
seantleonard
left a comment
seantleonard
left a comment
There was a problem hiding this comment.
Shouldn't this PR be trying to merge the cherry picked commits into the branch release/Nov2022 and not main?
Contributor
Author
hmm, correct. Thanks Sean. |
severussundar
approved these changes
Dec 19, 2022
ravishetye
approved these changes
Dec 19, 2022
abhishekkumams
deleted the
cherry_pick_from_last_release_ex_version_change
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why make this change?
What is this change?
minor-version-updatecommit.minor-version-updatecommit.How was this tested?