Updated Diagnostic Settings Policies for Synapse - #271
Merged
Conversation
Marvin Buss (marvinbuss)
added
bug
1 task
Marvin Buss (marvinbuss)
left a comment
Marvin Buss (marvinbuss)
left a comment
Collaborator
Author
There was a problem hiding this comment.
LGTM!
Marvin Buss (marvinbuss)
requested review from
Amanjeet Singh (amanjeetsingh) and
Espen Brandt-Kjelsen (esbran)
January 20, 2022 15:47
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of the Pull Request
This PR fixes the reported bug for DINE policies for Synapse. A wrong parameter caused errors.
Also, the log categories were outdated and updated. In addition, I added another Policy for Synapse workspaces itself in addition to the existing ones for sub-resources.
References
None
PR Checklist
Validation Steps Performed
See comments below