[eno] Update input controller to use buffer for writes - #634
Merged
Conversation
Ruinan Liu (ruinan-liu)
requested review from
Robbie Zhang (robbiezhang),
Tingting Liu (tilnl) and
xiazhan
as code owners
July 28, 2026 22:22
Adds a queue-depth gauge (eno_input_revision_write_buffer_depth), a flush-error counter partitioned by op (eno_input_revision_write_buffer_flush_errors_total), and a successful-flush counter (eno_input_revision_write_buffer_flush_total), mirroring the existing ResourceSliceWriteBuffer metrics. These errors retry silently today, so without this counter they're invisible. Addresses review item 5 on PR #634.
Tingting Liu (tilnl)
approved these changes
Aug 6, 2026
Ruinan Liu (ruinan-liu)
left a comment
Ruinan Liu (ruinan-liu)
left a comment
Collaborator
Author
There was a problem hiding this comment.
reply to comment
Tingting Liu (tilnl)
approved these changes
Aug 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On busy underlays, reduce write frequency and use buffer writes instead.