Skip to content

CICD : Added workflow for building main branch#3

Closed
Ealianis wants to merge 1 commit into
mainfrom
cicd-workflows-build
Closed

CICD : Added workflow for building main branch#3
Ealianis wants to merge 1 commit into
mainfrom
cicd-workflows-build

Conversation

@Ealianis

Copy link
Copy Markdown
Contributor

Workflow to build branch 'main' after PR or Push, and every weekday at 02:00 UTC.

Workflow to build branch 'main' after PR or Push, and every weekday at 02:00 UTC.
@Ealianis Ealianis closed this Jan 12, 2022
@Ealianis Ealianis reopened this Jan 12, 2022

@Ealianis Ealianis left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

comment check

@Ealianis Ealianis closed this Jan 12, 2022
@Ealianis
Ealianis deleted the cicd-workflows-build branch January 12, 2022 23:34
rchincha added a commit to rchincha/fleet-networking that referenced this pull request Jul 21, 2026
…erviceExport

Introduces the annotation and helper that will drive the ServiceExport
split between the L4 Traffic Manager path (today) and the L7 Front Door
path (Phase 4). Modeled as an annotation rather than a Spec field so the
ServiceExport CRD stays identical to upstream mcs-api (KEP-1645) -- see
docs/first-party/002-afd-implementation-plan.md Azure#3.4 and the breadcrumb
2026-07-20-1108-afd-export-mode-mcs-parity.md for the parity rationale.

New symbols:
- ServiceExportAnnotationExportMode = "networking.fleet.azure.com/export-mode"
- ExportModeValueTrafficManager     = "L4-TrafficManager"  (default)
- ExportModeValueFrontDoor          = "L7-FrontDoor"
- ExtractExportModeFromServiceExport(*v1beta1.ServiceExport) (string, error)

Semantics chosen to fail loudly on operator error:
- Absent annotation -> default TrafficManager, no error. Preserves current
  behaviour for every existing manifest.
- Explicit valid enum member -> returned verbatim.
- Empty string, wrong case, typo, anything else -> error with mode="".
  Empty is not silently defaulted because a mis-templated Helm value that
  resolves to "" would otherwise mask the intent; case sensitivity matches
  the CRD-side enum convention and downstream Azure APIs.

No reconciler wiring yet -- that lands in commit 8c. This commit is safe
to land alone: only adds symbols and a table-driven unit test.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Copilot-Session: a8fabc68-e113-49ef-b82d-d99a8502da11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants