Skip to content

Conversation

@britaniar
Copy link
Contributor

@britaniar britaniar commented Sep 8, 2025

Description of your changes

Fixes #

I have:

  • Run make reviewable to ensure this PR is ready for review.

How has this code been tested

Special notes for your reviewer

dfbda09 (cncf/main) test: add resource placement scheduler watchers test (#235)
2a00e6c fix: address an issue when processing duplicated manifests in envelopes (#230)
3d984cc chore: bump actions/setup-go from 5 to 6 (#241)
683a7b0 feat: (re-)enable parallel processing in the work applier (#234)
8a99647 feat: watcher for CRPS delete events (#227)
55be264 test: add mixed placements test (#237)
7eea6fa test: add RP E2Es for diff/drift (#219)
ea6d0fb feat: create/update CRPS when StatusReportingScope is NamespaceAccessible (#225)
71bb1d6 test: add e2e tests for RP for resource selection (#236)
f074137 test: add RP test for join and leave flow (#233)
9c61b4d fix: address a naming error in the envelope related E2E tests (#232)
046eff0 test: set up the binding watcher integration tests to wait for cache sync (#231)
24f72d8 fix: validate if the resource should be placed (#229)
f3c19fc test: add taint and toleration tests for RP (#228)
a7675f8 test: add RP apply strategy tests (#226)

zhiying-lin and others added 16 commits August 28, 2025 13:38
---------

Signed-off-by: Zhiying Lin <zhiyingl456@gmail.com>
Signed-off-by: Zhiying Lin <zhiyingl456@gmail.com>
…sync (Azure#231)

* Minor fixes

Signed-off-by: michaelawyu <chenyu1@microsoft.com>

* Minor fixes

Signed-off-by: michaelawyu <chenyu1@microsoft.com>

* Revert the timeout change in Azure#99

Signed-off-by: michaelawyu <chenyu1@microsoft.com>

* Use eventually block

Signed-off-by: michaelawyu <chenyu1@microsoft.com>

* Experimental

Signed-off-by: michaelawyu <chenyu1@microsoft.com>

* Revert experimental changes

Signed-off-by: michaelawyu <chenyu1@microsoft.com>

---------

Signed-off-by: michaelawyu <chenyu1@microsoft.com>
)

Minor fixes

Signed-off-by: michaelawyu <chenyu1@microsoft.com>
Signed-off-by: Wantong Jiang <wantjian@microsoft.com>
* Minor fixes

Signed-off-by: michaelawyu <chenyu1@microsoft.com>

* (Re-)enabled parallel processing in the work applier

Signed-off-by: michaelawyu <chenyu1@microsoft.com>

* Added unit tests

Signed-off-by: michaelawyu <chenyu1@microsoft.com>

* test: add RP apply strategy tests (Azure#226)

---------

Signed-off-by: Zhiying Lin <zhiyingl456@gmail.com>
Signed-off-by: michaelawyu <chenyu1@microsoft.com>

* test: add taint and toleration tests for RP (Azure#228)

Signed-off-by: michaelawyu <chenyu1@microsoft.com>

* fix: validate if the resource should be placed (Azure#229)

Signed-off-by: Zhiying Lin <zhiyingl456@gmail.com>
Signed-off-by: michaelawyu <chenyu1@microsoft.com>

* test: set up the binding watcher integration tests to wait for cache sync (Azure#231)

* Minor fixes

Signed-off-by: michaelawyu <chenyu1@microsoft.com>

* Minor fixes

Signed-off-by: michaelawyu <chenyu1@microsoft.com>

* Revert the timeout change in Azure#99

Signed-off-by: michaelawyu <chenyu1@microsoft.com>

* Use eventually block

Signed-off-by: michaelawyu <chenyu1@microsoft.com>

* Experimental

Signed-off-by: michaelawyu <chenyu1@microsoft.com>

* Revert experimental changes

Signed-off-by: michaelawyu <chenyu1@microsoft.com>

---------

Signed-off-by: michaelawyu <chenyu1@microsoft.com>

* test: add RP test for join and leave flow (Azure#233)

Signed-off-by: michaelawyu <chenyu1@microsoft.com>

* test: add e2e tests for RP for resource selection (Azure#236)

Signed-off-by: Wantong Jiang <wantjian@microsoft.com>
Signed-off-by: michaelawyu <chenyu1@microsoft.com>

---------

Signed-off-by: michaelawyu <chenyu1@microsoft.com>
Signed-off-by: Zhiying Lin <zhiyingl456@gmail.com>
Signed-off-by: Wantong Jiang <wantjian@microsoft.com>
Co-authored-by: Zhiying Lin <54013513+zhiying-lin@users.noreply.github.com>
Co-authored-by: Wantong <jwtty0919@gmail.com>
Bumps [actions/setup-go](https://github.com/actions/setup-go) from 5 to 6.
- [Release notes](https://github.com/actions/setup-go/releases)
- [Commits](actions/setup-go@v5...v6)

---
updated-dependencies:
- dependency-name: actions/setup-go
  dependency-version: '6'
  dependency-type: direct:production
  update-type: version-update:semver-major
...
…es (Azure#230)

---------

Signed-off-by: michaelawyu <chenyu1@microsoft.com>
Copy link
Contributor

@jwtty jwtty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

resource placement change lgtm

@ryanzhang-oss ryanzhang-oss merged commit 243f387 into Azure:main Sep 8, 2025
21 checks passed
@britaniar britaniar deleted the backportSept branch September 8, 2025 22:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants