Skip to content

Conversation

@ryanzhang-oss
Copy link
Contributor

Description of your changes

Add the pending manifest list to the placement status

I have:

  • Run make reviewable to ensure this PR is ready for review.

How has this code been tested

Integration tested

Special notes for your reviewer

This is part 5 of the series of PRs that leads to (mostly) workload orchestration code completion with integrated tests.

@ryanzhang-oss ryanzhang-oss requested a review from Fei-Guo August 3, 2022 10:13
@Fei-Guo
Copy link
Contributor

Fei-Guo commented Aug 3, 2022

Can we postpone this api change until users really want to know the list?

To me, if the crp condition is not successful and there are no failed placements populated, all resources are pending.

@ryanzhang-oss
Copy link
Contributor Author

Can we postpone this api change until users really want to know the list?

To me, if the crp condition is not successful and there are no failed placements populated, all resources are pending.

yes, that's why the API says we only mark a resource as pending after a configurable time. Otherwise, all the resources are pending right after a schedule.

Currently, I am putting those manifests that are not picked up after a configurable time to the failed list which seems not a good idea.

We can either go with what you said (which is a lot simpler to implement).

@ryanzhang-oss
Copy link
Contributor Author

we will not add the pending list, for now, it's in-memory.

@ryanzhang-oss ryanzhang-oss deleted the add-pending-list branch August 22, 2022 22:38
britaniar added a commit to britaniar/fleet that referenced this pull request Sep 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants