feat: Watch IMC Leave hub agent#59
Merged
Merged
Conversation
Arvindthiru
force-pushed
the
WatchIMCLeave
branch
from
June 9, 2022 00:17
b94ef78 to
567f898
Compare
Arvindthiru
marked this pull request as ready for review
June 9, 2022 00:23
minhng22
reviewed
Jun 9, 2022
helayoty
reviewed
Jun 9, 2022
helayoty
reviewed
Jun 9, 2022
| return nil | ||
| } | ||
|
|
||
| // addMemberClusterFinalizers is used to add finalizer strings for all the resources created for a member cluster. |
Contributor
There was a problem hiding this comment.
I'd add SetControllerReference in the reconciler for the memberclutser as an owner.
https://pkg.go.dev/sigs.k8s.io/controller-runtime/pkg/controller/controllerutil#SetOwnerReference
Contributor
Author
There was a problem hiding this comment.
I'll open an issue to address this in a following PR #78
helayoty
reviewed
Jun 9, 2022
helayoty
reviewed
Jun 9, 2022
ryanzhang-oss
left a comment
ryanzhang-oss
left a comment
Contributor
There was a problem hiding this comment.
Please check this in and I will add an adjustment PR afterwards
| if (joinCondition != nil && joinCondition.Status == metav1.ConditionTrue) && (heartBeatCondition != nil && heartBeatCondition.Status == metav1.ConditionTrue) { | ||
| err := r.updateMemberClusterStatus(ctx, mc, imc.Status) | ||
|
|
||
| if (joinedCondition != nil && joinedCondition.Status == metav1.ConditionTrue) && (heartBeatCondition != nil && heartBeatCondition.Status == metav1.ConditionTrue) { |
Contributor
There was a problem hiding this comment.
the join status should not be mixed with heartbeat status
| err := r.updateMemberClusterStatus(ctx, mc, imc.Status) | ||
|
|
||
| if (joinedCondition != nil && joinedCondition.Status == metav1.ConditionTrue) && (heartBeatCondition != nil && heartBeatCondition.Status == metav1.ConditionTrue) { | ||
| err := r.updateMemberClusterStatusAsJoined(ctx, mc, imc.Status) |
Contributor
There was a problem hiding this comment.
maybe not update the mc status if there is nothing to update (in that function which is not in this PR).
| internalMemberClusterLeftCondition := imc.GetCondition(fleetv1alpha1.ConditionTypeInternalMemberClusterJoin) | ||
| memberClusterLeftCondition := mc.GetCondition(fleetv1alpha1.ConditionTypeInternalMemberClusterJoin) | ||
|
|
||
| if (internalMemberClusterLeftCondition != nil && internalMemberClusterLeftCondition.Status == metav1.ConditionFalse) && memberClusterLeftCondition != nil { |
Contributor
There was a problem hiding this comment.
why put this in the loop instead of using the finalizer?
Contributor
There was a problem hiding this comment.
you can put a finalizer in the imc and delete the imc.
Arvindthiru
force-pushed
the
WatchIMCLeave
branch
from
June 10, 2022 05:51
567f898 to
5c732ad
Compare
ryanzhang-oss
approved these changes
Jun 10, 2022
Arvindthiru
force-pushed
the
WatchIMCLeave
branch
from
June 10, 2022 20:46
db269c4 to
1e7da3f
Compare
britaniar
pushed a commit
to britaniar/fleet
that referenced
this pull request
May 15, 2025
… (except the first one) to fail due to conflicts (Azure#59)
britaniar
pushed a commit
to britaniar/fleet
that referenced
this pull request
May 15, 2025
… (except the first one) to fail due to conflicts (Azure#59)
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of your changes
Fixes #
I have:
make reviewableto ensure this PR is ready for review.How has this code been tested
The code has been tested on a Kind Cluster
Special notes for your reviewer
Unit tests and Integration tests will be added in the following PRs