kube, forge: delete unused cluster and Azure helpers - #678
Open
Philip Lombardi (plombardi89) wants to merge 1 commit into
Open
kube, forge: delete unused cluster and Azure helpers#678Philip Lombardi (plombardi89) wants to merge 1 commit into
Philip Lombardi (plombardi89) wants to merge 1 commit into
Conversation
internal/kube:
- configmap.go goes entirely; ApplyConfigMap had no caller.
- CheckKubectlAvailable, KubectlCmd and its private streamLogs are dead.
Kubectl and KubectlFunc stay: cmd/kubectl-unbounded and two forge packages
use them to build the command themselves.
- ApplyManifestsInDirectory had no caller outside its own tests. The live
entry point is ApplyManifests, which takes bytes and is called from
site_init.go and machine_register.go. Its five tests
(TestApplyManifestsV2_WalksDirectory, _NotADirectory, _DirectoryNotFound,
_EmptyDirectory, _SkipPaths) go with it; they were the only thing keeping
the directory walk alive.
BootstrapToken.String in internal/kube is reported dead and is kept, with a
comment saying so. It redacts the secret, so its absence is what would be the
bug: the hazard shows up the first time anyone formats the struct into a log
line. This is the one case in this series where "no caller" is the wrong reason
to delete.
The identically named method in hack/cmd/forge/forge/kube does the opposite -
it interpolates the raw secret - and that one is deleted rather than kept. The
two packages are grouped in one change because that contrast is the argument.
hack/cmd/forge:
- subnet.go, virtual_machine.go and network_interface.go go entirely.
SubnetManager, VirtualMachineManager and NetworkInterfaceManager have no
constructor anywhere; forge provisions through the AKS and VMSS paths.
- ManagedClusterBuilder.DNSServiceIP, ManagedClusterBuilder.WithGeneratedSSH,
AzureKubernetesClusterManager.AddAgentPool and KeyVaultManager.Delete.
- AzureKubernetesClusterManager.GetAgentPool is a second-order finding: it
shared the AgentPoolsCli field with AddAgentPool, and with both gone the
field has no reader, and neither does the
ClientSet.ManagedClusterAgentPoolsClient that filled it. The whole
agent-pool client plumbing goes.
That chain is what `unused` structurally cannot reach: a struct field whose
only remaining mention is the assignment that populates it counts as used
under field-writes-are-uses, so a dead method leading to a dead client
factory call stays invisible until someone follows it by hand.
- ClientSet.Credential and ClientSet.CurrentIdentityType.
ClientSet.NewBlobStorageClient was the package's only use of the azblob
module.
- kube/secret.go; ApplySecret had no caller.
- defaultGatewayPoolAgentPoolName, an unexported constant in a const group
whose other member is live, which is why `unused` never reported it.
Refs #670
This was referenced Aug 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of the #670 dead-code sweep, split by component. The tooling that produced these findings is #673; this PR is deletions only and is independent of the other eight — the file sets are disjoint, so they can be reviewed and merged in any order and in parallel.
Why two analyzers were needed to find this
unusedcannot see dead exported code underinternal/. That is a documented design decision, not a gap:unused/unused.go:48-62holds that a package uses its exported named types and a named type uses its exported methods, so every method on an exported type is transitively live because the type is exported.x/tools/cmd/deadcodedoes not close that gap on its own either.x/tools/go/callgraph/rta/rta.go:281-287,433-437— converting a value to an interface materializes its runtime type and marks every exported method of that type reachable, because reflection could call any of them. Onevar i any = xanywhere buys all ofx's exported methods a clean bill of health.So #673 adds both
deadcodeandhack/cmd/unreferenced, which resolves identifiers instead of tracing reachability. Neither subsumes the other, and findings below are attributed to whichever one saw them.kube, forge: delete unused cluster and Azure helpers
internal/kube:
Kubectl and KubectlFunc stay: cmd/kubectl-unbounded and two forge packages
use them to build the command themselves.
entry point is ApplyManifests, which takes bytes and is called from
site_init.go and machine_register.go. Its five tests
(TestApplyManifestsV2_WalksDirectory, _NotADirectory, _DirectoryNotFound,
_EmptyDirectory, _SkipPaths) go with it; they were the only thing keeping
the directory walk alive.
BootstrapToken.String in internal/kube is reported dead and is kept, with a
comment saying so. It redacts the secret, so its absence is what would be the
bug: the hazard shows up the first time anyone formats the struct into a log
line. This is the one case in this series where "no caller" is the wrong reason
to delete.
The identically named method in hack/cmd/forge/forge/kube does the opposite -
it interpolates the raw secret - and that one is deleted rather than kept. The
two packages are grouped in one change because that contrast is the argument.
hack/cmd/forge:
subnet.go, virtual_machine.go and network_interface.go go entirely.
SubnetManager, VirtualMachineManager and NetworkInterfaceManager have no
constructor anywhere; forge provisions through the AKS and VMSS paths.
ManagedClusterBuilder.DNSServiceIP, ManagedClusterBuilder.WithGeneratedSSH,
AzureKubernetesClusterManager.AddAgentPool and KeyVaultManager.Delete.
AzureKubernetesClusterManager.GetAgentPool is a second-order finding: it
shared the AgentPoolsCli field with AddAgentPool, and with both gone the
field has no reader, and neither does the
ClientSet.ManagedClusterAgentPoolsClient that filled it. The whole
agent-pool client plumbing goes.
That chain is what
unusedstructurally cannot reach: a struct field whoseonly remaining mention is the assignment that populates it counts as used
under field-writes-are-uses, so a dead method leading to a dead client
factory call stays invisible until someone follows it by hand.
ClientSet.Credential and ClientSet.CurrentIdentityType.
ClientSet.NewBlobStorageClient was the package's only use of the azblob
module.
kube/secret.go; ApplySecret had no caller.
defaultGatewayPoolAgentPoolName, an unexported constant in a const group
whose other member is live, which is why
unusednever reported it.Refs #670
Verification
go build ./...,go vet ./...,golangci-lintover the touched trees (0 issues),make fmtproducing no diff, andgo build -tags e2e,integrationtest,storageboundary ./.... Full suite runs in CI.The eight deletion branches were reassembled onto the tooling commits and diffed against the original combined branch: byte-identical, so nothing was lost or duplicated in the split.